What is use_relative_hooks and why does gclient keep bugging me about it?

147 views
Skip to first unread message

Ian Barkley-Yeung

unread,
Mar 22, 2021, 10:14:14 PM3/22/21
to Chromium-dev
My DEPS file has no "use_relative_hooks", but gclient keeps bugging me to remove it anyways.

$ grep use_relative_hooks DEPS
$ gclient sync --jobs 16
use_relative_hooks is deprecated, please remove it from DEPS. (it was merged in use_relative_paths)                            
Syncing projects: 100% (236/236), done. 
(etc)

What is up with that? 

Thanks
Ian

Takuto Ikuta

unread,
Mar 22, 2021, 10:18:00 PM3/22/21
to i...@chromium.org, Chromium-dev
Does `--verbose` show where the gclient sees such a variable?

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/7af844d0-e10e-4439-9d0d-8dec986c343an%40chromium.org.

Takuto Ikuta

unread,
Mar 22, 2021, 10:19:29 PM3/22/21
to i...@chromium.org, Chromium-dev

Ian Barkley-Yeung

unread,
Mar 22, 2021, 10:35:23 PM3/22/21
to Takuto Ikuta, Chromium-dev
It appears in between the sections for src/remoting/webapp/app_remoting/internal and src/tools/perf/data. Not sure if the warning is associated with the next section or the previous section.

src/remoting/webapp/app_remoting/internal (Elapsed: 0:00:05)
----------------------------------------
[0:00:14] Started.
_____ src/remoting/webapp/app_remoting/internal at refs/remotes/origin/master
[0:00:16] Finished running: git config remote.origin.url
[0:00:16] Finished running: git rev-list -n 1 HEAD
[0:00:16] Finished running: git rev-parse --abbrev-ref=strict HEAD

________ running 'git -c core.deltaBaseCacheLimit=2g fetch origin --verbose --no-tags' in '/ssd/iby/chromium/src/remoting/webap
p/app_remoting/internal'

[0:00:18] POST git-upload-pack (102 bytes)
[0:00:18] From persistent-https://chrome-internal.git.corp.google.com/chrome/remoting/webapp/app_remoting/internal
[0:00:18]  = [up to date]      master     -> origin/master
[0:00:19] Fetching origin
[0:00:20] Finished running: git rev-list -n 1 HEAD
[0:00:20] Finished running: git checkout --quiet refs/remotes/origin/master
[0:00:20] Finished running: git rev-parse HEAD
Checked out revision 5ad5339af97c3bd193d595de03f34282491ce495
[0:00:20] Finished running: git rev-parse --verify HEAD
[0:00:20] Finished.
----------------------------------------

use_relative_hooks is deprecated, please remove it from DEPS. (it was merged in use_relative_paths)
gclient(803) ParseDepsFile:Updating hook base working directory to /ssd/iby/chromium/src/chromeos/assistant/libassistant/src.

src/tools/perf/data (Elapsed: 0:00:05)
----------------------------------------
[0:00:15] Started.
_____ src/tools/perf/data at refs/remotes/origin/master
[0:00:16] Finished running: git config remote.origin.url
[0:00:16] Finished running: git rev-list -n 1 HEAD
[0:00:17] Finished running: git rev-parse --abbrev-ref=strict HEAD

________ running 'git -c core.deltaBaseCacheLimit=2g fetch origin --verbose --no-tags' in '/ssd/iby/chromium/src/tools/perf/dat
a'

Takuto Ikuta

unread,
Mar 22, 2021, 10:48:04 PM3/22/21
to Ian Barkley-Yeung, Chromium-dev
Did you run `grep` in the directory having .gclient?
If so, you can file a bug to clarify the warning in the Infra>SDK component.

Michael Moss

unread,
Mar 23, 2021, 1:04:50 AM3/23/21
to tik...@chromium.org, Ian Barkley-Yeung, Chromium-dev
There's a clue in:
gclient(803) ParseDepsFile:Updating hook base working directory to /ssd/iby/chromium/src/chromeos/assistant/libassistant/src.

That's a reference to (internal only):
which is brought in by some seriously enthusiastic recursedeps (src->src-internal->src/chromeos/assistant/internal->src/chromeos/assistant/libassistant/src).

The OWNERS should probably update that DEPS.


Reply all
Reply to author
Forward
0 new messages