Using clang's new Warning Suppression Mappings in chromium

[Devon Loehr]

Clang recently added the ability to suppress warnings based on the filepath they originate from. This is done by passing in a Warning Suppression Mappings (WSM) file, which says which paths should be suppressed for each warning.

I've been looking at using a WSM file in chromium, and I've compiled a document (here) describing our current situation, how WSMs could improve it, and what the important considerations are. I'm circulating it here to look for feedback and discussion from those who are interested in our build system -- are there other considerations I've missed? Do the recommendations seem reasonable? I'm interested to hear peoples' thoughts.

--Devon Loehr

[Erik Chen]

Thanks Devon for the detailed writeup. I agree with the final assessment that we should add a WSM but have some rules/restrictions on how it's used. Your guidelines seem reasonable to me. Let's make you and a +1 the owner of the WSM file. :)

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/fff21411-af3c-40b6-8805-19fa789718dbn%40chromium.org.

[Zotsi Cyäé piandao]

💪🏻💪🏻💪🏻🙏🏻😌

To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEYHnr3Uz-F8m0FCqGCKweDfSNrLkPr9F4jg4Spgq8s4YxELFg%40mail.gmail.com.