chrome release build flag?

[Huapeng Li]

Hi,

Are there any ways to check what GN build flags Chrome(not Chromium) release build uses?

We recently had a problem not setting "fieldtrial_testing_like_official_build". We would like to know what Chrome is using.

Thanks

[Lei Zhang]

In build/config/features.gni, the one and only assignment to that variable is:

fieldtrial_testing_like_official_build = is_chrome_branded

So Chrome sets that to true.

For context, I think you are referring to the problem mentioned here:
https://groups.google.com/a/chromium.org/d/topic/chromium-packagers/ECWC57W7E0k/discussion

> --
> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-dev
> ---
> You received this message because you are subscribed to the Google Groups
> "Chromium-dev" group.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/e38c2727-70a2-477e-8644-5c077ab3d905%40chromium.org.

[Dirk Pranke]

Also, literally the only GN flag that we set on official builds (on desktop) is `is_official_build=true` :). Everything else keys off of that.

We don't make the actual official build logs public, but the configuration that they use is, set here:

https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?l=437

iOS and Android official builds actually have a few more flags that can't be keyed off a default, like setting target_os, target_cpu, etc.

-- Dirk

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CACSHbcSwxVh3OKz_qsjedefWj43XYr_Sym%3D8qyyKDfKkrY3nvA%40mail.gmail.com.

[Torne (Richard Coles)]

If you're making an end user build you probably should just set is_official_build=true as well. This is supposed to include all optimisations/etc suitable for end users, and shouldn't include Chrome-specific stuff (which is supposed to be based on is_chrome_branded).

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEoffTC16es7V58GhG_VP8V769y%3DVg%2BxNgeMKjZOWaBH_wA9_A%40mail.gmail.com.

[Jens Jensen]

Hey Dirk,

is it correct that is_official_build=true shouldn't be used for mobile/Android builds?

[Dirk Pranke]

Not as far as I know. What made you think that?

-- Dirk

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/9c8ac737-fd09-47a0-b760-3f85bbe3bf1b%40chromium.org.

[Jens Jensen]

Dirk, because it sounds like in one of your older answers:

Also, literally the only GN flag that we set on official builds (on desktop) is `is_official_build=true`

But now, when I read it again, it could also be interpreted differently. So you also set is_official_build=true for release builds for Android?

[Dirk Pranke]

On Sun, Feb 18, 2018 at 4:21 AM, Jens Jensen <wangenh...@gmail.com> wrote:

Dirk, because it sounds like in one of your older answers:

Also, literally the only GN flag that we set on official builds (on desktop) is `is_official_build=true`

But now, when I read it again, it could also be interpreted differently. So you also set is_official_build=true for release builds for Android?

Yes. Sorry for any confusion.

-- Dirk

 

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/7e707017-4caf-4e87-bd86-9a130de65570%40chromium.org.

[Torne (Richard Coles)]

You should set is_official_build=true for all builds that you intend to be used by users, no matter what OS/platform/etc. "official build" here is supposed to mean "as opposed to a developer build", not anything to do with Google/Chrome/etc.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEoffTD6b1ZOXwi9TWa3ibBMhvv3eX%2BJwtPUMWUQch5nVeBk2Q%40mail.gmail.com.