CPP defines for determining the build type

34 views
Skip to first unread message

Jochen Eisinger

unread,
Dec 12, 2011, 4:11:48 AM12/12/11
to chromium-dev
Hey,

I wonder what the difference between OFFICIAL_BUILD and GOOGLE_CHROME_BUILD is (supposed to be)?

Seems like most places use GOOGLE_CHROME_BUILD, and some even state that OFFICIAL_BUILD was only defined on windows?

Should we just update all places to use one of the two defines?

best
-jochen

Marc-Antoine Ruel

unread,
Dec 12, 2011, 10:46:05 AM12/12/11
to joc...@chromium.org, chromium-dev
In theory...

OFFICIAL_BUILD is mostly related to windows, where /LTCG is used, DCHECKs are disabled for sure, etc resulting in a 3 hours build.

GOOGLE_CHROME_BUILD is the Google branded build.

In practice, I don't think it's working independently. :/

M-A

-jochen

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

Jochen Eisinger

unread,
Dec 12, 2011, 10:52:39 AM12/12/11
to Marc-Antoine Ruel, chromium-dev
On Mon, Dec 12, 2011 at 4:46 PM, Marc-Antoine Ruel <mar...@chromium.org> wrote:
In theory...

OFFICIAL_BUILD is mostly related to windows, where /LTCG is used, DCHECKs are disabled for sure, etc resulting in a 3 hours build.

GOOGLE_CHROME_BUILD is the Google branded build.

In practice, I don't think it's working independently. :/
 
Should we then just use GOOGLE_CHROME_BUILD everywhere?

Nico Weber

unread,
Dec 12, 2011, 11:10:40 AM12/12/11
to joc...@chromium.org, Marc-Antoine Ruel, chromium-dev
This is http://crbug.com/16512 – see the comments added by tvl at the
bottom. +1 on having just one define.

Nico

Reply all
Reply to author
Forward
0 new messages