CPP defines for determining the build type

[Jochen Eisinger]

Hey,

I wonder what the difference between OFFICIAL_BUILD and GOOGLE_CHROME_BUILD is (supposed to be)?

Seems like most places use GOOGLE_CHROME_BUILD, and some even state that OFFICIAL_BUILD was only defined on windows?

Should we just update all places to use one of the two defines?

best

-jochen

[Marc-Antoine Ruel]

In theory...

OFFICIAL_BUILD is mostly related to windows, where /LTCG is used, DCHECKs are disabled for sure, etc resulting in a 3 hours build.

GOOGLE_CHROME_BUILD is the Google branded build.

In practice, I don't think it's working independently. :/

M-A

-jochen

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[Jochen Eisinger]

On Mon, Dec 12, 2011 at 4:46 PM, Marc-Antoine Ruel <mar...@chromium.org> wrote:

In theory...

OFFICIAL_BUILD is mostly related to windows, where /LTCG is used, DCHECKs are disabled for sure, etc resulting in a 3 hours build.

GOOGLE_CHROME_BUILD is the Google branded build.

In practice, I don't think it's working independently. :/

 

Should we then just use GOOGLE_CHROME_BUILD everywhere?

[Nico Weber]

This is http://crbug.com/16512 – see the comments added by tvl at the
bottom. +1 on having just one define.

Nico