PSA: Deprecating Compact Language Detector v1

[Andrew Hayden]

Hey folks,

If you don't care about language detection or translation features in Chrome, you can stop reading now.

For everyone else, this CL has migrated Android's use of Compact Language Detector (CLD) from CLD1 to CLD2: https://codereview.chromium.org/1327543003. Android was the last platform still using CLD1 and there are no longer any dependencies on CLD1 in any GN or GYP build targets that I am aware of. I intend to remove all support for CLD1 in December 2015, approximately three months from now. If you still require support for CLD1, please reply on the bug linked below so that we can track your dependency and get it taken care of in time.

For more information, please refer to this bug:

https://code.google.com/p/chromium/issues/detail?id=528257

Regards,

Andrew Hayden

[Nico Weber]

Why wait so long? https://codereview.chromium.org/1327543003 landed 50 min ago, why not remove it right now?

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[Andrew Hayden]

Great question, Nico. Android has catalogued several crashing bugs (most with restricted access, sorry) that seem to disproportionately affect CLD2 on ARM v7. While I am hopeful that we've gotten to the bottom of almost all of them and resolved them, I think it would be premature to nuke CLD1 from orbit just yet in case we discover that we need to go back to it for stability reasons. I expect that by December this change will have had time to bake and be thoroughly tested on lots of devices, then we can safely remove CLD1 without worry.

Plus the bits have been rotting in the tree for a very long time now, a few more months won't hurt :)

-Andrew

[Andrew Hayden]

I'm planning to start this in the very near future. This bug will track progress, for anyone who is interested:

https://bugs.chromium.org/p/chromium/issues/detail?id=605688

[Andrew Hayden]

I have just submitted the change to eliminate support for CLD1 here:

https://codereview.chromium.org/1920853002/

Please let me know if this causes your builds to explode with errors about CLD and/or translate. All bots were green and all tests passing, so we should be in good shape.

-Andrew

[Nico Weber]

Can third_party/cld be deleted too now?

--

[Andrew Hayden]

Yes, I'm just waiting a day or two to be sure that the gyp + gn changes stick. Then I'll kill cld1 from the DEPS.

[Andrew Hayden]

After some fun with rietveld and gerrit, this is now done:

https://chromium.googlesource.com/chromium/src/+/c0c0cab516d52d7e58397b7c2d61839b1be69d5b

CLD1 is no more.

Regards,

Andrew