compile error in net/socket/tcp_client_socket.win.cc

[baibaichen]

Hi All

I sync to revision #39851, and rebuild chrome project (by cleaning up
chrome/Debug folder)

vs 2008 compiler reports addrinfo are not defined in net/socket/
tcp_client_socket.win.cc at line 342

I mannually fix this issue by including net/base/sys_addrinfo.h, but
this file is added at #34399, and some of sources file already
included it in the same revision, for example, net/socket/
socks_client_socket.cc

I am not sure this is sure in source(i.e. we do need inlcude this
header) or my compiler environment issue(buildbot said that this
revision is open when i sync)

Any idea?

Thanks
Chang

[Eric Roman]

Adding an include of net/base/sys_addrinfo.h to
tcp_client_socket_win.cc sounds fine to me.
I can check something like that in, or feel free to send me a code review.

> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
>    http://groups.google.com/a/chromium.org/group/chromium-dev
>

[baibaichen]

unfortunately, i can not access code reivew site

-Chang

On Feb 25, 12:05 pm, Eric Roman <ero...@chromium.org> wrote:
> Adding an include of net/base/sys_addrinfo.h to
> tcp_client_socket_win.cc sounds fine to me.
> I can check something like that in, or feel free to send me a code review.
>
>
>
> On Wed, Feb 24, 2010 at 7:29 PM, baibaichen <baibaic...@gmail.com> wrote:
> > Hi All
>
> > I sync to revision #39851,  and rebuild chrome project (by cleaning up
> > chrome/Debug folder)
>
> > vs 2008 compiler reports addrinfo are not defined in net/socket/
> > tcp_client_socket.win.cc  at line 342
>
> > I mannually fix this issue by including net/base/sys_addrinfo.h, but
> > this file is added at #34399, and some of sources file already
> > included it in the same revision, for example, net/socket/
> > socks_client_socket.cc
>
> > I am not sure this is sure in source(i.e. we do need inlcude this
> > header) or my compiler environment issue(buildbot said that this
> > revision is open when i sync)
>
> > Any idea?
>
> > Thanks
> > Chang
>
> > --

> > Chromium Developers mailing list: chromium-...@chromium.org

> > View archives, change email options, or unsubscribe:

> >    http://groups.google.com/a/chromium.org/group/chromium-dev- Hide quoted text -
>
> - Show quoted text -

[Hironori Bono (坊野 博典)]

Greetings,

If I recall correctly, this error happens when we compile Chromium
with Windows SDK 6.1 (or 6.0a) since Windows SDK 7 has moved the
definition of "struct addrinfo" from <ws2tcpip.h> to <ws2def.h>. Have
you installed Windows SDK 7 and integrated it into Visual Studio? (I
don't have any ideas about whether or not we should add
"net/base/sys_addrinfo.h" in the file.)

Best regards,

Hironori Bono
E-mail: hb...@chromium.org

> --
> Chromium Developers mailing list: chromi...@chromium.org

[Eric Roman]

Thanks for the analysis Hinori!
Checked in a fix.

2010/2/24 Hironori Bono (坊野 博典) <hb...@chromium.org>:

[baibaichen]

Thanks for your fix!

-Chang

On Feb 25, 12:46 pm, Eric Roman <ero...@chromium.org> wrote:
> Thanks for the analysis Hinori!
> Checked in a fix.
>
> 2010/2/24 Hironori Bono (坊野 博典) <hb...@chromium.org>:
>
>
>
> > Greetings,
>
> > If I recall correctly, this error happens when we compile Chromium
> > with Windows SDK 6.1 (or 6.0a) since Windows SDK 7 has moved the
> > definition of "struct addrinfo" from <ws2tcpip.h> to <ws2def.h>. Have
> > you installed Windows SDK 7 and integrated it into Visual Studio? (I
> > don't have any ideas about whether or not we should add
> > "net/base/sys_addrinfo.h" in the file.)
>
> > Best regards,
>
> > Hironori Bono
> > E-mail: hb...@chromium.org
>

> > On Thu, Feb 25, 2010 at 12:29 PM, baibaichen <baibaic...@gmail.com> wrote:
> >> Hi All
>
> >> I sync to revision #39851,  and rebuild chrome project (by cleaning up
> >> chrome/Debug folder)
>
> >> vs 2008 compiler reports addrinfo are not defined in net/socket/
> >> tcp_client_socket.win.cc  at line 342
>
> >> I mannually fix this issue by including net/base/sys_addrinfo.h, but
> >> this file is added at #34399, and some of sources file already
> >> included it in the same revision, for example, net/socket/
> >> socks_client_socket.cc
>
> >> I am not sure this is sure in source(i.e. we do need inlcude this
> >> header) or my compiler environment issue(buildbot said that this
> >> revision is open when i sync)
>
> >> Any idea?
>
> >> Thanks
> >> Chang
>
> >> --

> >> Chromium Developers mailing list: chromium-...@chromium.org

> >> View archives, change email options, or unsubscribe:
> >>    http://groups.google.com/a/chromium.org/group/chromium-dev
>
> > --

> > Chromium Developers mailing list: chromium-...@chromium.org

> > View archives, change email options, or unsubscribe:

[baibaichen]

Hi Hironori Bono

Thanks for your explianing, I do use Windows SDK 6.1, is it mandatory
to use Windows 7 SDK?

-Chang

> > Chromium Developers mailing list: chromium-...@chromium.org

> > View archives, change email options, or unsubscribe:

[Tim Steele]

I'm wondering this too? chron was having this same issue earlier as well, but the docs on dev.chromium.org still said either of 6.1/7 was valid, so I wasn't sure what to suggest.

2010/2/24 baibaichen <baiba...@gmail.com>

Chromium Developers mailing list: chromi...@chromium.org

[Peter Kasting]

On Wed, Feb 24, 2010 at 10:52 PM, Tim Steele <t...@chromium.org> wrote:

I'm wondering this too? chron was having this same issue earlier as well, but the docs on dev.chromium.org still said either of 6.1/7 was valid, so I wasn't sure what to suggest.

I think for simplicity's sake we should just say to use 7, unless there's a compelling reason why we would want to explicitly support both.

PK 

[Jonathan Huang]

When I ran into this, I updated the doc to indicate needing 7. You
will also need one of the ATL patches that's already listed there.

--
Now With Calcium and Vitamin D