Trying to build custom branded chromium on Mac causes icudtl.dat not found in bundle

[Nicholas DiPiazza]

I am trying to build my own chromium. I was able to build windows, now I am moving onto mac.

I am customizing the branding so I can have my own icon and browser name.

chromium/src/chrome/app/theme/chromium/BRANDING

COMPANY_FULLNAME=The NewChromium Authors
COMPANY_SHORTNAME=The NewChromium Authors
PRODUCT_FULLNAME=NewChromium
PRODUCT_SHORTNAME=NewChromium
PRODUCT_INSTALLER_FULLNAME=NewChromium Installer
PRODUCT_INSTALLER_SHORTNAME=NewChromium Installer
COPYRIGHT=Copyright 2017 The NewChromium Authors. All rights reserved.
MAC_BUNDLE_ID=org.newchromium.NewChromium
MAC_CREATOR_CODE=Cr24

And here is the args.gn:

remove_webcore_debug_symbols = true
is_official_build = true
is_debug = false
google_api_key = "xxxx"
google_default_client_id = "xxxx"
google_default_client_secret = "xxxxx"
symbol_level = 0

Then I build:

ninja -C out/NewChromium chrome

As expected, I do get a ./out/NewChromium/NewChromium.app

But when I launch it I get:

[0821/211427.998086:ERROR:icu_util.cc(114)] icudtl.dat not found in bundle
[0821/211427.998997:ERROR:icu_util.cc(133)] Invalid file descriptor to ICU data received.

Trace/BPT trap: 5

If I revert back to the default chromium/src/chrome/app/theme/chromium/BRANDING it works fine.

Am I missing some key change that needs to accompany BRANDING? Thanks!

[Nicholas DiPiazza]

Can't seem to figure this out. 

Just re-pinging the list on this one to see if anyone has a chance to look. 

[Nico Weber]

Does it work if you don't modify chromium/src/chrome/app/theme/chromium/BRANDING ?

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/0c135643-8366-47c4-a146-d92bd88ac610%40chromium.org.

[Nicholas DiPiazza]

Yes it does. So there must need to be some accompanying change with that some where that I'm missing for Mac?

[Nico Weber]

I'd make a build with and without your changes and then use `opendiff` to compare the two app bundles.

I think https://cs.chromium.org/chromium/src/chrome/BUILD.gn?type=cs&q=icudtl.dat+file:%5C.gn&sq=package:chromium&g=0&l=911 is what's supposed to copy icudtl.dat into the bundle.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/2c177db6-adde-4f9d-8cbb-361023bfbb88%40chromium.org.

[Nicholas DiPiazza]

thank you that is very helpful. i should be able to trace it back from there.

[Nicholas DiPiazza]

adding Chromium Packagers to this discussion.

Dirk & team, does anyone know the steps to change the branding on the mac installer?

See this thread for my attempts. It seems like when I change the installer name in BRANDING the installer gets botched.

Full error message:

/Users/myuser/Downloads/CustomName.app/Contents/MacOS/CustomName
[0827/111157.056296:ERROR:icu_util.cc(114)] icudtl.dat not found in bundle
[0827/111157.056374:ERROR:icu_util.cc(133)] Invalid file descriptor to ICU data received.
[0827/111157.056387:FATAL:content_main_delegate.cc(53)] Check failed: false.
0   CustomName Framework                  0x000000011d475c4c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   CustomName Framework                  0x000000011d48e730 logging::LogMessage::~LogMessage() + 224
2   CustomName Framework                  0x000000011d08d166 content::ContentMainDelegate::TerminateForFatalInitializationError() + 54
3   CustomName Framework                  0x000000011d08e9e1 content::ContentMainRunnerImpl::Initialize(content::ContentMainParams const&) + 1137
4   CustomName Framework                  0x000000011e7b5966 service_manager::Main(service_manager::MainParams const&) + 1398
5   CustomName Framework                  0x000000011d08e154 content::ContentMain(content::ContentMainParams const&) + 68
6   CustomName Framework                  0x000000011b468653 ChromeMain + 179
7   CustomName                            0x000000010c772dd4 main + 404
8   libdyld.dylib                       0x00007fff661af015 start + 1
9   ???                                 0x0000000000000001 0x0 + 1

does anyone know the steps of how to create a custom branded installer for mac?

[Nicholas DiPiazza]

Finally found answer - this file needs updated chrome/common/chrome_constants.cc

If you don't update the product name here, you will get that nasty error I mentioned! Ugh.