can't compile on win with ninja

[Jochen Eisinger]

Hey,

I created a new checkout on win7, but now I can't compile anymore:

E:\src\chrome\src>ninja -j60 -C out/Debug chrome

ninja: Entering directory `out/Debug'

[1514/11634] LINK(DLL) icuuc.dll

icuuc.udata.obj : warning LNK4217: locally defined symbol _icudt46_dat imported in function "struct UDataMemory * __cdecl openCommonData(char const *,int,enum UErrorCode *)" (?openCommonData@@YAPAUUDataMemory@@PBDHPAW4UErrorCode@@@Z)

[1969/11634] ACTION gen_asm_offsets_vp...s_obj_d8627db761354f8cf543092d316fe066

FAILED: c:\python_26_amd64\files\python.exe gyp-win-tool action-wrapper environment.x86 gen_asm_offsets_vp9_target_copy_enc_offsets_obj_d8627db761354f8cf543092d316fe066..rsp

../../third_party/libvpx/copy_obj.sh: line 6: $'\r': command not found

[1969/11634] ACTION gen_asm_offsets_vp...s_obj_f94c8eb7659b1c3167f42131aea70157

FAILED: c:\python_26_amd64\files\python.exe gyp-win-tool action-wrapper environment.x86 gen_asm_offsets_vp8_target_copy_enc_offsets_obj_f94c8eb7659b1c3167f42131aea70157..rsp

../../third_party/libvpx/copy_obj.sh: line 6: $'\r': command not found

[1969/11634] RULE Converting libavcodec/pthread.c from C99 to C89.

ninja: build stopped: subcommand failed.

Apparently third_party/libvpx/copy_obj.sh fails. Has anybody encountered the same error? How can I fix this?

thanks

-jochen

[Jochen Eisinger]

found the problem. I needed to run

git config --global core.autocrlf false

-jochen

[Shezan Baig]

Setting core.autocrlf to false globally will probably break other projects.  It makes it really easy for Windows users to add files with CRLF embedded into the repo, which can get annoying for non-Windows users.  This is probably not an issue for chromium since there is a pre-commit sanity check, but most projects don't have such a setup.

A better solution would be to fix this in the libvpx repo itself by adding a ".gitattributes" file with the following line:

*.sh eol=lf

This will make git preserve the LF line-ending when checking out shell scripts into the working directory.  I tried creating a patch using "git cl upload" to add this ".gitattributes", but I get:

Command "git --no-pager config rietveld.server" failed.

Could not find settings file. You must configure your review setup by running "git cl config".

I'm not sure how to configure the rietveld server for libvpx.  Could someone with the right privileges set this up?

Thanks,
-shez-

[Jeremy Roman]

I think libvpx uses Gerrit rather than Rietveld.

http://www.webmproject.org/code/contribute/submitting-patches/

I assume patches need to be contributed through their process.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
 
 
 

[Torne (Richard Coles)]

git cl upload does support gerrit if configured correctly in codereview.settings (I'm not sure what the format for this is offhand).

[Daniel Bratell]

Den 2013-06-19 15:28:25 skrev Shezan Baig <shezb...@gmail.com>:

> Setting core.autocrlf to false globally will probably break other
> projects.

It does.

I have a custom HOME for chromium so that gclient (which does such things)
won't destroy my git installation.

/Daniel