Is kEnableNetBenchmarking (enable-net-benchmarking) flag still being used?

[Helen Li]

Is kEnableNetBenchmarking (enable-net-benchmarking) flag still being used?

The flag is being set on Telemetry bots, but Ned doesn't know about what is used for. I didn't have much luck in tracing the commit history.

Any idea? I filed bug at https://bugs.chromium.org/p/chromium/issues/detail?id=838949. 

If no one uses it, I am planning to remove it.

Thanks,

Helen

This is code:

https://cs.chromium.org/chromium/src/chrome/browser/chrome_content_browser_client.cc?rcl=31e590f90804160b9e90575452006a3ded7e3bcb&l=3217

  if (NetBenchmarking::CheckBenchmarkingEnabled()) {
    Profile* profile =
        Profile::FromBrowserContext(render_process_host->GetBrowserContext());
    net::URLRequestContextGetter* context =
        render_process_host->GetStoragePartition()->GetURLRequestContext();
    registry->AddInterface(base::Bind(&NetBenchmarking::Create, profile,
                                      base::RetainedRef(context)));
  }

[David Benjamin]

Looks like they date back to:

https://codereview.chromium.org/119191

https://bugs.chromium.org/p/chromium/issues/detail?id=6754

It injects some chrome.benchmarking APIs, which are called here:

https://cs.chromium.org/chromium/src/tools/chrome_proxy/webdriver/common.py?q=chrome%5C.benchmarking&sq=package:chromium&l=381&dr=C

https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py?q=chrome%5C.benchmarking&sq=package:chromium&l=312&dr=C

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEkFr04tKmN5wK6F_-mDH43iNHrpTjMGGrSZW2C%3DV_ouKduqtw%40mail.gmail.com.

[Helen Li]

Ah, that clears things up. Thanks, David. I will update the crbug with the info.

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+unsubscribe@chromium.org.