Use ASSERT_TRUE() in a function which has return value

[jun...@chromium.org]

In some test code, I tried using ASSERT_TRUE() in a function which has bool return type. The compiler gives the following error:

error: cannot initialize return object of type 'bool' with an rvalue of type 'void'

Does it mean ASSERT_TRUE() can only be used in functions that return void? Thanks!

[Ken Rockot]

Yes, ASSERT* macros generate code which can return with no value.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/62cda982-bc2e-4665-84da-abbacd04b592%40chromium.org.

[Charles Harrison]

Yes, ASSERT_* methods return from the method but do not return any value.

See: https://github.com/google/googletest/issues/940

--

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+unsubscribe@chromium.org.

[jun...@chromium.org]

Thanks for the answer!

[Adam Rice]

As a general rule, EXPECT_* and ASSERT_* macros should only be used in the body of the test itself. For EXPECT_* this is a stylistic thing: it should be possible to tell at a glance what a test is testing. However, the important difference between ASSERT_* and EXPECT_* is that the ASSERT family of macros abort the test. If they are called inside a function that is not the body of the test, they cannot abort the test, so it's usually wrong.

Unfortunately, many tests in Chromium code violate this rule.

On 22 August 2017 at 08:10, <jun...@chromium.org> wrote:

Thanks for the answer!

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/2d6e8aee-80fd-4866-aa48-890e36c17c1e%40chromium.org.

[Reilly Grant]

I would suggest that EXPECT_* be allowed outside the body of the test in helper functions, mocks, etc. as it is helpful for debugging a test failure to see exactly where an unexpected condition occurred rather than saving some state about the condition and EXPECTing it later in the test body.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHixhFq0wCSz3-kzScj7x3mt1dszNZ-R9-c979uZtLULgBdSxw%40mail.gmail.com.

[Joe Mason]

I tend to use the style that helper functions which do some work and then call EXPECT_* on the results are named "ExpectFoo", so that they're easy to spot in the calling tests.

There are ways to get ASSERT_* in a helper function to abort the test correctly, but you should try not to use them because they add extra complexity.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEmk%3DMZ53tkpH%3DsW4_cY_0hoJZDmZ227V_Vdh%3Dx-fbmnY7pBZQ%40mail.gmail.com.