RFC: Making NOTREACHED() fatal

[Peter Boström]

Hi folks!

We've a plan to make NOTREACHED() statements fatal to both upgrade their severity (DCHECK->CHECK) and eventually be able to migrate to a [[notreached]] version down the line (crbug.com/851128).

tl;dr: NOTREACHED()s are currently non-fatally reported on all Chrome release channels. There's a 0% experiment that makes NOTREACHED() fatal. We're looking to downgrade frequently-hit NOTREACHEDs to DUMP_WILL_BE_NOTREACHED_NORETURN to exclude them from the experiment (would've impacted stability). As we then roll out the kNotReachedIsFatal experiment we'll monitor crash reporting and stability metrics and exclude further call sites as necessary.

Doc is here: https://docs.google.com/document/d/1_pvk4E30YfaPRC5AVFSZsCPoQFDCAwpMamKsEfmGJWY/edit?usp=sharing

Thanks!

Peter

[Peter Boström]

Ugh typo: migrating to a [[noreturn]] version of NOTREACHED down the line.

[Adam Rice]

sgtm

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAGFX3sHBP0d7ZnHQiESC72w2kiOsh9qGe3isJh3_Dqv86huvQQ%40mail.gmail.com.