Changing the SVN "propset svn:eol-style" on the whole repository ?

[Julien Tinnes]

Hey,

as you know, Windows uses \r\n for end of line and others use \n for
new lines (CR+LF vs. LF). This causes quite a bit of issues, including
with the CQ and try bots which can't deal with it properly.

Lately I did a raw (bypassing gcl etc..) "svn propset svn:eol-style",
after checking with sheriffs, for
trunk/src/third_party/jemalloc/chromium/* to untangle a mess [1].

Should we try to do this once and for all for the (.cc|.h) files in
the repository that don't have this property set yet ? Counting only
.cc and .h files, that's over 531 files (list attached). For many of
these, the difference won't be noticeable, since they already use LF
anyways.

For the files where this will make a difference, the only negative
outcome I can think of is that git will see a giant change from me in
them (and I'll presumably get cc-ed on even more bugs as a result ;)

Should we go ahead with this?

Julien

[1] http://src.chromium.org/viewvc/chrome?view=rev&revision=182122

[James Robinson]

On Wed, Feb 13, 2013 at 2:44 PM, Julien Tinnes <j...@chromium.org> wrote:

Hey,

as you know, Windows uses \r\n for end of line and others use \n for
new lines (CR+LF vs. LF). This causes quite a bit of issues, including
with the CQ and try bots which can't deal with it properly.

Lately I did a raw (bypassing gcl etc..) "svn propset svn:eol-style",
after checking with sheriffs, for
trunk/src/third_party/jemalloc/chromium/* to untangle a mess [1].

Should we try to do this once and for all for the (.cc|.h) files in
the repository that don't have this property set yet ? Counting only
.cc and .h files, that's over 531 files (list attached). For many of
these, the difference won't be noticeable, since they already use LF
anyways.

All developers should have autoprops set up as such (http://src.chromium.org/viewvc/chrome/trunk/tools/build/slave/config), so we should have svn:eol-style set to LF pretty much everywhere.

- James 

For the files where this will make a difference, the only negative
outcome I can think of is that git will see a giant change from me in
them (and I'll presumably get cc-ed on even more bugs as a result ;)

Should we go ahead with this?

Julien

[1] http://src.chromium.org/viewvc/chrome?view=rev&revision=182122

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
    http://groups.google.com/a/chromium.org/group/chromium-dev

[Julien Tinnes]

On Wed, Feb 13, 2013 at 3:00 PM, James Robinson <jam...@google.com> wrote:

> All developers should have autoprops set up as such
> (http://src.chromium.org/viewvc/chrome/trunk/tools/build/slave/config), so
> we should have svn:eol-style set to LF pretty much everywhere.

Indeed. But we don't, on 531 files. So should we do this?

Julien

[Peter Kasting]

On Wed, Feb 13, 2013 at 2:58 PM, Justin Schuh <jsc...@chromium.org> wrote:

On Wed, Feb 13, 2013 at 2:44 PM, Julien Tinnes <j...@chromium.org> wrote:

Should we try to do this once and for all for the (.cc|.h) files in
the repository that don't have this property set yet ? Counting only
.cc and .h files, that's over 531 files (list attached). For many of
these, the difference won't be noticeable, since they already use LF
anyways.

I don't know about third_party stuff, but at least in the main repo, all .cc and .h files are supposed to have eol-style=LF.  We're also supposed to have a page on the dev site somewhere (but I couldn't find it) directing people to enable auto-props using a config like the one James linked, so that these and a variety of other file types get the correct properties.

PK

[Julien Tinnes]

Sorry, if I'm not being clear: I know that, and it's not the case, 531
files cc/h files don't have that property set. Should I set it?

I notice now that I forgot to attach the list. Here it is.

Julien

[Tony Chang]

FWIW, people have done changes like this in the past:

http://git.chromium.org/gitweb/?p=chromium%2Fchromium.git&a=search&h=HEAD&st=commit&s=eol-style

On Wed, Feb 13, 2013 at 3:20 PM, Tony Chang <to...@chromium.org> wrote:

It sounds like everyone is saying to go ahead and set svn:eol-style LF on the cc and h files that are missing this property.  I think git won't even notice change since this is only a change to svn properties.

--

[Marc-Antoine Ruel]

Don't bother too much with svn-specific stuff. On the other hand don't feel the need to ask to fix any CRLF file, just do it.

[Tony Chang]

It sounds like everyone is saying to go ahead and set svn:eol-style LF on the cc and h files that are missing this property.  I think git won't even notice change since this is only a change to svn properties.

--

[Justin Schuh]

-nsylvain, because he already abandoned us.

+cmp, the new nsylvain.

On Wed, Feb 13, 2013 at 2:44 PM, Julien Tinnes <j...@chromium.org> wrote:

[Julien Tinnes]

Done in http://src.chromium.org/viewvc/chrome?view=rev&revision=182368

Crossing fingers :)

Julien

[Tom Hudson]

On Wed, Feb 13, 2013 at 11:10 PM, Peter Kasting <pkas...@chromium.org> wrote:

I don't know about third_party stuff, but at least in the main repo, all .cc and .h files are supposed to have eol-style=LF.  We're also supposed to have a page on the dev site somewhere (but I couldn't find it) directing people to enable auto-props using a config like the one James linked, so that these and a variety of other file types get the correct properties.

If you can't find it, it strikes me as a good bet that many new Chromium devs won't.

Tom