Am I the only one who builds with VS 2005?

[Darin Fisher]

I noticed last week that the unit_tests didn't compile for me.  I just figured I had a bad pull.  This week though, I really needed unit_tests to compile, but I found that it was still failing to compile for the same reason.

Long story short, I'm convinced that I need a patch:

http://codereview.chromium.org/5549008/

Does this mean that I'm the only one using VS 2005?  Should we require VS 2008?

(The browser tests have also been broken for a while too:  http://codereview.chromium.org/5516006/)

-Darin

[Ryosuke Niwa]

But we can't use VS 2008 for WebKit.  It seems that we need to support both VS 2005 and VS 2008 at least until WebKit also supports VS 2008.

- Ryosuke

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

--
Ryosuke Niwa

Software Engineer / Chrome WebKit

Google Inc

[Darin Fisher]

It is something screwball with VS 2005 that I've seen before.  Basically, if you have a class like this:

class Foo : public Bar::Delegate {

 public:

  class Delegate {

  };

};

Then, referring to the type Foo::Delegate greatly confuses VS 2005.  It seems to think you are referring to Bar::Delegate!!

-Darin

On Fri, Dec 3, 2010 at 1:43 PM, Pierre-Antoine LaFayette <pie...@alumni.utoronto.ca> wrote:

I'm using VS2005 and had the same issue. Couldn't figure out what the issue was with that CloudPrintURLFetcher. I just ended up disabling that test.

--

Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

--
Pierre.

[Darin Fisher]

But, creating a typedef for Foo::Delegate apparently works.  Go figure?!?

-Darin

[Sanjeev Radhakrishnan]

Yes, I have run into this before (which is why many of the CloudPrint related classes use a typedef for Delegate). I just forgot to use the typedef in the unit-test :(.

[Aaron Boodman]

We ran into the same bug in extensions. FWIW, I build using VS 2005,
but I haven't build on Windows in awhile.

- a