Formatting inconsistency.

[Erik Jensen]

Not sure if this it the right place to report this, but I ran into an odd inconsistency when formatting a particular piece of code:

} else if (std::ranges::all_of(

types,

[](const TypeBase& type) { return *type.begin() == 'a'; }) ||

std::ranges::all_of(types, [](const TypeBase& type) {

return *type.begin() == 'm';

})) {

...

}

Despite both calls to std::range::all_of being the same length and starting on the same column they are formatted very differently, which makes the result harder to read.

[Peter Kasting]

Weird. I'd file a bug in the llvm subcomponent. 

PK

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAN%3DK5G8j8dVSg6fQ%3DUiypj%3D26zgodpTuJrL%2B5AqRjb_e0jVu5g%40mail.gmail.com.

[danakj]

Did this get a bug filed? https://github.com/llvm/llvm-project/labels/clang-format is the best place to file it.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAAHOzFDBvpCy8AZrKDKEb4wtRf6zupU7r%3DG0mnyZxsrbgk7m9Q%40mail.gmail.com.

[Michael J. Kane II]

Sorry for the spam,

GCC 5.1.0: ISO C does not support '__FUNCTION__' predefined identifier #1739

copyleft@Copyleft-PC:~$ gcc --version

gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609

copyleft@Copyleft-PC:~$ find . -type f -exec sed -r 's|__FUNCTION__|__func__|g;s|c89|c99|g' -i '{}' ';'

Thank you for what you do! // Teacher/Father Stuff(@}-,-`-.);

M. Kane II

ad...@copyleftsytems.com

https://copyleft15.wordpress.com

@digital_const // twitter.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHtyhaSawEe6XqWk8-7eXz4%3DdoQERTVvcLQ-SgSLkH0tLcSibA%40mail.gmail.com.

[Peter Kasting]

That isn't related to this thread, nor does chromium officially support GCC, and I don't know what versions and flags the folks who keep GCC working do support. 

PK

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/b09d7582-e013-4e45-89fc-28c9a87c4eb6%40gmail.com.