Sublime Text clang-format fails, bad working directory?

[James Cook]

I'm trying to get clang-format to work in sublime, following the instructions here:

https://chromium.googlesource.com/chromium/src/+/master/docs/linux_sublime_dev.md#Format-Selection-with-Clang_Format-Chromium-only

This worked initially, but now when I hit my keybinding it deletes all the text in my editor buffer. I think the command is failing, so it produces no output, so Sublime puts an empty string in the buffer.

The Sublime error log shows:

b'Problem while looking for clang-format in Chromium source tree:\n  Could not find checkout in any parent of the current path.\n'

I traced this into to depot_tools/gclient_utils.py GetPrimarySolutionPath(), which uses os.getcwd() to look for your checkout to find the buildtools directory. For me, os.getwd() prints /opt/sublime_text, which is obviously not in my checkout.

I tried setting "binary" to the full path to depot_tools/clang-format in my copy of clang-format-sublime.py, but that didn't work (clang_format.py tries to do the lookup anyway, I think).

Does anyone know how to work around this?

James

[Nico Weber]

Does patching in https://codereview.chromium.org/2129993002/ help?

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[James Cook]

I think that CL only affects clang-based code-completion, not clang-format.  I tried it anyway and got the same error. :-(

[Nico Weber]

Hm. I don't use sublime. Does adding "working_dir": "${project_path}" to the key bindings entry work?

[James Cook]

Sadly, that doesn't work either. I'm guessing sublime doesn't support adding working_dir to keybindings, just for build steps.

[James Cook]

I found a workaround, although it makes me nervous:

You can apparently hard-code the buildtools directory using an environment variable, CHROMIUM_BUILDTOOLS_PATH:

https://cs-staging.chromium.org/chromium/tools/depot_tools/gclient_utils.py?sq=package:chromium&dr=C&l=696

The comment says this is "highly unsupported". Anyone know if there's a better way?

[Sunny Sachanandani]

Sorry for reviving this thread but I had this problem without out of the blue without updating ST. It happened because I uninstalled the SublimeLinter(-cpplint) packages and somehow that package was changing the working directory so that clang-format worked.

Any way to fix this I added a cwd=os.path.dirname(self.view.file_name()) to the Popen call in the plugin and that seems to work OK (% error checking).