Doing UI work? Post screenshots on bugs

[Peter Kasting]

If you never make UI changes, you can stop reading.

When doing UI work, it's extremely helpful to your reviewers to post screenshots of what your patch looks like (as opposed to no shots, or just links to mocks somewhere, which may or may not look like what you implemented).

People are getting better at doing this -- thank you! -- but a lot of people send screenshots via email or upload to e.g. Google corporate accounts that aren't accessible outside Google.  This isn't friendly to people who join the review later/work outside Google/etc.

So please post screenshots preemptively, and do so on as attachments on the Chromium bug associated with the work.  This ensures anyone can see the screenshot at any time.

Thanks,

PK

[Peter Kasting]

On Wed, May 22, 2013 at 5:22 PM, Peter Kasting <pkas...@google.com> wrote:

When doing UI work, it's extremely helpful to your reviewers to post screenshots of what your patch looks like (as opposed to no shots, or just links to mocks somewhere, which may or may not look like what you implemented).

David Levin passes me along a good warning note.  Be careful when doing this not to leak information about anything your company might be doing that's non-public.  This doesn't just mean URLs or page contents; even the browser action icons can reveal unreleased stuff.  It's normally best to clip your screenshot down to just the bit that shows your new UI.

PK