Auto-abandoned CLs?!

[Gabriel Charette]

I (and a few others) have been quite surprised to find a bunch of our "stale" CLs have been auto-abandoned this morning. Did I miss an announcement? I like to manage my pending CLs myself and have many old CLs that are still "WIP" as in, I'd like to land them but they break some tests, sometimes I'll link to them in a discussion about why some things aren't the way folks would expect them to be.

Abandoning these means they'll be hard to find for me and I don't see what the benefit is on the ecosystem otherwise.

List of abandoned CLs for you:

https://chromium-review.googlesource.com/q/is:abandoned+owner:me+commentby:sokcevic%2540google.com

[Alexei Svitkine]

+1 to being surprised this happened without any announcement of the plans before hand.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAJTZ7L%2Bk5%2BDUUv%2BMRTHLSfi2QXnDOmctYW5xUjExarcrZUmGqQ%40mail.gmail.com.

[K. Moon]

Maybe this? https://groups.google.com/a/chromium.org/g/infra-dev/c/9nHd7v3j5Mk/m/qaqopMauAAAJ

I believe the large number of old CLs were causing scalability issues for the master->main migration.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAKFU2SDo6MkiOMvaZgc_dzbDQYXdST_Tu%2B3zwdqL2FDRmHTzHw%40mail.gmail.com.

[Sébastien Marchand]

This discussion happened on infra-dev@ , most Chromium developers are not on this list. 

--

Sébastien Marchand | Software Developer | sebma...@google.com 

[Mike Frysinger]

if you still want them, you can simply restore them.  i don't think this operating mode is the norm :).

star any CLs you care about, then bookmark:

https://chromium-review.googlesource.com/q/is:starred

and/or add it as an option under menu:
https://chromium-review.googlesource.com/settings/#Menu

as for negative value, there is: lots of open CLs slows down searches.

-mike

--

[Josip Sokcevic]

Hi all,

First of all, sorry for the trouble. All changes with no updates (e.g. comments, new PS) in 18 months were abandoned as we hit unexpected issues when changing main to default branch of chromium/src. As part of the migration, all changes needed to be moved to main and that caused scalability issues.

Restoring all changes now has drawbacks in addition to the original problem, e.g., Gerrit will show these CLs prominently as recently modified. You can restore individual CLs using Gerrit UI too (see screenshot). If you would like to have all your abandoned changes restored, please let me know either by submitting a bug or email me directly.

Again, I apologize for not communicating with you all in advance and will ensure something similar doesn't happen again in the future.

Best,

Josip

--

Josip Sokcevic

[Gabriel Charette]

On Wed, Apr 7, 2021 at 11:08 AM Mike Frysinger <vap...@chromium.org> wrote:

if you still want them, you can simply restore them.  i don't think this operating mode is the norm :).

star any CLs you care about, then bookmark:

https://chromium-review.googlesource.com/q/is:starred

and/or add it as an option under menu:
https://chromium-review.googlesource.com/settings/#Menu

as for negative value, there is: lots of open CLs slows down searches.

I'm fine if search only indexes CLs < 18 months old and has a button "search all" for desperate times. In practice though I mostly ctrl-F the page with my opened CLs...

[Mike Frysinger]

On Wed, Apr 7, 2021 at 12:05 PM Gabriel Charette <g...@chromium.org> wrote:

On Wed, Apr 7, 2021 at 11:08 AM Mike Frysinger <vap...@chromium.org> wrote:

if you still want them, you can simply restore them.  i don't think this operating mode is the norm :).

star any CLs you care about, then bookmark:

https://chromium-review.googlesource.com/q/is:starred

and/or add it as an option under menu:
https://chromium-review.googlesource.com/settings/#Menu

as for negative value, there is: lots of open CLs slows down searches.

I'm fine if search only indexes CLs < 18 months old and has a button "search all" for desperate times. In practice though I mostly ctrl-F the page with my opened CLs...

i'm not sure we need to do this when (it seems) only a minority of devs want this operating mode.  imo the defaults should align well with the majority of devs.

you are more than welcome to restore any CLs that you still want that were abandoned, then you can keep managing your CLs using your current flow if you prefer.

another way you can manage things more finely than stars: use hashtags.  then you can bookmark a search for it similar to how you would with stars above.

[Mike Frysinger]

Josip: random idea.  could we (ab)use hashtags?  like if i put "chops-disable-auto-abandon" as a hashtag on the CLs i want to keep around.  is this a terrible abuse of hashtags?

-mike

[Josip Sokcevic]

It would make sense if we decide that auto-abandoning is something we want to do continuously. Our Gerrit setup doesn't support auto-abandon and benefits of doing that are limited (from both ops and user perspective) so I don't want to propose that.

Side-note: we won't need to abandon changes on any other repository that still needs to be migrated as they have significantly less open CLs compared to chromium/src.

--

Josip Sokcevic

[Leszek Swirski]

Reviving this old thread, it seems like this happened again -- I came back from the holidays to a bunch of CLs abandonded by Mike.

Is there reasoning for this, or any discussion beyond the (negative) feedback in this thread? Sounds like the original justification (master->main migration) doesn't apply, that this wasn't supposed to happen in subprojects (I'm in V8), and that Josip said he will "ensure something similar doesn't happen again in the future"? Otherwise it kind of sounds like one engineer imposing their personal workflow preference on dozens of other engineers -- I wouldn't expect the gmail team to go into my inbox and archive my older emails for me, so I'm surprised that someone would do this with my backlog of CLs.

- Leszek

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+unsubscribe@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAJTZ7L%2Bk5%2BDUUv%2BMRTHLSfi2QXnDOmctYW5xUjExarcrZUmGqQ%40mail.gmail.com.

--

Josip Sokcevic

[Gabriel Charette]

I also don't see the value here. I have old WIP CLs that are skeletons of what needs to happen to fix something that I've deprioritized upon hitting CQ failures, I still end up pulling them back as reference when someone reaches out and asks why something is a given way "here's the solution, if you can fix the tests, it's all yours :)". Archiving those just makes them harder to find with no cleanliness value to me.