Gerrit sending too much email after review started. Interrupts reviewers unnecessarily.

[Trent Apted]

I feel guilty whenever Gerrit sends out an email on my behalf which is something other than "Dear Reviewer, this is ready for you to look at now." I value every second of time I get from my reviewers and these extra emails feel like I'm interrupting them :/

The following seem very unnecessary:

 - Email on commence dry run / Commit-Queue + 1 Bug

 - Email on editing the CL description Bug Related-Bug

These are only sent once "in review" -- not in "WIP" stages -- but unnecessarily interrupting a reviewer once you have their initial attention is still quite bad IMO.

Anyway, I've starred those bugs. But I also feel like I need to apologise to anyone I've spammed already.

Ideally an email would never be sent out to others on my behalf that didn't have a direct correspondence to me clicking a button that said "Send", "Publish", or "Commit". For example, I'd also really like the 3 emails sent out on initial review-with-comments to be just one email, but I can cope with that.

I'm concerned to a lesser degree about the deluge of emails gerrit sends only to me. I'd rather have some control over it, or have it appear in a separate thread. In general, it's been much harder filtering out important text from Gerrit reviews compared to Rietveld and it's affecting my productivity.

[Colin Blundell]

+1 to all of these points

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAAGrfxd41GyjxsWbrV33G5PjuD6Rif4TEtUW%2BVRhbfE6Xb2mdw%40mail.gmail.com.

[Primiano Tucci]

+1 and FWIW I filed some of those bugs a while ago, so feel free to star them:

https://bugs.chromium.org/p/gerrit/issues/detail?id=6543 Editing the commit message spams everybody with an email

https://bugs.chromium.org/p/gerrit/issues/detail?id=6354 Too much noise in CLs

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAMGE5NF9e4g4nK%2B4%3DQckN2nw5b%3D6-8mfh-7P_gwhqtZD_PCw3g%40mail.gmail.com.

[dan...@chromium.org]

+1. The amount of noise has had me consistently missing things from others that I should look at and it's been frustrating. I've been trying to find workarounds in my workflow and email client, but rietveld didn't have these issues.

[Dirk Pranke]

On Fri, Jul 7, 2017 at 8:58 AM, <dan...@chromium.org> wrote:

On Thu, Jul 6, 2017 at 7:49 PM, Trent Apted <tap...@chromium.org> wrote:

I feel guilty whenever Gerrit sends out an email on my behalf which is something other than "Dear Reviewer, this is ready for you to look at now." I value every second of time I get from my reviewers and these extra emails feel like I'm interrupting them :/

The following seem very unnecessary:

 - Email on commence dry run / Commit-Queue + 1 Bug

 - Email on editing the CL description Bug Related-Bug

These are only sent once "in review" -- not in "WIP" stages -- but unnecessarily interrupting a reviewer once you have their initial attention is still quite bad IMO.

Anyway, I've starred those bugs. But I also feel like I need to apologise to anyone I've spammed already.

Ideally an email would never be sent out to others on my behalf that didn't have a direct correspondence to me clicking a button that said "Send", "Publish", or "Commit". For example, I'd also really like the 3 emails sent out on initial review-with-comments to be just one email, but I can cope with that.

I'm concerned to a lesser degree about the deluge of emails gerrit sends only to me. I'd rather have some control over it, or have it appear in a separate thread. In general, it's been much harder filtering out important text from Gerrit reviews compared to Rietveld and it's affecting my productivity.

+1. The amount of noise has had me consistently missing things from others that I should look at and it's been frustrating. I've been trying to find workarounds in my workflow and email client, but rietveld didn't have these issues.

I agree that there's room for improvement here. Keep starring the bugs (or filing them) and we'll keep working with the Gerrit team to find good solutions.

-- Dirk