Changing the version of Chromium

[kristupas.a...@sbdigital.lt]

Hello,

My goal is to change the version of Chromium to 1.0.0.0, and be able to bump it

whenever I require.

I have found a file 'chrome/VERSION'. It seems to be the root version file

which propagates everywhere - agent header, Win, iOS, Android app versions.

My concern is that because of the number of places this version file is used,

doing such a change would silently break things. For example, the agent header

version should be kept as the original of Chromium so that compatibility is

maintained with the web pages. My guess is that there are other such places

of which I'm not aware of.

The most worrying aspect is that the Chromium codebase might have dependencies

on this version, and that changing it to 1.0.0.0 would disable/break features.

Right now I'm trying to decide between two routes:

A) Change the root 'chrome/VERSION' file. Patch the special cases which require

the Chromium base version, such as agent header. This seems to be a much less

less labour intensive route, as long as all the special cases are taken care

of ahead of time, without having to deal with silent issues that might come up

later;

B) Cherry pick and patch the locations where I want to see my custom version,

such as Android, iOS apps versions, chrome://version, install locations, etc.

It is a much safer route, since the scope of changes would be smaller.

However, it would require much more initial work. Also, if I miss some of the

places, it might be hard to patch them after users have their hands on the

product.

Any tips, suggestions or thoughts are highly appreciated.

[kristupas.a...@sbdigital.lt]

Update:

Seems like setting version to 1.0.0.0 causes compilation errors in policy_constant.cc:GetChromePolicyDetails()

[Torne (Richard Coles)]

You should change the specific places where you want users to see a custom version number - as you've observed there are places in the codebase that depend on the version and changing it *will* break things.

You should think of the version in chrome/VERSION as "the version of Chromium your product is based on", not "the version of your product".

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/01a78c26-5d69-442a-ae37-fbd56ce244b1%40chromium.org.