M137 import crowd_deny.pb.h failure

[Thomas Beverley]

Hi,

I'm having trouble compiling Chromium from the 137.0.7151.6 branch on Ubuntu 22.04. Building 136.0.7103.59 works fine. It looks like an import issue for a proto file:

In file included from ../../chrome/browser/safe_browsing/notification_telemetry/notification_telemetry_service.cc:13:
In file included from ../../chrome/browser/push_messaging/push_messaging_service_impl.h:25:
In file included from ../../chrome/browser/permissions/permission_revocation_request.h:14:
../../chrome/browser/permissions/crowd_deny_preload_data.h:18:10: fatal error: 'chrome/browser/permissions/crowd_deny.pb.h' file not found
   18 | #include "chrome/browser/permissions/crowd_deny.pb.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

I've tried running another glcient sync and making a few changes to the build.gn files to make sure it's touching them, but I'm not 100% sure on the mechanism that turns the proto files into their compiled equivalents. Here are the gn and autoninja commands if there's anything extra I need to pass...

gn gen out/Release --args="is_debug = false enable_nacl = false dcheck_always_on = false symbol_level = 1"

autoninja -C out/Release chrome

Thanks!

[Josh Horwich]

This sounds like https://issues.chromium.org/issues/414506471 which I believe is fixed in M137 branch after 137.0.7151.6 via https://chromium-review.googlesource.com/c/chromium/src/+/6502174 - synching to 137.0.7151.8 or later should pick that change up, as recommended in https://issues.chromium.org/issues/414506471#comment7

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/5f049504-eb92-4298-afdb-523e4181505bn%40chromium.org.

[Thomas Beverley]

It sounds like that could be it. Thanks, I'll give it a try!