Code Review not seeing deleted files with 'git mv'?

[Avi Drissman]

I moved some files with 'git mv' and did a 'git cl upload' for review. The result is:

https://chromiumcodereview.appspot.com/10827282/

The two files added have "A +" so they have their history intact. Nice. But where are the two original files marked "D"?

Avi

[Antoine Labour]

FWIW the raw patch looks correct, with the rename.

Antoine

 

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[Chase Phillips]

I saw this a couple of days ago and let Marc-Antoine know.  From what I can tell, it doesn't result in a loss of functionality, it just appears to lead rietveld to mis-display deletes in the CL.  Please update this thread, though, if you see the commit queue or other tools do the wrong thing as a result.

[Avi Drissman]

Well, all the try jobs completely failed, as they didn't see the new files. (See the jobs that were linked to the CL.)

I didn't trust the tools enough to CQ it. I did a 'git cl dcommit' and was relieved enough that that wasn't broken.

Avi

[Avi Drissman]

Filed as http://code.google.com/p/chromium/issues/detail?id=141966 and http://code.google.com/p/chromium/issues/detail?id=141969 .

Avi

[Wei, James]

I also met this issue before and at last CQ it successfully.

 

 

Best Regards

 

James

[Avi Drissman]

No.

How is the CQ supposed to know that there are files to delete if they're not uploaded? This broke for https://chromiumcodereview.appspot.com/10891044/ committed as r154186.

I now have to manually delete files. This bug will cause a proliferation of dead files that should have been deleted and weren't in the tree.

Avi