6c990e4de35066e99085448676e577fdca16f41c - chromium/src

[dmb...@google.com]

commit 6c990e4de35066e99085448676e577fdca16f41c
Author: David Black <dmb...@google.com>
AuthorDate: Wed Mar 02 00:41:23 2022
Commit: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
CommitDate: Wed Mar 02 00:41:23 2022

Fix focused state of "Advanced" button in OS settings menu.

Per UX feedback, updates focus ring of the "Advanced" button in the OS
settings menu as well as increases focus ring width to be consistent
with focus rings across the Settings app.

Before (light): http://shortn/_PKtb8Fu3ff
After (light): http://shortn/_TlNllCuFqG
Before (dark): http://shortn/_eYgMuA3WBl
After (dark): http://shortn/_NoPrp8jOD2

Bug: 1302115
Change-Id: I683a58e56aadfdabe562e22211bd898134a7d85e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3499083
Reviewed-by: Kyle Horimoto <khor...@chromium.org>
Commit-Queue: David Black <dmb...@google.com>
Cr-Commit-Position: refs/heads/main@{#976485}

diff --git a/chrome/browser/resources/settings/chromeos/os_settings_menu/os_settings_menu.html b/chrome/browser/resources/settings/chromeos/os_settings_menu/os_settings_menu.html
index 94d7099..3e4bd479 100644
--- a/chrome/browser/resources/settings/chromeos/os_settings_menu/os_settings_menu.html
+++ b/chrome/browser/resources/settings/chromeos/os_settings_menu/os_settings_menu.html
@@ -3,7 +3,7 @@
/* The tap target extends slightly above each visible menu item. */
--tap-target-padding: 3px;
/* Width of the keyboard focus border. */
- --focus-border-width: 1px;
+ --focus-border-width: 2px;
box-sizing: border-box;
display: block;
padding-bottom: 2px;
@@ -100,7 +100,8 @@
}

:host-context(.focus-outline-visible) #advancedButton:focus {
- outline: auto 5px -webkit-focus-ring-color;
+ border-radius: 0 20px 20px 0;
+ outline: var(--focus-border-width) solid var(--cros-focus-ring-color);
}

#advancedButton > span {