r137469 - branches/1132/src/chrome/browser

[ste...@chromium.org]

Author: ste...@chromium.org
Date: Wed May 16 11:51:16 2012
New Revision: 137469

Log:
Merge 135655 - Uselessly use the uniformity field trial.

This resolves an off by one error where the default group is never selected and reported.

BUG=126465
TEST=Ensure that the server is receiving Variation IDs for the default groups in the uniformity trials (such as 3300000 and 3300100).


Review URL: http://codereview.chromium.org/10377033

TBR=ste...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10391168

Modified:
branches/1132/src/chrome/browser/chrome_browser_main.cc

Modified: branches/1132/src/chrome/browser/chrome_browser_main.cc
==============================================================================
--- branches/1132/src/chrome/browser/chrome_browser_main.cc (original)
+++ branches/1132/src/chrome/browser/chrome_browser_main.cc Wed May 16 11:51:16 2012
@@ -1081,6 +1081,12 @@
experiments_helper::AssociateGoogleExperimentID(trial_name, group_name,
static_cast<chrome_variations::ID>(trial_base_ids[i] + group_number));
}
+
+ // Now that all groups have been appended, call group() on the trial to
+ // ensure that our trial is registered. This resolves an off-by-one issue
+ // where the default group never gets chosen if we don't "use" the trial.
+ int chosen_group = trial->group();
+ DVLOG(1) << "Chosen Group: " << chosen_group;
}
}