Re: Issue 287338 in chromium: Latest update broke AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)

[chro...@googlecode.com]

Updates:
Summary: Latest update broke AltGr (no ouput or act as a ctrl + alt
keyboard shortcut combo)

Comment #4 on issue 287338 by kenji...@chromium.org: Latest update broke
AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

(No comment was entered for this change.)

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #5 on issue 287338 by kenji...@chromium.org: Latest update broke

AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Issue 286318 has been merged into this issue.

[chro...@googlecode.com]

Comment #6 on issue 287338 by kenji...@chromium.org: Latest update broke

AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Issue 288573 has been merged into this issue.

[chro...@googlecode.com]

Comment #7 on issue 287338 by p...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

This breaks input of Polish characters, probably also applies to other
languages. Please consider restoring the original Pri-1.

[chro...@googlecode.com]

Updates:
Labels: -Pri-2 Pri-1

Comment #8 on issue 287338 by kenji...@chromium.org: Latest update broke

AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Yes, indeed this ought to be P1.

[chro...@googlecode.com]

Updates:
Cc: joshwood...@chromium.org

Comment #10 on issue 287338 by p...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

I think this was a mistake - we probably don't want to ship this
regression, right?

Please note that this breaks input of Polish characters and could possibly
apply to other languages.

[chro...@googlecode.com]

Comment #11 on issue 287338 by mar...@chromium.org: Latest update broke

AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

I agree with Przemysław, this is a seriously bad bug for non English users
and it's bad enough that we're shipping it in M30, it shouldn't be left for
2 milestones.

[chro...@googlecode.com]

Updates:
Status: Started

Comment #12 on issue 287338 by n...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #13 on issue 287338 by n...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Sorry I missed this issue.

[chro...@googlecode.com]

Updates:
Status: WontFix

Comment #14 on issue 287338 by n...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

This regression is probably introduced by http://crrev.com/215376 but let
me mark as Won't Fix.
That change makes AltGr keyboard event compatible with Windows.
In the case of Windows, AltGr key generates Ctrl+Alt key and modifiers.
We follows Windows behavior if there is no standard way, so

I think supporting AltGr key handling on Windows is the straight forward
way.

[chro...@googlecode.com]

Comment #15 on issue 287338 by mar...@chromium.org: Latest update broke

AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

This bug is about ChromeOS regressing, it's not about Windows. Do you mean
it's WAI and the NaCl|extensions authors needs to fix their applications?

[chro...@googlecode.com]

Comment #16 on issue 287338 by n...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Yes I think so.

I changed Chrome OS AltGr behavior to meet Windows.
And SecureShell does not support AltGr on Windows.
Then SecureShell on Chrome OS breaks.

[chro...@googlecode.com]

Comment #17 on issue 287338 by p...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

On Windows I am perfectly able to write in Polish in Docs and I would
really welcome the same on ChromeOS.

It is well possible that the root of the problem lies elsewhere, but this
issue calls for investigation and escalation, otherwise we should probably
start sketching out an official announcement of dropping the support for
the affected languages.

I will unduplicate and reopen Issue 288573.

[chro...@googlecode.com]

Updates:
Status: Started

Comment #18 on issue 287338 by n...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Whoa!? sorry this breakage is also happens on Docs!?
Let me investigate more.

[chro...@googlecode.com]

Comment #19 on issue 287338 by n...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Hmm st orange...
I tried on the Chrome OS with US-international but "á" or "ä"can be typed
with AltGr + a and AltGr + q. This means AltGr works correctly on Google
Docs....

[chro...@googlecode.com]

Comment #20 on issue 287338 by p...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Thanks for looking into that!

Could you have a look at the repro steps in Issue 288573 and see what
happens? Perhaps these two issues are related but not equivalent, I believe
that the Polish input broke in 31, not 30.

[chro...@googlecode.com]

Comment #21 on issue 287338 by ra...@gradziel.com: Latest update broke

AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

The simpliest test case (with any keyboard layout) is to type a AltGr + Z
in any web text area (like this comment textarea or GDocs).
On broken ChromeOS (beta 30) it enables "Spoken feedback", but it should
work only with Ctrl + Alt + Z / Ctrl + AltGr + Z

Another test case scenario: Alt + ?
It shows ChromeOS keyboard shortcuts, but it should work only with Ctrl +
Alt + ?

More ChromeOS shortcuts:
https://support.google.com/chromebook/answer/183101?hl=en

Do you still need more examples that this is broken on ChromeOS?

[chro...@googlecode.com]

Comment #22 on issue 287338 by p...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Oh no, this is broken on M30 as well? This looks really bad to me, we
probably don't want this to hit stable.

[chro...@googlecode.com]

Updates:
Labels: -M-32 M-30 ReleaseBlock-Stable

Comment #23 on issue 287338 by joshwood...@chromium.org: Latest update

broke AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Marking M-30 because, according to @ppi, this "makes it impossible to use
Docs with Polish input and I'd be surprised if this would be the only
language affected."

Our current thinking:
1) Can we revert something that will make this issue go away in M-30? (as
opposed to landing more code)

2) How long has this issue existed?

[chro...@googlecode.com]

Comment #24 on issue 287338 by josa...@chromium.org: Latest update broke

AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

we are really close to Stable, I agree with Josh about reverting or put a
work around with minimum risks of breaking something else

[chro...@googlecode.com]

Comment #25 on issue 287338 by bugdro...@chromium.org: Latest update broke

AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)

http://code.google.com/p/chromium/issues/detail?id=287338#c25

------------------------------------------------------------------------
r224232 | no...@chromium.org | 2013-09-19T23:34:27.933685Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=224232&r2=224231&pathrev=224232
M
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/ui_events_helper.cc?r1=224232&r2=224231&pathrev=224232
D
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/input_method/keyboard_browsertest.cc?r1=224232&r2=224231&pathrev=224232
M
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view_aura.cc?r1=224232&r2=224231&pathrev=224232
D
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/textinput/keyevent_logging.html?r1=224232&r2=224231&pathrev=224232

Do not rewrite AltGr Key as Alt+Ctrl

This is partial revert of http://crrev.com/215376
It turned out that this breaks browser accelerator triggered with Ctrl+Alt
like spoken feedback or opening secure shell.

And also that CL changes AltGr behavior to meet as Windows but some we
application already works on current behaviors. As the result some
application including Google Docs or Secure Shell breaks.

So rewriting to Alt+Ctrl is no longer feasible conversion.

BUG=253365, 288573, 287338
TEST=None

Review URL: https://chromiumcodereview.appspot.com/23890039
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #26 on issue 287338 by kwpolska: Latest update broke AltGr (no

ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

I’m having the exact same issue with Arch Linux, on 31.0.1636.0 (from AUR
packages).

AltGr+z should result in ż. It does not; nothing appears in the
<input>/<textarea> fields on websites. However, I also have the Compose
key active, and some AltGr deadkeys. The compose keys, and AltGr deadkeys,
output proper characters (eg. Compose+,a = ą)

However, the omnibar DOES accept AltGr+z and the like.

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #27 on issue 287338 by n...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Above revert CL should fix this issue.

[chro...@googlecode.com]

Updates:
Labels: Merge-TBD

Comment #28 on issue 287338 by bugdro...@chromium.org: Latest update broke

AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)

http://code.google.com/p/chromium/issues/detail?id=287338#c28

Is there a merge required here?

[chro...@googlecode.com]

Updates:
Status: Started
Labels: -Merge-TBD Merge-Requested

Comment #29 on issue 287338 by n...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Confirmed that revert works correctly.
Requesting for merge.

[chro...@googlecode.com]

Updates:
Cc: kar...@google.com

Comment #30 on issue 287338 by n...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Adding TPM.
Sorry for late fix but this is critical for European users.
Is there any chance to merge?

Thank you.

[chro...@googlecode.com]

Comment #31 on issue 287338 by n...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Issue 211925 has been merged into this issue.

[chro...@googlecode.com]

Comment #32 on issue 287338 by helio.mc...@gmail.com: Latest update broke

AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Have the same problem with a Portuguese keyboard (pt_PT):

- If I run in a tab, almost all AltGR + Keys works fine (except AltGR+0="}"
and AltGR+E="€" and AltGR++ ="¨" and in Java console I dont get any error
like "No definition for keycode:"

- If I run in window mode all AltGR don't work and I dont get any error
like "No definition for keycode:"

[chro...@googlecode.com]

Updates:
Status: Duplicate
Mergedinto: 288573

Comment #33 on issue 287338 by n...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #34 on issue 287338 by n...@chromium.org: Latest update broke AltGr

(no ouput or act as a ctrl + alt keyboard shortcut combo)
http://code.google.com/p/chromium/issues/detail?id=287338

Joining this issue to the Issue 288573 to avoid any confusion.
This issue and Issue 288573 are from the same root cause and critical for
European speakers.

[chro...@googlecode.com]

Updates:
Labels: merge-merged-1599

Comment #36 on issue 287338 by bugdro...@chromium.org: Latest update broke

AltGr (no ouput or act as a ctrl + alt keyboard shortcut combo)

http://code.google.com/p/chromium/issues/detail?id=287338#c36

------------------------------------------------------------------------
r225114 | no...@chromium.org | 2013-09-25T01:01:36.482136Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/1599/src/chrome/chrome_tests.gypi?r1=225114&r2=225113&pathrev=225114
M
http://src.chromium.org/viewvc/chrome/branches/1599/src/content/browser/renderer_host/ui_events_helper.cc?r1=225114&r2=225113&pathrev=225114
D
http://src.chromium.org/viewvc/chrome/branches/1599/src/chrome/browser/chromeos/input_method/keyboard_browsertest.cc?r1=225114&r2=225113&pathrev=225114
M
http://src.chromium.org/viewvc/chrome/branches/1599/src/content/browser/renderer_host/render_widget_host_view_aura.cc?r1=225114&r2=225113&pathrev=225114
D
http://src.chromium.org/viewvc/chrome/branches/1599/src/chrome/test/data/textinput/keyevent_logging.html?r1=225114&r2=225113&pathrev=225114

Merge 224232 "Do not rewrite AltGr Key as Alt+Ctrl"

> Do not rewrite AltGr Key as Alt+Ctrl

> This is partial revert of http://crrev.com/215376
> It turned out that this breaks browser accelerator triggered with
> Ctrl+Alt like spoken feedback or opening secure shell.

> And also that CL changes AltGr behavior to meet as Windows but some we
> application already works on current behaviors. As the result some
> application including Google Docs or Secure Shell breaks.

> So rewriting to Alt+Ctrl is no longer feasible conversion.

> BUG=253365, 288573, 287338
> TEST=None

> Review URL: https://chromiumcodereview.appspot.com/23890039

TBR=no...@chromium.org

Review URL: https://codereview.chromium.org/24488002
------------------------------------------------------------------------