Re: Issue 123716 in chromium: dns prefetching leaks dns queries when using a proxy

75 views
Skip to first unread message

chro...@googlecode.com

unread,
Jan 7, 2013, 3:59:07 PM1/7/13
to chromi...@chromium.org

Comment #12 on issue 123716 by mme...@chromium.org: dns prefetching leaks
dns queries when using a proxy
http://code.google.com/p/chromium/issues/detail?id=123716

We already have that. "Predict network actions to improve page load
performance".

(Most?) other speculative requests, though, are connects, not DNS lookups,
so they generally go through the proxy settings, and so don't include DNS
lookups when not needed due to the proxy. I think it's a bit unfortunate
to have to disable all the other optimizations to avoid just DNS prefetches
in this case, but it may be an uncommon enough use case that that's the
right choice.

chro...@googlecode.com

unread,
Feb 13, 2013, 3:36:29 AM2/13/13
to chromi...@chromium.org
Updates:
Labels: Feature-Privacy

Comment #14 on issue 123716 by va...@chromium.org: dns prefetching leaks dns
(No comment was entered for this change.)

chro...@googlecode.com

unread,
Mar 5, 2013, 7:29:52 PM3/5/13
to chromi...@chromium.org

Comment #15 on issue 123716 by ero...@chromium.org: dns prefetching leaks
See this document on how to configure Chrome to use a SOCKS proxy, and
prevent it from issuing local DNS requests:

https://sites.google.com/a/chromium.org/dev/developers/design-documents/network-stack/socks-proxy

Since there is a lot of user confusion surrounding DNS requests by Chrome,
it might be a good idea to special case blacklisting of DNS when any
profile is using a single SOCKSv5 proxy server with no fallbacks.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

chro...@googlecode.com

unread,
Mar 14, 2013, 3:25:25 AM3/14/13
to chromi...@chromium.org

Comment #17 on issue 123716 by bugdro...@chromium.org: dns prefetching
leaks dns queries when using a proxy
http://code.google.com/p/chromium/issues/detail?id=123716#c17

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=188012

------------------------------------------------------------------------
r188012 | ero...@chromium.org | 2013-03-14T07:23:06.811557Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/net_internals/proxy_view.js?r1=188012&r2=188011&pathrev=188012
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/net_internals/proxy_view.html?r1=188012&r2=188011&pathrev=188012

[net] Add an informational bubble to about:net-internals#proxy when using a
single SOCKS v5 proxy server.

Explains how to use --host-resolver-rules to prevent Chrome from making
local DNS requests outside of the proxy.

BUG=123716


Review URL: https://chromiumcodereview.appspot.com/12549010
------------------------------------------------------------------------

chro...@googlecode.com

unread,
Oct 20, 2014, 7:08:22 PM10/20/14
to chromi...@chromium.org

Comment #22 on issue 123716 by bugdro...@chromium.org: dns prefetching
leaks dns queries when using a proxy
https://code.google.com/p/chromium/issues/detail?id=123716#c22

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/1515a12c29da0477a461204b3e67c8031d68a1be

commit 1515a12c29da0477a461204b3e67c8031d68a1be
Author: bemasc <bem...@chromium.org>
Date: Mon Oct 20 22:30:16 2014

Don't preresolve DNS if a fixed proxy configuration is in place.

This change does not affect the behavior when using a system-configured
proxy or a PAC file.

BUG=123716

Review URL: https://codereview.chromium.org/545633002

Cr-Commit-Position: refs/heads/master@{#300356}

[modify]
https://chromium.googlesource.com/chromium/src.git/+/1515a12c29da0477a461204b3e67c8031d68a1be/chrome/browser/net/predictor.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1515a12c29da0477a461204b3e67c8031d68a1be/chrome/browser/net/predictor.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1515a12c29da0477a461204b3e67c8031d68a1be/chrome/browser/net/predictor_unittest.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1515a12c29da0477a461204b3e67c8031d68a1be/net/proxy/proxy_service.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1515a12c29da0477a461204b3e67c8031d68a1be/net/proxy/proxy_service.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1515a12c29da0477a461204b3e67c8031d68a1be/net/proxy/proxy_service_unittest.cc
Reply all
Reply to author
Forward
0 new messages