Issue 326572 in chromium: Force landscape rotation of full-screen HTML5 video on Android

[chro...@googlecode.com]

Status: Unconfirmed
Owner: ----
Labels: OS-Android Pri-2 Type-Feature Cr-Blink-Video Cr-Design

New issue 326572 by cl...@chromium.org: Force landscape rotation of
full-screen HTML5 video on Android
http://code.google.com/p/chromium/issues/detail?id=326572

Applications like YouTube now do this and it makes a lot of sense to me.
Interested in other thoughts if there are UX reasons not to do this, though.

Steps to reproduce:
Watch full-screen HTML5 video with phone in portrait rotation and rotation
lock on.

Expected result:
Video automatically rotates to landscape regardless of whether rotation
lock is on or not.

Actual result:
Video remains in portrait mode. If rotation lock is on, have to go to
settings, turn it off, return to video, rotate phone, watch video, and then
turn rotation lock back on afterwards.





--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #2 on issue 326572 by xun....@intel.com: Force landscape rotation

of full-screen HTML5 video on Android
http://code.google.com/p/chromium/issues/detail?id=326572

I have an initial patch at https://codereview.chromium.org/147373004/ which
simply rotates to landscape.

phil, do you think there are cases where this is not correct?

[chro...@googlecode.com]

Comment #3 on issue 326572 by phil...@opera.com: Force landscape rotation

of full-screen HTML5 video on Android
http://code.google.com/p/chromium/issues/detail?id=326572

Nice to see this get started! I'll comment in the review itself.

[chro...@googlecode.com]

Comment #6 on issue 326572 by bugdro...@chromium.org: Force landscape

rotation of full-screen HTML5 video on Android

https://code.google.com/p/chromium/issues/detail?id=326572#c6

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/d81a8daf739624ad9cb9b117d39841ad66a14d34

commit d81a8daf739624ad9cb9b117d39841ad66a14d34
Author: qinmin <qin...@chromium.org>
Date: Wed Sep 03 01:48:54 2014

Add UMA to study the effect of defaulting fullscreen video to landscape mode

Added UMAs for:
1) The % of fullscreen video that is opened in portrait mode
2) The % of the video is suited for portrait mode
3) How long does a video play before user rotate the screen to landscape
mode
4) How long video plays after user rotate the screen to landscape mode
5) How long does a video play before user rotate to portrait mode
6) The % of a video that the user switched from portrait to landscape mode

BUG=326572

Review URL: https://codereview.chromium.org/297773004

Cr-Commit-Position: refs/heads/master@{#293045}

[modify]
https://chromium.googlesource.com/chromium/src.git/+/d81a8daf739624ad9cb9b117d39841ad66a14d34/content/browser/android/content_video_view.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/d81a8daf739624ad9cb9b117d39841ad66a14d34/content/browser/android/content_video_view.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/d81a8daf739624ad9cb9b117d39841ad66a14d34/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
[modify]
https://chromium.googlesource.com/chromium/src.git/+/d81a8daf739624ad9cb9b117d39841ad66a14d34/tools/metrics/histograms/histograms.xml

[chro...@googlecode.com]

Updates:
Cc: ti...@chromium.org auri...@chromium.org ted...@chromium.org

Comment #7 on issue 326572 by jdd...@chromium.org: Force landscape rotation

of full-screen HTML5 video on Android
https://code.google.com/p/chromium/issues/detail?id=326572

I'd really love us to reconsider this. Our deviance from Youtube is, in my
opinion, a mistake. While anecdotal, I *still* get complaints from people I
know about our suboptimal fullscreen video orientation behavior.

How does the UMA data look at this point?

[chro...@googlecode.com]

Updates:
Cc: ro...@chromium.org

Comment #9 on issue 326572 by cl...@chromium.org: Force landscape rotation

of full-screen HTML5 video on Android

https://code.google.com/p/chromium/issues/detail?id=326572

Wow, I agree that those are some strong stats.

+rolfe for Clank UX.

[chro...@googlecode.com]

Comment #16 on issue 326572 by bryntho...@gmail.com: Force landscape

rotation of full-screen HTML5 video on Android

https://code.google.com/p/chromium/issues/detail?id=326572

Even if this just starts life as an opt-in feature it would be hugely
appreciated. It's the hassle of disabling rotation lock for every video
that makes it a burden. When rotation lock is off I don't mind it starting
in portrait and then rotating my phone into landscape.

> For example, a lot of users are now using phones on their way to work,
> with one hand carrying a bag and the one hand navigating news on their
> phone.

But do they switch their videos to full screen when viewing it in portrait?
Do people bother going to full screen as much when they just want to
maintain portrait, seeing as they gain relatively little in terms of video
size.

[chro...@googlecode.com]

Comment #22 on issue 326572 by tmc...@chromium.org: Force landscape

rotation of full-screen HTML5 video on Android

https://code.google.com/p/chromium/issues/detail?id=326572

That seems likely. We wouldn't want to introduce a setting for this, it
would be the default and only behavior. Rebecca's Rule (tm) of honoring the
most recent gesture first seems sensible, particularly given the data is
weighted pretty heavily toward landscape.

Pangu, are you supportive of this change?

[chro...@googlecode.com]

Comment #23 on issue 326572 by renganat...@chromium.org: Force landscape

rotation of full-screen HTML5 video on Android
https://code.google.com/p/chromium/issues/detail?id=326572

@tmccoy -- yes as long as

1. users can rotate in between left landscape and right landscape
independent of rotation lock
2. we continue to honor rotation lock when coming out of fullscreen.

I think we should at least get this behavior up and running in
dev/betachannel, where we can get some data on behavior and feedback.

[chro...@googlecode.com]

Comment #28 on issue 326572 by qin...@chromium.org: Force landscape

rotation of full-screen HTML5 video on Android

https://code.google.com/p/chromium/issues/detail?id=326572

And what about webview? have we considered the impact on webview?
Does all the apps build on top of webview happy with screen rotations?

[chro...@googlecode.com]

Comment #29 on issue 326572 by qin...@chromium.org: Force landscape

rotation of full-screen HTML5 video on Android
https://code.google.com/p/chromium/issues/detail?id=326572

BTW, youtube app didn't rotate screen on tablets when entering fullscreen.