Issue 170008 in chromium: Print Preview - The text chrome is displayed as Mirror Image.

[chro...@googlecode.com]

Status: Untriaged
Owner: ----
CC: msrchan...@chromium.org, vivi...@chromium.org
Labels: Type-Bug Pri-2 Area-UI OS-All Feature-PrintPreview Mstone-26

New issue 170008 by msrchan...@chromium.org: Print Preview - The text
chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Chrome Version : <'26.0.1383.0'>
URLs (if applicable) :
https://www.google.com/intl/en/chrome/browser/welcome.html

Other browsers tested: Chrome Related


What steps will reproduce the problem?
1. Launch chrome and proceed to the above mentioned URL.
2. Now Right click on Chrome Icon present in the link.
3. Now Right click anywhere in the window and click "Print".

What is the expected result?
In the print preview the Top Left Corner text "Chrome" should be similar.

What happens instead?
In the print preview the Top Left Corner text "Chrome" is displayed as a
mirror image.

Screenshot Attached.

As Chromium does not support Print preview, able to provide only good and
bad builds of Chrome.
Good Build --> 26.0.1379.1 --> 176036.
Bad Build --> 26.0.1382.0 --> 176602.

Please provide any additional information below. Attach a screenshot if
possible.

Attachments:
Chrome.jpg 220 KB

[chro...@googlecode.com]

Updates:
Labels: -Type-Bug Type-Regression

Comment #1 on issue 170008 by msrchan...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

(No comment was entered for this change.)

[chro...@googlecode.com]

Updates:
Labels: -Pri-2 Pri-1 ReleaseBlock-Stable

Comment #2 on issue 170008 by ligim...@chromium.org: Print Preview - The

[chro...@googlecode.com]

Comment #3 on issue 170008 by the...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

I don't see this locally with 26.0.1384.0 (Developer Build 176794). Do you
see it on the latest canary?

[chro...@googlecode.com]

Comment #4 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

I see. "step 2" is important here.

[chro...@googlecode.com]

Comment #5 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

I tried 26.0.1384.0 on win and mac, reproducible on both.

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #7 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Fixed in Skia by https://codereview.appspot.com/7100058

[chro...@googlecode.com]

Updates:
Cc: lafo...@chromium.org

Comment #8 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Issue 170149 has been merged into this issue.

[chro...@googlecode.com]

Updates:
Cc: r...@chromium.org

Comment #9 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Mike, just letting you know that your patch fixed two issues.

[chro...@googlecode.com]

Updates:
Status: Assigned
Owner: r...@chromium.org

Comment #10 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Actually it's more complicate.
This patch just masked problems with CreateBitmapShader.

Both bugs are introduced by
http://trac.webkit.org/changeset/139445/trunk/Source/WebKit/chromium/skia_webkit.gyp?old=139201&old_path=trunk%2FSource%2FWebKit%2Fchromium%2Fskia_webkit.gyp

This one can be fixed by call tmpSrc.sort();
Not sure if it's right approach, just proves that something wrong with
shades printing to PDF.

[chro...@googlecode.com]

Comment #11 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Actually it's more complicated.
This patch just hides problem with CreateBitmapShader.

Both bugs were introduced by
http://trac.webkit.org/changeset/139445/trunk/Source/WebKit/chromium/skia_webkit.gyp?old=139201&old_path=trunk%2FSource%2FWebKit%2Fchromium%2Fskia_webkit.gyp

This one can be fixed just by tmpSrc.sort();

Not sure if it's right approach, just proves that something wrong with

shaders when device is PDF.

[chro...@googlecode.com]

Comment #13 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

you need PDF plugging, that you can copy from Chrome build, and run
chromium with --enable-print-preview

[chro...@googlecode.com]

Updates:
Owner: ---
Cc: -r...@chromium.org r...@google.com van...@chromium.org
edis...@google.com

Comment #15 on issue 170008 by r...@google.com: Print Preview - The text

chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Can either vandebo or edison investigate?

[chro...@googlecode.com]

Comment #16 on issue 170008 by edis...@google.com: Print Preview - The text

chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

most probable cause is the removal of SK_IGNORE_FAST_SCALEMATRIX_INVERT,
see http://code.google.com/p/skia/source/detail?r=7025

[chro...@googlecode.com]

Updates:
Owner: van...@chromium.org

Comment #17 on issue 170008 by tanya...@google.com: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Steve, can you please take a look what it might be, let me know if I need
to reassign.

Thanks in advance!

[chro...@googlecode.com]

Updates:
Owner: msrchan...@chromium.org

Comment #18 on issue 170008 by van...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

I can't repo this on Linux 26.0.1388.0 or Windows 26.0.1399.0 Do you still
see it?

[chro...@googlecode.com]

Updates:
Owner: ---

Comment #19 on issue 170008 by msrchan...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

@vandebo,

The issue was reproducible in the following builds,
26.0.1382.0
26.0.1383.0
26.0.1384.0
26.0.1384.2
26.0.1385.2

Checked on Windows 7, Mac 10.8.2 and Linux Ubuntu 12.04.
Issue is not present after these builds. Verified in latest Canary, Dev,
Beta and Stable issue is not present.

Please let me know, if any further information required.

[chro...@googlecode.com]

Updates:
Owner: van...@chromium.org

Comment #20 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

As I wrote before, see comments 7 and 11, issues was hidden by
https://codereview.appspot.com/7100058. But it's optimization. Fallback to
Shader is possible.

I'd recommend to revert https://codereview.appspot.com/7100058 locally and
fix shader case.

[chro...@googlecode.com]

Comment #21 on issue 170008 by r...@google.com: Print Preview - The text

chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Steve, if you don't see what the shader-case fix is, you can always
copy/paste the old SkDevice::drawBItmapRect code, and paste it into
SkPDFDevice as a stop-gap...

[chro...@googlecode.com]

Comment #22 on issue 170008 by edis...@google.com: Print Preview - The text

chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

I have the environment set up finally and am able to reproduce the issue.
I am debugging the code to understand the root cause.

[chro...@googlecode.com]

Comment #23 on issue 170008 by edis...@google.com: Print Preview - The text

chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

I can't repro in Version 26.0.1400.0 (179998) (Windows 7 Ent, x64, Debug)
But I can repro the missing images

[chro...@googlecode.com]

Updates:
Labels: -Pri-1 -Area-UI -ReleaseBlock-Beta Pri-2 Area-Internals
Internals-Skia

Comment #24 on issue 170008 by van...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Since this bug isn't happening on ToT, removing the Release block label.
If https://codereview.appspot.com/7100058 was a stop gap and needs to go
back in for M26, go ahead and add the label back.

I think a non-shader implementation of drawBitmapRect will be more
efficient for PDF, so SkPDFDevice should have it's own implementation. But
we should also fix the bitmap shader issue.

Edison, would you like to take on one or both of these bugs? The former
should be pretty straight forward, the latter may be a bit fiddly to figure
out and fix.

[chro...@googlecode.com]

Updates:
Labels: ReleaseBlock-Stable

Comment #25 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

This one is still reproducible.

1. Open Print preview for
http://www.designcourse.com/articles/1/css/41-CSS-Transparent-Images
2. Make sure "Background colors and images" is enabled.
3. See "Result:" section

Result:
Mirrored image.

Not sure if it's worth blocking beta.

Attachments:
Transparent Images in CSS _ Image Transparency 101.pdf 206 KB

[chro...@googlecode.com]

Updates:
Labels: -Pri-2 -Internals-Skia -ReleaseBlock-Stable Pri-1 Internals-
ReleaseBlock-Beta

Comment #26 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

There is another bigger problem with that. Google drive can't render images
in PDFs produced by M26.

View in Google Drive.
M24:
https://docs.google.com/a/google.com/file/d/1iMXseGoslos4KqmIIkfgwkgytv5n51Y0bv9JLhmBejSEVtrzvpg2fGh4_jIN012s73umjrGSzCJ9VCeb/edit?usp=sharing

M26:
https://docs.google.com/a/google.com/file/d/0B4gkTrhOONx-dF9uVW13TEtkWTQ/edit?usp=sharing

Adobe and Mozilla have no problems. Chrome PDF viewer have only "mirror"
issue.
We can fix Chrome PDF viewer, and, probably, Google Drive, but some PDFs
will be sent by cloud print to printers, so we will have a lot of issues
there.

So if copy/paste fix with the old code is possible, it seems worth fixing
even for beta.

[chro...@googlecode.com]

Comment #27 on issue 170008 by g...@google.com: Print Preview - The text

chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Url from #25 (
http://www.designcourse.com/articles/1/css/41-CSS-Transparent-Images),
has other artifacts when viewing in print preview. See attached.

Attachments:
preview_01.png 348 KB

[chro...@googlecode.com]

Comment #28 on issue 170008 by edis...@google.com: Print Preview - The text

chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

in the latest sync point (180xxx s) there is no "background and images
option" while in 176036 I do see the "background and images option"

hm .. I will sync again to latest revision

[chro...@googlecode.com]

Comment #30 on issue 170008 by edis...@google.com: Print Preview - The text

chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

fix comment 28
for http://www.designcourse.com/articles/1/css/41-CSS-Transparent-Images
Version 26.0.1379.1 (176036) no option "background and images option", so
it might have been broken then too
Version 26.0.1410.0 (181688) has option "background and images option" and
I can repro the issue

[chro...@googlecode.com]

Comment #31 on issue 170008 by edis...@google.com: Print Preview - The text

chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

vital...@chromium.org, can you reproduce #25 and #27 in Version
26.0.1379.1 (176036)

thanks!

[chro...@googlecode.com]

Comment #35 on issue 170008 by edis...@google.com: Print Preview - The text

chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

#32 - I inserted web_view_->settings()->setShouldPrintBackgrounds(true); in
Version 26.0.1379.1 (176036) and it has similar drawing see attached pdf.
So these aretefacts are a different issue. that it is going to take some
debugging.



Attachments:
Transparent Images in CSS _ Image Transparency 101.pdf 315 KB

[chro...@googlecode.com]

Comment #36 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Also on my machine I see artifacts only in landscape mode.

[chro...@googlecode.com]

Comment #37 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Also on my machine I see artifacts only in landscape mode, 26.0.1409.1

[chro...@googlecode.com]

Comment #38 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

Also on my machine I see artifacts only in landscape mode, 26.0.1409.1

Gene filed separate issue.

[chro...@googlecode.com]

Comment #39 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

I just built 176036, and I see both #25 and #27 issue.

[chro...@googlecode.com]

Comment #40 on issue 170008 by vitalyb...@chromium.org: Print Preview - The

text chrome is displayed as Mirror Image.
http://code.google.com/p/chromium/issues/detail?id=170008

41-CSS-Transparent-Images was flipped even before 176036, so maybe it's
unrelated issue.