Issue 252438 in chromium: "Are you sure you want to open <#> Tabs" dialog style regression.

[chro...@googlecode.com]

Status: Assigned
Owner: m...@chromium.org
CC: tfar...@chromium.org, s...@chromium.org, stro...@chromium.org,
sgabr...@chromium.org
Labels: Type-Bug-Regression Pri-1 Cr-Internals-Views OS-Windows OS-Chrome
m-29 Needs-Bisect

New issue 252438 by m...@chromium.org: "Are you sure you want to open <#>
Tabs" dialog style regression.
http://code.google.com/p/chromium/issues/detail?id=252438

"Are you sure you want to open <#> Tabs" dialog style regression.
On Win7 (and CrOS?) Chrome 29.0.1543.2 (Official Build 207320) canary
1. Create a bookmark folder with many tabs (20 should work).
2. Right click the folder and click "Open all bookmarks".
Expected: The dialog uses the new style; see attached.
Actual: The dialog uses the Windows message box style; see attached.

This has regressed since I updated the style in http://crrev.com/202057
See ShouldOpenAll() in chrome/browser/ui/bookmarks/bookmark_utils.cc
This might be a wider regression of ShowMessageBox or underlying code:
chrome/browser/ui/views/simple_message_box_views.cc

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #1 on issue 252438 by m...@chromium.org: "Are you sure you want to

open <#> Tabs" dialog style regression.
http://code.google.com/p/chromium/issues/detail?id=252438

(No comment was entered for this change.)

Attachments:
message_box_expected.png 19.4 KB
message_box_actual.png 13.9 KB

[chro...@googlecode.com]

Comment #2 on issue 252438 by tfar...@chromium.org: "Are you sure you want

to open <#> Tabs" dialog style regression.
http://code.google.com/p/chromium/issues/detail?id=252438

29.0.1543.0 (Developer Build 207257)

Attachments:
linux-chromeos-message-box.png 6.4 KB

[chro...@googlecode.com]

Updates:
Labels: -OS-Chrome

Comment #3 on issue 252438 by m...@chromium.org: "Are you sure you want to

open <#> Tabs" dialog style regression.
http://code.google.com/p/chromium/issues/detail?id=252438

Thanks for checking; this is Win-only.

[chro...@googlecode.com]

Updates:
Cc: ranjit...@chromium.org

Comment #4 on issue 252438 by ranjit...@chromium.org: "Are you sure you

want to open <#> Tabs" dialog style regression.
http://code.google.com/p/chromium/issues/detail?id=252438

@msw - As per the revision number http://crrev.com/202057 mentioned in the
bug, tried with Chromium builds 202064 and latest chromium build available
207669. Observed that on windows the traditional windows dialog is
displayed. So I doubt if the changes were actually merged or In. Could you
please confirm on this. (Screen shot attached)

Thanks.

Attachments:
Traditional Dialog.png 42.2 KB