Re: Issue 475665 in chromium: shill: Allow disabling wifi/wpa_supplicant

[chro...@googlecode.com]

Comment #2 on issue 475665 by bugdro...@chromium.org: shill: Allow
disabling wifi/wpa_supplicant
https://code.google.com/p/chromium/issues/detail?id=475665#c2

Project : chromiumos/overlays/chromiumos-overlay
Branch : master
Author : Paul Stewart <ps...@chromium.org>
Committer: ChromeOS Commit Bot <chromeos-...@chromium.org>
Commit : 1eb52866f088545cd9281685dc7a63fa47176347

Code-Review 0 : ChromeOS Commit Bot, Paul Stewart
Code-Review +2: Zeping Qiu
Commit-Queue 0 : ChromeOS Commit Bot, Zeping Qiu
Commit-Queue +1: Paul Stewart
Trybot-Ready 0 : ChromeOS Commit Bot, Paul Stewart, Zeping Qiu
Verified 0 : ChromeOS Commit Bot, Zeping Qiu
Verified +1: Paul Stewart
Commit Queue : Chumped
Change-Id : I75078374bd55b2127e71cbcd058e5d96a935f099
Reviewed-at : https://chromium-review.googlesource.com/265120

shill: Add "wifi" use flag

Allow WiFi support to be optional. For now this ebuild just
removes install targets related to wpa_supplicant but it will
also remove any compiled dependencies with follow-on CLs.

BUG=chromium:475665
TEST=USE=-wifi emerge-$BOARD shill
tar jtvf /build/board/packages/chromeos-base/shill-9999.tbz2 | grep wpa
Ensure there are no files listed. Without the "-wifi" the following
should be listed:

./usr/bin/wpa_debug
./usr/lib64/shill/shims/wpa_supplicant.conf

chromeos-base/shill/shill-9999.ebuild

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Updates:
Status: Started

Comment #3 on issue 475665 by z...@chromium.org: shill: Allow disabling
wifi/wpa_supplicant
https://code.google.com/p/chromium/issues/detail?id=475665

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #4 on issue 475665 by bugdro...@chromium.org: shill: Allow
disabling wifi/wpa_supplicant
https://code.google.com/p/chromium/issues/detail?id=475665#c4

Project : chromiumos/overlays/chromiumos-overlay
Branch : master
Author : Peter Qiu <zq...@chromium.org>

Committer: ChromeOS Commit Bot <chromeos-...@chromium.org>

Commit : dfbb61f68157573cbfc627304a4660a45c29d069

Code-Review 0 : ChromeOS Commit Bot, Zeping Qiu
Code-Review +2: Paul Stewart
Commit-Queue 0 : ChromeOS Commit Bot, Paul Stewart
Commit-Queue +1: Zeping Qiu

Trybot-Ready 0 : ChromeOS Commit Bot, Paul Stewart, Zeping Qiu

Verified 0 : ChromeOS Commit Bot, Paul Stewart
Verified +1: Zeping Qiu
Commit Queue : Chumped
Change-Id : I91c7844cf1edba2b0904f2c3a628e84330c8927f
Reviewed-at : https://chromium-review.googlesource.com/265614

shill: Add "wired_8021x" use flag

This allows wired 802.1x support to be optional. wpa_supplicant related
targets will not be installed when both wired 802.1x and wifi support are
disabled. Compilation dependencies will also be removed with follow-on CLs.

BUG=chromium:475665
TEST=USE="-wifi -wired_8021x" emerge-$BOARD shill

tar jtvf /build/board/packages/chromeos-base/shill-9999.tbz2 | grep wpa

Ensure there are no files listed. Without the "-wired_8021x"
or "-wifi"
or both, the following should be listed:

./usr/bin/wpa_debug
./usr/lib64/shill/shims/wpa_supplicant.conf

chromeos-base/shill/shill-9999.ebuild

[chro...@googlecode.com]

Comment #5 on issue 475665 by bugdro...@chromium.org: shill: Allow
disabling wifi/wpa_supplicant
https://code.google.com/p/chromium/issues/detail?id=475665#c5

Project : chromiumos/overlays/portage-stable

Branch : master
Author : Peter Qiu <zq...@chromium.org>
Committer: ChromeOS Commit Bot <chromeos-...@chromium.org>

Commit : 910ce90f8d444e5a0094b869af7927cd291aa4b2

Code-Review 0 : ChromeOS Commit Bot, Mike Frysinger, Paul Stewart
Code-Review +2: Zeping Qiu
Commit-Queue 0 : ChromeOS Commit Bot, Mike Frysinger, Paul Stewart
Commit-Queue +1: Zeping Qiu
Trybot-Ready 0 : ChromeOS Commit Bot, Mike Frysinger, Paul Stewart, Zeping
Qiu
Verified 0 : ChromeOS Commit Bot, Mike Frysinger, Paul Stewart

Verified +1: Zeping Qiu
Commit Queue : Chumped

Change-Id : I0fc16061cba38ef95c886c42766cd6c9f66423d3
Reviewed-at : https://chromium-review.googlesource.com/266057

mips: remove "wifi" use mask

It conflicts with the newly added "wifi" USE flag in shill.

BUG=chromium:475665
TEST=USE="peerd wifi_bootstrapping" ./build_packages
--board=mipsel-o32-generic

profiles/arch/mips/use.mask

[chro...@googlecode.com]

Comment #6 on issue 475665 by bugdro...@chromium.org: shill: Allow
disabling wifi/wpa_supplicant
https://code.google.com/p/chromium/issues/detail?id=475665#c6

Project : chromiumos/platform2

Branch : master
Author : Peter Qiu <zq...@chromium.org>
Committer: ChromeOS Commit Bot <chromeos-...@chromium.org>

Commit : 65d917a0fbad09e2f51b5928adf6d10a3ad8bc47

Code-Review 0 : Aviv Keshet, ChromeOS Commit Bot, ChromeOS bot, Zeping Qiu
Code-Review +2: Paul Stewart
Commit-Queue 0 : Aviv Keshet, ChromeOS Commit Bot, ChromeOS bot, Paul

Stewart
Commit-Queue +1: Zeping Qiu

Verified 0 : Aviv Keshet, ChromeOS Commit Bot, ChromeOS bot, Paul

Stewart
Verified +1: Zeping Qiu
Commit Queue : Chumped

Change-Id : I6abaa150657f6ca0f6d5c37229fde9a2c0bb36aa
Reviewed-at : https://chromium-review.googlesource.com/265774

shill: compiler option support for wifi and wired 802.1x

This allows shill to be compiled without wifi and wired 802.1x
independently.
The supplicant related code will not be compiled when both wifi and wired
802.1x compiler option are disabled.

BUG=chromium:475665
TEST=USE="asan clang -wifi" FEATURES=test emerge-$BOARD shill
USE="asan clang -wired_8021x" FEATURES=test emerge-$BOARD shill
USE="asan clang -wifi -wired_8021x" FEATURES=test emerge-$BOARD shill
USE="asan clang" FEATURES=test emerge-$BOARD shill
Default shill (including both wifi and wired 802.1x):
Passes wifi_matfunc test suite
shill without wifi
No wifi connectivity
Have ethernet connectivity
Passes network_8021xWiredAuthentication test
shill without wired 802.1x
Have wifi and ethernet connectivity
Fail network_8021xWiredAuthentication test
shill without both wifi and wired 802.1x
No wifi connectivity
Have ethernet connectivity
Fail network_8021xWiredAuthentication test
CQ-DEPEND=CL:265614

common-mk/common.gypi
shill/default_profile.cc
shill/default_profile.h
shill/default_profile_unittest.cc
shill/device_info.cc
shill/device_info.h
shill/device_info_unittest.cc
shill/ethernet/ethernet.cc
shill/ethernet/ethernet.h
shill/ethernet/ethernet_unittest.cc
shill/manager.cc
shill/manager.h
shill/manager_dbus_adaptor.cc
shill/manager_unittest.cc
shill/metrics.cc
shill/metrics.h
shill/metrics_unittest.cc
shill/mock_manager.h
shill/mock_metrics.h
shill/mock_proxy_factory.h
shill/mock_service.h
shill/profile.cc
shill/profile.h
shill/profile_dbus_property_exporter.cc
shill/profile_dbus_property_exporter.h
shill/profile_dbus_property_exporter_unittest.cc
shill/proxy_factory.cc
shill/proxy_factory.h
shill/service.cc
shill/service.h
shill/service_unittest.cc
shill/shill.gyp
shill/shill.gypi
shill/shill_daemon.cc
shill/shill_daemon.h
shill/shill_unittest.cc

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #7 on issue 475665 by z...@chromium.org: shill: Allow disabling
wifi/wpa_supplicant

https://code.google.com/p/chromium/issues/detail?id=475665

(No comment was entered for this change.)

[chro...@googlecode.com]

Updates:
Status: Verified

Comment #8 on issue 475665 by z...@chromium.org: shill: Allow disabling