Issue 444896 in chromium: Enable ASAN coverage across tools other than ASAN in Chromium

chro...@googlecode.com

unread,

Dec 23, 2014, 2:10:20 PM12/23/14

to chromi...@chromium.org

Status: Assigned
Owner: gli...@chromium.org
CC: k...@chromium.org
Labels: Type-Bug Pri-2 OS-All

New issue 444896 by infe...@chromium.org: Enable ASAN coverage across tools
other than ASAN in Chromium
https://code.google.com/p/chromium/issues/detail?id=444896

With clang r224464+, coverage is available with MSAN, LSAN. I think in the
near future, it should come with TSAN, UBSAN, too. So, lets add support for
that

What are our options ?
1. Enable asan_coverage=1 in sanitizer_options to enable these by default.
We have to be careful that it does not break on Windows, Mac.
2. Add asan_coverage=1 in lkgr bot configuration. So much painful and poke
troopers on bot restarts, etc. But 0 risk, since it touches a particular
platform configuration.

Any other ideas ?

Also asan_coverage might not a good name (better name might be
sanitizer_coverage). But if we decide to change that, make sure to work
with Clank QA on updating all of their bots (since we just enabled stuff on
kitkat, L bots). I can live with asan_coverage gyp flag name.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

chro...@googlecode.com

unread,

Dec 23, 2014, 5:57:55 PM12/23/14

to chromi...@chromium.org

Comment #2 on issue 444896 by k...@chromium.org: Enable ASAN coverage across

tools other than ASAN in Chromium
https://code.google.com/p/chromium/issues/detail?id=444896

As for the flag, can we make a flag sanitizer_coverage=N and
treat asan_coverage=N as a deprecated alias of the new flag?

I think we can simply make sanitizer_coverage=1 default on all platforms
For those platforms where the run-time support is not ready, we'll simply
not
enable coverage at run-time.

chro...@googlecode.com

unread,

Dec 23, 2014, 6:03:12 PM12/23/14

to chromi...@chromium.org

Comment #3 on issue 444896 by infe...@chromium.org: Enable ASAN coverage

across tools other than ASAN in Chromium
https://code.google.com/p/chromium/issues/detail?id=444896

Yes sanitizer_coverage=1 default on all platform will be awesome (and I
hope windows, mac builds dont crash on startup due to an unsupported flag).

chro...@googlecode.com

unread,

Jan 2, 2015, 1:20:21 PM1/2/15

to chromi...@chromium.org

Updates:
Labels: -Pri-2 Pri-1

Comment #4 on issue 444896 by infe...@chromium.org: Enable ASAN coverage

across tools other than ASAN in Chromium
https://code.google.com/p/chromium/issues/detail?id=444896

This is Pri-1 for this quarter (as per our sanitizer TODO doc).

chro...@googlecode.com

unread,

Jan 15, 2015, 5:43:44 PM1/15/15

to chromi...@chromium.org

Comment #5 on issue 444896 by infe...@chromium.org: Enable ASAN coverage

across tools other than ASAN in Chromium
https://code.google.com/p/chromium/issues/detail?id=444896

Code coverage on UBSAN works (compile a little slow, not much), needs
https://codereview.chromium.org/837633008/.

chro...@googlecode.com

unread,

Jan 15, 2015, 6:20:05 PM1/15/15

to chromi...@chromium.org

Updates:
Cc: earth...@chromium.org

Comment #6 on issue 444896 by infe...@chromium.org: Enable ASAN coverage

across tools other than ASAN in Chromium
https://code.google.com/p/chromium/issues/detail?id=444896

Couldn't test MSAN becoz of
https://code.google.com/p/chromium/issues/detail?id=449183.

chro...@googlecode.com

unread,

Jan 15, 2015, 10:44:26 PM1/15/15

to chromi...@chromium.org

Comment #9 on issue 444896 by bugdro...@chromium.org: Enable ASAN coverage

across tools other than ASAN in Chromium

https://code.google.com/p/chromium/issues/detail?id=444896#c9

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/bf097790c4535829966f4ad2b2624f48cfd0ef41

commit bf097790c4535829966f4ad2b2624f48cfd0ef41
Author: inferno <inf...@chromium.org>
Date: Fri Jan 16 03:32:50 2015

Hook UBSAN, MSAN to exit handler(s) to give time for coverage data to be
generated.

For context, see https://code.google.com/p/chromium/issues/detail?id=430160

BUG=444896

Review URL: https://codereview.chromium.org/837633008

Cr-Commit-Position: refs/heads/master@{#311832}

[modify]
http://crrev.com/bf097790c4535829966f4ad2b2624f48cfd0ef41/content/browser/child_process_launcher.cc
[modify]
http://crrev.com/bf097790c4535829966f4ad2b2624f48cfd0ef41/content/child/child_thread.cc

chro...@googlecode.com

unread,

Jan 16, 2015, 12:31:19 PM1/16/15

to chromi...@chromium.org

Comment #10 on issue 444896 by infe...@chromium.org: Enable ASAN coverage

across tools other than ASAN in Chromium
https://code.google.com/p/chromium/issues/detail?id=444896

Alex, so the pending work is to change ADDRESS_SANITIZER defines in
https://codereview.chromium.org/280303002 so something common that other
tools MSAN, LSAN, UBSAN can use. Once that is done, then I can test MSAN,
UBSAN working with coverage. After that, we can just enable it by default
or just enable edge-coverage for chromium_builder_asan target.

chro...@googlecode.com

unread,

Jan 17, 2015, 11:12:26 PM1/17/15

to chromi...@chromium.org

Comment #12 on issue 444896 by infe...@chromium.org: Enable ASAN coverage

across tools other than ASAN in Chromium
https://code.google.com/p/chromium/issues/detail?id=444896

ok MSAN fails to write coverage files. i think c#10+c#11 work should fix
it. I would let Alex to add SANITIZER_COVERAGE, i dont know which ifdefs in
https://codereview.chromium.org/280303002 are coverage specific and which
ones are tools specific for enabling stuff in sandbox.

==7== SanitizerCoverage: failed to open /tmp/ct/libpdf.so.7.sancov for
writing
==7== SanitizerCoverage: failed to open /tmp/ct/libc++.so.7.sancov for
writing
==7== SanitizerCoverage: failed to open /tmp/ct/libfreetype.so.6.7.sancov
for writing
==7== SanitizerCoverage: failed to open /tmp/ct/chrome.7.sancov for writing
[32292:32292:0117/200758:ERROR:zygote_host_impl_linux.cc(519)] Failed to
send GetTerminationStatus message to zygote