Re: Issue 559398 in chromium: xorg-server: build with clang failed to start chrome

1 view
Skip to first unread message

chro...@googlecode.com

unread,
Nov 20, 2015, 7:33:20 PM11/20/15
to chromi...@chromium.org

Comment #3 on issue 559398 by vap...@chromium.org: xorg-server: build with
clang failed to start chrome
https://code.google.com/p/chromium/issues/detail?id=559398

is there anything preventing us from converting the generics ? i.e.
{x86,arm,amd64,...}-generic ?

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

chro...@googlecode.com

unread,
Nov 20, 2015, 7:45:19 PM11/20/15
to chromi...@chromium.org

Comment #4 on issue 559398 by mar...@chromium.org: xorg-server: build with
The reason the generics still build X11 is that :
- We wanted to keep an X11 version around just in case we need to
test/debug something
- We consistently name freon boards with -freon, not -x11, so the freon
generics are x86-generic-freon and friends (we can't make an -x11 one)

chro...@googlecode.com

unread,
Nov 20, 2015, 7:51:24 PM11/20/15
to chromi...@chromium.org

Comment #5 on issue 559398 by vap...@chromium.org: xorg-server: build with
we did xxx-freon everywhere, but then we merged xxx-freon into xxx. i'm
not sure why we can't do the same with the generics and if we want to keep
X alive, create new xxx-x11 boards for the generics.

Yunlian: you seem to have your answer though ... you'll need to figure out
why clang is breaking X, or disable it for X. either way, X isn't going
away in the near future.

chro...@googlecode.com

unread,
Dec 2, 2015, 2:31:06 AM12/2/15
to chromi...@chromium.org

Comment #6 on issue 559398 by bugd...@chromium.org: xorg-server: build
with clang failed to start chrome
https://code.google.com/p/chromium/issues/detail?id=559398#c6

The following revision refers to this bug:

https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d7d3111adffe0403c236b7502e8f124ab787c8e3

commit d7d3111adffe0403c236b7502e8f124ab787c8e3
Author: Yunlian Jiang <yun...@google.com>
Date: Mon Nov 23 18:15:04 2015

xorg-server: force to use gcc to build it.

xorg-server has segmentation fault when built with clang. Currently
only generic boards use X, so use gcc to build it for now.

BUG=chromium:559398
TEST=cbuildbot amd64-generic-llvm

Change-Id: I3ba8b5e899c26da8d299cf9e75160c6053f28feb
Reviewed-on: https://chromium-review.googlesource.com/314020
Commit-Ready: Yunlian Jiang <yun...@chromium.org>
Tested-by: Yunlian Jiang <yun...@chromium.org>
Reviewed-by: Mike Frysinger <vap...@chromium.org>

[add]
http://crrev.com/d7d3111adffe0403c236b7502e8f124ab787c8e3/chromeos/config/env/x11-base/xorg-server
Reply all
Reply to author
Forward
0 new messages