Re: Issue 317859 in chromium: "Use system titles and borders" is gone in Linux/Aura build

[chro...@googlecode.com]

Comment #4 on issue 317859 by rponn...@chromium.org: "Use system titles and
borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Issue 319443 has been merged into this issue.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #5 on issue 317859 by OhMrBigs...@gmail.com: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Editing the JSON preferences file to try and force that option to change
does not work as well.

1. Edit "~/.config/google-chrome/Default/Preferences"
2. Around line ~35:
2.1. "custom_chrome_frame" : true|false
2.2. Neither true nor false change the behavior

[chro...@googlecode.com]

Comment #7 on issue 317859 by saiarcot...@gmail.com: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

This is also causing the title to be displayed twice on Ubuntu 13.10, and
causing two sets of window navigation buttons: one on the global menu bar
that is on the left side (Unity's standard buttons) and one on the right
side on the Chromium tab strip (Chromium's own buttons).

[chro...@googlecode.com]

Comment #8 on issue 317859 by gaspa...@gmail.com: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Seems that 'Version 33.0.1711.3 dev' brought that option back. I use window
maker and was terribly annoyed by chrome's own titlebar and borders and now
it seems to be okay :)

[chro...@googlecode.com]

Comment #9 on issue 317859 by pdknsk: "Use system titles and borders" is

gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

That's because 33.0.1711.3 doesn't use Aura.

[chro...@googlecode.com]

Updates:
Status: Available
Cc: e...@chromium.org mgi...@chromium.org

Comment #10 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

I miss this too, but I doubt it will be a high priority for M33.

The current state of Linux Aura appears to be that the system is incapable
of producing a native window (e.g., for Chrome Apps even if you use
--apps-use-native-frame you get a blue non-native border). I may be wrong
about this, but that's the feeling I get from a cursory look at the code.
If I'm right, then I doubt we can easily support "Use system titles and
borders" on Linux once Aura comes in.

Hopefully we can work towards it in the longer term (I may need a similar
feature for apps). +erg and myself so we can keep this on the radar.

[chro...@googlecode.com]

Comment #11 on issue 317859 by van...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

I appreciate that it may be hard to fix and that it may not be a high
priority, but please keep in mind that probably most of the people that
flipped the "Use system titles and borders" did it because Chrome's titles
and borders lose some piece of functionality for them and is not simply an
aesthetic choice. Would it be hard to bring back the option and end up with
a double title bars/borders - Chrome's inside the systems - until there's
time for a full solution? For me, that would be preferable to living
without the option at all.

[chro...@googlecode.com]

Comment #14 on issue 317859 by e...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Issue 317793 has been merged into this issue.

[chro...@googlecode.com]

Comment #16 on issue 317859 by van...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Everyone has their own pet feature provided but their WM of choice. My
particular one is that I configure kwin to shade (display just the title
bar) on title bar double click. It also unrolls (displays the entire
window) on hover until the window loses focus. I doubt you want to
implement that in Aura though.

[chro...@googlecode.com]

Updates:
Status: Assigned
Owner: mgi...@chromium.org
Cc: -mgi...@chromium.org

Comment #17 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Taking this bug per discussion with erg.

[chro...@googlecode.com]

Comment #18 on issue 317859 by t.ma...@gmail.com: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Let me add my favourite features to the list too. Of course, most of these
are not reasonable candidates for adding to Aura.

1. Middle-click on Maximize button to maximize vertically. (I.e. don't
change window width, but set its height to the maximum.)
2. What vandebo said in #16: double-click on title bar to shade windows.
3. I have an "Always on Top" button, which keeps the window on top of
everything else.

[chro...@googlecode.com]

Comment #23 on issue 317859 by cr...@craigfowler.me.uk: "Use system titles

and borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

(sorry, Wall of Text™ incoming)

Sure - I can list some of the features that I use on a daily-or-near-daily
basis - but a lot of these are non-default system configurations. In order
to properly implement them and match my system's behaviour then Chrome
would have to go and read the KWin configuration. Then, what about the
people using Gnome's window manager, and XFCE and [the plethora of other
GNU/Linux window managers].

If you wanted to properly integrate these features into Chrome/Aura I
suspect you would end up having to write yourselves a full-featured
standalone window management system and first unify the Linux community
into using it over their current choices. It is a simple fact of the
GNU/Linux world that different users will be running different window
managers. These will have a massive variety of configurable behaviours
between them. In my opinion, "desktop apps have no business messing with
that" - I begrudge STEAM for doing it and I only tolerate it because I
don't use it anywhere near as much as my web browser.

For the record though, here are some features that I remember not working:

* Right-click on the Aura titlebar is hijacked and shows a Chrome menu
instead of showing a default right-click menu configured in KWin. That
menu allows me to move the window to another desktop, configure advanced
behaviours such as always-on-top and always-on-bottom, as well as enter
KWin's advanced window management rules dialog.

* Because Aura uses its own minimise/maximise/close buttons, it skips over
configured behaviour for min/max buttons that I have in KWin: Right-click
maximise to maximise horizontally only (leave window height the same),
middle-click maximise to maximise vertically only (leave window width the
same).

* Within KWin's config I have added a new button to every window: Always on
top (this is a toggle). Aura skips this.

* All of my "application" windows (EG: gmail in app/single window mode) -
when in "system UI" mode - its taskbar pager icon is the website's
favicon. I noticed when using Aura that the icon is just the default
Chrome app icon and not the website's favicon. This makes it a little more
difficult for me to identity wanted windows. This is compounded by another
configuration I routinely use in KDE - in which "windows from desktops
other than the current one" are collapsed to just their icon in my taskbar
pager. It's easy to pick a gmail icon out from two other chrome icons but
if they're all chrome icons then I need to start mouse-over'ing them to
find out which is the window I wanted.

* I also noticed that several of the Aura UI widgets (not titlebar/borders)
misbehaved (or behaved differently to the rest of my platform's UI) too:
* * For example, usually I can click-and-hold on a dropdown list (as would
be rendered by an HTML <select> element, without the multiple attribute).
The click & hold opens the list. Whilst still holding I can move the mouse
cursor the item I want and release. This closes the dropdown and selects
the desired item. Whilst it might not be the most common user behaviour, I
use this a lot and am used to it. I noticed that with Aura that doesn't
work as-expected though, it needs two distinct clicks to select an item.
* * Dropdown controls, rendered from a <select> element, could be cropped
by the browser window. To reproduce - open a <select> that has a
moderate-to-long list of items, whilst it is near the bottom of the browser
window. It opens 'downwards' and can be cut off by the bottom of the
browser window. A GTK widget would instead either open 'upwards' or it
would continue to render outside of the browser window area.

[chro...@googlecode.com]

Comment #24 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Hey Craig,

Yeah, as you suggest, we won't be implementing all of these non-default
behaviours. I was really just looking for a justification to go ahead and
implement system title bars.

> If you wanted to properly integrate these features into Chrome/Aura I
> suspect you
> would end up having to write yourselves a full-featured standalone window
> management
> system and first unify the Linux community into using it over their
> current choices.
> It is a simple fact of the GNU/Linux world that different users will be
> running
> different window managers. These will have a massive variety of
> configurable
> behaviours between them. In my opinion, "desktop apps have no business
> messing with
> that" - I begrudge STEAM for doing it and I only tolerate it because I
> don't use it
> anywhere near as much as my web browser.

Yeah, I agree with this. I think Chrome is coming from a Windows-oriented
background where it is relatively easy to replicate the built-in
functionality and then add more value. On Linux, that's kind of a losing
proposition since there is so much built-in functionality in the window
manager, and so many different window managers.

> All of my "application" windows (EG: gmail in app/single window mode) -
> when in
> "system UI" mode - its taskbar pager icon is the website's favicon. I
> noticed when
> using Aura that the icon is just the default Chrome app icon and not the
> website's
> favicon. This makes it a little more difficult for me to identity wanted
> windows.
> This is compounded by another configuration I routinely use in KDE - in
> which
> "windows from desktops other than the current one" are collapsed to just
> their icon
> in my taskbar pager. It's easy to pick a gmail icon out from two other
> chrome icons
> but if they're all chrome icons then I need to start mouse-over'ing them
> to find out
> which is the window I wanted.

This one interests me. I've spent a lot of time tracking down app icon and
dock grouping bugs on Linux. I'm not seeing this behaviour on my system
(Unity). Would you be able to file a new bug report with details and
screenshots? Specifically, does it affect V1 AND V2 apps, or just V1?
(Gmail is a V1 app; for V2 apps see
https://chrome.google.com/webstore/category/collection/for_your_desktop;
e.g., Google Keep). Please paste a link to that bug here if/when you do it
so I can find it.

> For example, usually I can click-and-hold on a dropdown list (as would be
> rendered
> by an HTML <select> element, without the multiple attribute). The click
> & hold opens
> the list. Whilst still holding I can move the mouse cursor the item I
> want and release.
> This closes the dropdown and selects the desired item. Whilst it might
> not be the most
> common user behaviour, I use this a lot and am used to it. I noticed
> that with Aura that
> doesn't work as-expected though, it needs two distinct clicks to select
> an item.

Thanks for this info. I was able to reproduce it. I've filed a new bug
report: Issue 324364.

> Dropdown controls, rendered from a <select> element, could be cropped by
> the browser
> window. To reproduce - open a <select> that has a moderate-to-long list
> of items, whilst
> it is near the bottom of the browser window. It opens 'downwards' and
> can be cut off by
> the bottom of the browser window. A GTK widget would instead either
> open 'upwards' or it
> would continue to render outside of the browser window area.

I can't reproduce this on Aura 33 (mine is behaving correctly in that it
extends beyond the browser window area without being clipped, and if it
would hit the bottom of the screen, it opens upwards instead). It's
possible it has been fixed since your version of Chrome.

[chro...@googlecode.com]

Comment #25 on issue 317859 by breathej...@gmail.com: "Use system titles

and borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Chrome theme is ugly. Please make the chrome to permit to use the default
windows borders and theme so that the chrome borders are going to change
when my windows theme is changed.

[chro...@googlecode.com]

Updates:
Status: Started

Comment #26 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Good news: This is actually pretty easy :)
WIP CL (not yet ready for review): https://codereview.chromium.org/111723012

[chro...@googlecode.com]

Updates:
Blockedon: chromium:334943

Comment #27 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #28 on issue 317859 by bugdro...@chromium.org: "Use system titles

and borders" is gone in Linux/Aura build

http://code.google.com/p/chromium/issues/detail?id=317859#c28

------------------------------------------------------------------------
r245433 | mgi...@chromium.org | 2014-01-17T06:17:30.186207Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=245433&r2=245432&pathrev=245433
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_frame.cc?r1=245433&r2=245432&pathrev=245433
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc?r1=245433&r2=245432&pathrev=245433
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/widget.h?r1=245433&r2=245432&pathrev=245433
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h?r1=245433&r2=245432&pathrev=245433
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc?r1=245433&r2=245432&pathrev=245433
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc?r1=245433&r2=245432&pathrev=245433
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=245433&r2=245432&pathrev=245433
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/apps/native_app_window_views.cc?r1=245433&r2=245432&pathrev=245433
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc?r1=245433&r2=245432&pathrev=245433
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/window/dialog_delegate.cc?r1=245433&r2=245432&pathrev=245433
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=245433&r2=245432&pathrev=245433
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=245433&r2=245432&pathrev=245433

Linux Aura: Added --use-system-title-bar flag.

This flag makes browser windows use the system window dressing and title
bar, instead of the custom frame. This is a Linux Aura equivalent of the
"Use System Title Bar and Border" preference in Linux GTK. (Eventually,
this part will be controlled by the same preference, rather than this
flag.)

With this flag, browser windows use the native system window decoration,
with our custom close/minimize/maximize buttons removed, and the tab
strip being condensed vertically with square corners (like the maximized
tab strip). Popup browser windows (including V1 apps and the Developer
Tools window) drop the blue custom frame altogether in favour of the
native frame.

BUG=317859
TEST=With --use-system-title-bar, open a browser window. Both maximized
and restored windows should have a system native title bar, and the tab
strip should be compacted into a single row (as when maximized).
TEST=With --use-system-title-bar, open a hosted app window. It should
have a system native title bar, with no second blue title bar.

Review URL: https://codereview.chromium.org/111723012
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #29 on issue 317859 by bugdro...@chromium.org: "Use system titles

and borders" is gone in Linux/Aura build

http://code.google.com/p/chromium/issues/detail?id=317859#c29

------------------------------------------------------------------------
r245470 | hash...@chromium.org | 2014-01-17T09:58:05.210776Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=245470&r2=245469&pathrev=245470
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=245470&r2=245469&pathrev=245470
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=245470&r2=245469&pathrev=245470
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_frame.cc?r1=245470&r2=245469&pathrev=245470
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc?r1=245470&r2=245469&pathrev=245470
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/widget.h?r1=245470&r2=245469&pathrev=245470
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h?r1=245470&r2=245469&pathrev=245470
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc?r1=245470&r2=245469&pathrev=245470
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc?r1=245470&r2=245469&pathrev=245470
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=245470&r2=245469&pathrev=245470
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/apps/native_app_window_views.cc?r1=245470&r2=245469&pathrev=245470
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc?r1=245470&r2=245469&pathrev=245470
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/window/dialog_delegate.cc?r1=245470&r2=245469&pathrev=245470

Revert 245433 "Linux Aura: Added --use-system-title-bar flag."

DesktopScreenX11Test.GetWindowAtScreenPoint in views_unittests is faling
on "Linux Aura Tests" after this change.
http://build.chromium.org/p/chromium.linux/builders/Linux%20Aura%20Tests/builds/701

> Linux Aura: Added --use-system-title-bar flag.

> This flag makes browser windows use the system window dressing and title
> bar, instead of the custom frame. This is a Linux Aura equivalent of the
> "Use System Title Bar and Border" preference in Linux GTK. (Eventually,
> this part will be controlled by the same preference, rather than this
> flag.)

> With this flag, browser windows use the native system window decoration,
> with our custom close/minimize/maximize buttons removed, and the tab
> strip being condensed vertically with square corners (like the maximized
> tab strip). Popup browser windows (including V1 apps and the Developer
> Tools window) drop the blue custom frame altogether in favour of the
> native frame.

> BUG=317859
> TEST=With --use-system-title-bar, open a browser window. Both maximized
> and restored windows should have a system native title bar, and the tab
> strip should be compacted into a single row (as when maximized).
> TEST=With --use-system-title-bar, open a hosted app window. It should
> have a system native title bar, with no second blue title bar.

> Review URL: https://codereview.chromium.org/111723012

TBR=mgi...@chromium.org

Review URL: https://codereview.chromium.org/139303014

[chro...@googlecode.com]

Updates:
Cc: rponn...@chromium.org
Labels: Needs-Feedback

Comment #30 on issue 317859 by rponn...@chromium.org: "Use system titles

and borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Tested this issue on Ubuntu 12.04 using 34.0.1795.0 (Official Build 245851)
dev aura.

With the Flag: --use-system-title-bar -- Unable to see system title bar at
restored browser window. Please find the attached screenshot for reference.

Please confirm, If I missed anything.

[chro...@googlecode.com]

Comment #31 on issue 317859 by rponn...@chromium.org: "Use system titles

and borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Attaching the missed screenshots here

Attachments:
Blue title bar.png 114 KB
Use System title bar.png 85.7 KB

[chro...@googlecode.com]

Comment #33 on issue 317859 by rponn...@chromium.org: "Use system titles

and borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

@mgi...@chromium.org: Thanks for putting back. Also, could you please let
me know on which Linux Aura build, can i try this.

[chro...@googlecode.com]

Comment #34 on issue 317859 by bugdro...@chromium.org: "Use system titles

and borders" is gone in Linux/Aura build

http://code.google.com/p/chromium/issues/detail?id=317859#c34

------------------------------------------------------------------------
r246244 | mgi...@chromium.org | 2014-01-22T08:57:10.420359Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_frame.cc?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/widget.h?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/apps/native_app_window_views.cc?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/window/dialog_delegate.cc?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=246244&r2=246243&pathrev=246244
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=246244&r2=246243&pathrev=246244

Linux Aura: Added --use-system-title-bar flag.

This flag makes browser windows use the system window dressing and title
bar, instead of the custom frame. This is a Linux Aura equivalent of the
"Use System Title Bar and Border" preference in Linux GTK. (Eventually,
this part will be controlled by the same preference, rather than this
flag.)

With this flag, browser windows use the native system window decoration,
with our custom close/minimize/maximize buttons removed, and the tab
strip being condensed vertically with square corners (like the maximized
tab strip). Popup browser windows (including V1 apps and the Developer
Tools window) drop the blue custom frame altogether in favour of the
native frame.

BUG=317859
TEST=With --use-system-title-bar, open a browser window. Both maximized
and restored windows should have a system native title bar, and the tab
strip should be compacted into a single row (as when maximized).
TEST=With --use-system-title-bar, open a hosted app window. It should
have a system native title bar, with no second blue title bar.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245433

Review URL: https://codereview.chromium.org/111723012
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #35 on issue 317859 by astiktru...@gmail.com: "Use system titles

and borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

In linux, is it possible to use only system borders and NOT title bar ?

[chro...@googlecode.com]

Comment #39 on issue 317859 by astiktru...@gmail.com: "Use system titles

and borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

I mean there should be an option to use system borders with hidden title
bar, because that option now not only hides title bar, it also uses kind of
crappy theme, so it would be nice, if i could use my system theme on
chromium with no title bar, because now i'm forced to choose between waste
of my screen space (title bar) and crappy looks (that 2 in 1 option).

[chro...@googlecode.com]

Comment #40 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

astiktrumpam: Sorry, this is an issue with your window manager, not Chrome.
We just provide you with 2 choices: either you use our supplied title bar
(which you say looks crappy), or we tell your window manager: "we are not
providing any title bar or border -- you do it." Then it is up to your
window manager how to display the title bar and border if any.

As far as I know, there is no way to tell an X11 window manager explicitly
to show borders but no title bar. If you are using Gnome, for example, you
will get the standard Gnome border and title bar. If you are using a tiling
window manager like XMonad, you will typically not get any title bar at
all. So this is an issue for the window manager, not Chrome.

[chro...@googlecode.com]

Updates:
Blockedon: -chromium:334943

Comment #41 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #42 on issue 317859 by patrick....@oliviero.fr: "Use system titles

and borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

The flag doesn't work for me. When I use it i get no titlebar at all !
Kubuntu 13.10 amd64
Kde 4.11.3
Chromium Version 34.0.1803.0 aura (246782)

[chro...@googlecode.com]

Comment #44 on issue 317859 by pdknsk: "Use system titles and borders" is

gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

It works in Ubuntu. The difference is only noticeable windowed.

There is still a minor bug. The tab strip is shaded, whereas it is flat
non-Aura. Exception is windowed without the flag.

[chro...@googlecode.com]

Comment #45 on issue 317859 by pdknsk: "Use system titles and borders" is

gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

PS. 34.0.1809.0 (Aura)

[chro...@googlecode.com]

Comment #48 on issue 317859 by saiarcot...@gmail.com: "Use system titles

and borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Regarding the shaded tab strip, pre-Aura, the tab strip area in Ubuntu is a
solid dark gray, close to the color that Ubuntu menus use. With Aura, it is
a linear shade.

I haven't tested the flag and any effects it has.

[chro...@googlecode.com]

Updates:
Cc: m...@chromium.org

Comment #50 on issue 317859 by m...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Thanks for this! :-)

Just tried this with a local build. Everything works great, except my
window manager (XMonad) is not drawing the window border. Are system
borders working for other people?

[chro...@googlecode.com]

Comment #51 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

miu: Confirmed. My hypothesis is that this is the same issue on KDE (Issue
338916), which I am currently working on.

[chro...@googlecode.com]

Comment #52 on issue 317859 by pdknsk: "Use system titles and borders" is

gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

shaded tab strip bug:
https://code.google.com/p/chromium/issues/detail?id=339418

[chro...@googlecode.com]

Comment #54 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

@epg:
> The unstable deb is back on Aura apparently, and I am seeing the
> same thing as you.

As who? What behaviour are you seeing? What window manager?

> With the flag enabled, Aura is still setting
> Motif hints that it should not; here's the diff from without the
> titlebar flag to with:

> -_MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x2, 0x0, 0x0, 0x0, 0x0
> +_MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x2, 0x0, 0x1, 0x0, 0x0

> It's been a decade or more since I've hacked on a window manager,
> and I can't interpret these flags anymore :)

The flags are correct in both cases. The first byte is 2 meaning "set the
decorations" and the third byte is 0 or 1 to hide or show decorations,
respectively.

> But you can dump the xprops of a window from non-aura and see
> that it's not setting any of these hints at all. Probably aura
> should do the same.

Is there any good reason to not set the Motif hints as opposed to setting
the hint to 1? As far as I know, they should give the same behaviour (title
bar and borders).

[chro...@googlecode.com]

Comment #55 on issue 317859 by e...@google.com: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

chro...@googlecode.com writes:

Sorry; same as m...@chromium.org

That is, I see fvwm's title-bar and buttons, but no frame.
This is exactly the same that fvwm was drawing the last time aura
was pushed; all that's changed is that Chrome no longer draws its
own close button.

Are you sure 1 just means 'show all deocrations'? My (admittedly
faded) memory is that at least some of these bytes are bit flags.
And what are the third and fourth bytes?

I've hacked on fvwm enough to know it's not perfect (quite the
contrary :), but it's mwm compat code has been stable for ages,
so it seems really unlikely to me to be an fvwm bug here.

Rather than fixing the flags you're setting, I'm suggesting you
not set any flags at all in the "Use system decorations" mode.
The idea is to let my window manager decide on its own (or based
on my configuration) what to do rather than dictating it.

I take this option as meaning "leave it up to the window
manager". Setting Motif hints of all things, which are probably
misimplemented at least to some degree in all window managers but
mwm itself, is not that.

Thanks.

[chro...@googlecode.com]

Comment #56 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Oh I see miu's comment. That is Issue 338916; I've just confirmed it on
FVWM as well, and my CL fixes it. (So the Motif hints was a red herring.)

> Are you sure 1 just means 'show all deocrations'? My (admittedly
> faded) memory is that at least some of these bytes are bit flags.
> And what are the third and fourth bytes?

Yes. See:
http://stuff.mit.edu/afs/athena/project/wm-beta/src/WindowMaker-0.70.0/src/motif.c
The third byte is a bit flag, but Bit 0 means "show all decorations" (one
wonders why 0xff couldn't serve that purpose). The other bytes are just
other fields in the MWMHints struct.

> I take this option as meaning "leave it up to the window
> manager". Setting Motif hints of all things, which are probably
> misimplemented at least to some degree in all window managers but
> mwm itself, is not that.

A reasonable argument, but setting MWM decorations to 1 seems to do the
right thing in every window manager I've tried (including FVWM) so I'd
prefer not to change it unless there is a good reason to.

[chro...@googlecode.com]

Comment #57 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

An aside: FVWM doesn't seem to be able to deal with changing the decoration
bit on and off for an existing window. For example, on Chrome GTK, changing
the "Use System Title Bar and Borders" property gives you either no borders
or double borders until you restart Chrome. There doesn't seem to be any
way around this.

[chro...@googlecode.com]

Comment #58 on issue 317859 by bugdro...@chromium.org: "Use system titles

and borders" is gone in Linux/Aura build

http://code.google.com/p/chromium/issues/detail?id=317859#c58

------------------------------------------------------------------------
r248097 | mgi...@chromium.org | 2014-01-31T01:13:00.100119Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc?r1=248097&r2=248096&pathrev=248097
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc?r1=248097&r2=248096&pathrev=248097
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc?r1=248097&r2=248096&pathrev=248097

Refactor OpaqueBrowserFrameView; reduce uses of kUseSystemTitleBar.

This brings the number of places in the codebase that use the
kUseSystemTitleBar switch variable down to two (down from five).

This will reduce the number of places that need to be changed to replace
this flag with a preference.

BUG=317859

Review URL: https://codereview.chromium.org/146343002
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #59 on issue 317859 by gaspa...@gmail.com: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Seems to be working normally with Window Maker 0.95.5 - titlebar + resize
handles.

[chro...@googlecode.com]

Comment #62 on issue 317859 by var...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Issue 339880 has been merged into this issue.

[chro...@googlecode.com]

Comment #64 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Issue 340011 has been merged into this issue.

[chro...@googlecode.com]

Comment #65 on issue 317859 by bugdro...@chromium.org: "Use system titles

and borders" is gone in Linux/Aura build

http://code.google.com/p/chromium/issues/detail?id=317859#c65

------------------------------------------------------------------------
r250391 | mgi...@chromium.org | 2014-02-11T14:08:14.018642Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/toolbar/toolbar_view.cc?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/tab.cc?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_x11.h?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/desktop_aura/desktop_native_widget_aura.h?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host.h?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/widget.cc?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/widget.h?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/native_widget_private.h?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.cc?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.h?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/tab_strip.cc?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_win.h?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/native_widget_aura.cc?r1=250391&r2=250390&pathrev=250391
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/native_widget_aura.h?r1=250391&r2=250390&pathrev=250391

Widget::ShouldUseNativeFrame is now meaningful on Linux.

This change is a big refactor to make this work without breaking
Windows. Previously, a lot of views code assumed that
ShouldUseNativeFrame meant an Aero Glass window (having the tab strip
transparently overlap a native frame), which is not true on Linux. Now,
another property, ShouldWindowContentsBeTransparent, is used to in the
Aero Glass case. On Windows, these two properties are the same, but on
Linux, the former can be true without the latter.

Now, in Linux Aura, browser windows run with --use-system-title-bar will
have ShouldUseNativeFrame return true, without any visual anomalies.
This has two purposes (both of which I will need soon):
1. It allows DesktopWindowTreeHostX11 to behave differently depending on
whether the window has a native frame.
2. It will allow the window frame to be added or removed dynamically
through Widget::set_frame_type.

BUG=317859

Review URL: https://codereview.chromium.org/136093007
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #66 on issue 317859 by bugdro...@chromium.org: "Use system titles

and borders" is gone in Linux/Aura build

http://code.google.com/p/chromium/issues/detail?id=317859#c66

------------------------------------------------------------------------
r250995 | mgi...@chromium.org | 2014-02-13T14:43:34.756198Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/system_menu_model_delegate.cc?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_view_prefs.cc?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_view_prefs.h?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prefs/browser_prefs.cc?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_command_controller.cc?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_frame.cc?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/system_menu_model_builder.cc?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_frame.h?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_command_ids.h?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=250995&r2=250994&pathrev=250995
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/options/browser_options.html?r1=250995&r2=250994&pathrev=250995

Linux Aura: Use system title bar is now set by preference, not flag.

The "Use system title bar and borders" preference can now be set on
Linux Aura, through the settings page or tabstrip menu, and is used to
determine whether the system title bar or custom Chrome title bar style
is used. Changing the preference dynamically updates the browser style.

Removed the --use-system-title-bar flag.

BUG=317859

Review URL: https://codereview.chromium.org/146363002

[chro...@googlecode.com]

Updates:
Status: Fixed
Labels: -Needs-Feedback

Comment #67 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

You should now be able to switch between custom and native borders using
the checkbox on the settings page, or the context menu on the tabstrip, as
you have been able to do historically.

Please note that Chrome Dev channel is currently on the GTK build, so this
doesn't directly affect Dev (yet). Please don't respond with problems
or "works for me" unless you are using an Aura build (blue 'a' next to the
Chrome menu).

Thanks to all the Linux Dev channel users for your patience with this. It
was a heavily demanded feature/regression so we're glad we were able to
support it before the official release of Linux Aura.

[chro...@googlecode.com]

Comment #68 on issue 317859 by saiarcot...@gmail.com: "Use system titles

and borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

The latest dev release is at 250058, so the latest change wouldn't have
gone in.

[chro...@googlecode.com]

Comment #69 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Yeah, what I am saying is that even in the *next* Dev release, this change
won't be in because it will be GTK. You'll have to wait until Aura gets
switched on to Dev before you can test this new implementation of the
feature (or test it on tip-of-tree).

[chro...@googlecode.com]

Comment #70 on issue 317859 by saiarcot...@gmail.com: "Use system titles

and borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

Ah, ok.

On another note, why *was* Aura disabled? The only thing I can find is the
revert commit in the dev branch.

[chro...@googlecode.com]

Comment #71 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

It was just disabled in Dev to prepare for shipping GTK in beta and stable
channels [1] in M34 (Linux Aura is not ready for M34). Once M34 is in beta,
Dev will flip to M35 and back to Aura -- hopefully permanently this time.

[1]
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/UMwGGgP0P9c/ovN1dWkmv7MJ

[chro...@googlecode.com]

Comment #72 on issue 317859 by bugdro...@chromium.org: "Use system titles

and borders" is gone in Linux/Aura build

http://code.google.com/p/chromium/issues/detail?id=317859#c72

------------------------------------------------------------------------
r252586 | e...@chromium.org | 2014-02-21T17:37:10.014712Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/x/x11_util.h?r1=252586&r2=252585&pathrev=252586
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_view_prefs.cc?r1=252586&r2=252585&pathrev=252586
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/browser_window_gtk.cc?r1=252586&r2=252585&pathrev=252586
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/browser_window_gtk.h?r1=252586&r2=252585&pathrev=252586
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/x/x11_util.cc?r1=252586&r2=252585&pathrev=252586

linux_aura: Default to system titlebars under some window managers.

This moves the existing window manager check in BrowserWindowGtk to
shared X11 code.

BUG=317859
R=mgi...@chromium.org, m...@chromium.org, sad...@chromium.org

Review URL: https://codereview.chromium.org/174223004
------------------------------------------------------------------------

[chro...@googlecode.com]

Issue 317859: "Use system titles and borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

This issue is now blocking issue chromium:348437.
See http://code.google.com/p/chromium/issues/detail?id=348437

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #75 on issue 317859 by mgi...@chromium.org: "Use system titles and

borders" is gone in Linux/Aura build
http://code.google.com/p/chromium/issues/detail?id=317859

@epg: Thanks for pointing that out. I've filed a separate bug for this
(Issue 348437). Note that it is a low priority. We mainly just wanted to
make sure the browser window could be made native.

--