Re: Issue 115403 in chromium: WebUI Task Manager: the saved size is used as the "minimum" size of window unintentionally.

chro...@googlecode.com

unread,

Mar 5, 2012, 12:40:24 PM3/5/12

to chromi...@chromium.org

Updates:
Summary: WebUI Task Manager: the saved size is used as the "minimum" size
of window unintentionally.
Cc: k...@chromium.org ma...@chromium.org
Labels: Feature-WebUI OS-Linux Feature-Ash

Comment #9 on issue 115403 by yos...@chromium.org: WebUI Task Manager: the
saved size is used as the "minimum" size of window unintentionally.
http://code.google.com/p/chromium/issues/detail?id=115403

Changing the title and adding labels and CCs.

chro...@googlecode.com

unread,

Mar 7, 2012, 1:26:20 AM3/7/12

to chromi...@chromium.org

Updates:
Cc: yos...@chromium.org sain...@chromium.org gl...@chromium.org
kenmo...@chromium.org

Comment #12 on issue 115403 by yos...@chromium.org: WebUI Task Manager:

the saved size is used as the "minimum" size of window unintentionally.
http://code.google.com/p/chromium/issues/detail?id=115403

Issue 116938 has been merged into this issue.

chro...@googlecode.com

unread,

Mar 20, 2012, 5:23:37 AM3/20/12

to chromi...@chromium.org

Comment #17 on issue 115403 by bugdro...@chromium.org: WebUI Task Manager:

the saved size is used as the "minimum" size of window unintentionally.

http://code.google.com/p/chromium/issues/detail?id=115403#c17

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=127660

------------------------------------------------------------------------
r127660 | yos...@chromium.org | Tue Mar 20 02:09:45 PDT 2012

WebUI TaskManager: Add method to set minimum window size on HTMLDialog.

Previously, the saved window size is used as the "minimum" size of window
on HTMLDialog (cf. http://crbug.com/115403). This CL make the saved size as
default size and adds the GetMinimumDialogSize() method in HTMLDialogUI to
set minimum size of window separately.

This CL also enables the viwes::Widget::SaveWindowPlacement() on
TaskManagerDialog by adding HtmlDialogView::GetWindowName() and
HtmlDialogUIDelegate::GetDialogName() virtual functions. And this CL
disables to save the window placement on TaskManagerDialog on views, since
views::Widget has same feature which is enabled by this CL.

BUG=115403
TEST=manual on Windows, Linux with gtk and Linux with chromiumos=1

Review URL: http://codereview.chromium.org/9569001
------------------------------------------------------------------------

chro...@googlecode.com

unread,

Mar 20, 2012, 8:44:48 AM3/20/12

to chromi...@chromium.org

Comment #18 on issue 115403 by bugdro...@chromium.org: WebUI Task Manager:

the saved size is used as the "minimum" size of window unintentionally.

http://code.google.com/p/chromium/issues/detail?id=115403#c18

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=127671

------------------------------------------------------------------------
r127671 | bat...@chromium.org | Tue Mar 20 04:46:09 PDT 2012

Revert 127660 - WebUI TaskManager: Add method to set minimum window size on
HTMLDialog.

Previously, the saved window size is used as the "minimum" size of window
on HTMLDialog (cf. http://crbug.com/115403). This CL make the saved size as
default size and adds the GetMinimumDialogSize() method in HTMLDialogUI to
set minimum size of window separately.

This CL also enables the viwes::Widget::SaveWindowPlacement() on
TaskManagerDialog by adding HtmlDialogView::GetWindowName() and
HtmlDialogUIDelegate::GetDialogName() virtual functions. And this CL
disables to save the window placement on TaskManagerDialog on views, since
views::Widget has same feature which is enabled by this CL.

BUG=115403
TEST=manual on Windows, Linux with gtk and Linux with chromiumos=1

Review URL: http://codereview.chromium.org/9569001

Reverting the CL, with the suspicion that it causes
PrintDialogCloudTest.HandlersRegistered and
ProtectorServiceTest.ShowAndDiscardManually to time out on Windows.

TBR=yos...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9749003
------------------------------------------------------------------------

chro...@googlecode.com

unread,

Mar 21, 2012, 6:00:55 PM3/21/12

to chromi...@chromium.org

Comment #19 on issue 115403 by sain...@chromium.org: WebUI Task Manager:

the saved size is used as the "minimum" size of window unintentionally.
http://code.google.com/p/chromium/issues/detail?id=115403

Yoshiki, what is the status is this fixed?

chro...@googlecode.com

unread,

Mar 23, 2012, 3:35:15 AM3/23/12

to chromi...@chromium.org

Updates:
Status: Fixed

Comment #21 on issue 115403 by yos...@chromium.org: WebUI Task Manager:

the saved size is used as the "minimum" size of window unintentionally.
http://code.google.com/p/chromium/issues/detail?id=115403

(No comment was entered for this change.)

chro...@googlecode.com

unread,

May 16, 2012, 3:25:21 PM5/16/12

to chromi...@chromium.org

Updates:
Labels: -OS-Chrome

Comment #22 on issue 115403 by bhaves...@chromium.org: WebUI Task Manager:

the saved size is used as the "minimum" size of window unintentionally.
http://code.google.com/p/chromium/issues/detail?id=115403

Don't see it on Chrome OS: 2046.92.0.
Removing ChromeOS from label.

Reply all

Reply to author

Forward