Issue 128994 in chromium: LastPass extension manages to crash Chrome

[chro...@googlecode.com]

Status: Unconfirmed
Owner: ----
Labels: Type-Bug Pri-2 Stability-Crash

New issue 128994 by silvi...@gmail.com: LastPass extension manages to crash
Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Chrome Version: 19.0.1084.46
Operating System: Ubuntu 12.04 64bit

URL (if applicable) where crash occurred: it happens even on "Most visited"

Can you reproduce this crash?

What steps will reproduce this crash (or if it's not reproducible, what
were you doing just before the crash)?
1. If you have LastPass extension installed, right-click on the "Most
Visited" page
2. On the menu that opens go to the "Last Pass" menu entry and
then "Autofill>"
3. This will generate endless "no entry found" (or something along those
lines) in the list that is presented until chrome finally crashes.

*Please note that issues filed with no information filled in above will be
marked as WontFix*

****DO NOT CHANGE BELOW THIS LINE****
report_id:5504a7936ac3377d

[chro...@googlecode.com]

Updates:
Labels: OS-Linux

Comment #1 on issue 128994 by meh...@chromium.org: LastPass extension

manages to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #3 on issue 128994 by vcla...@chromium.org: LastPass extension

manages to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Unable to reproduce on Ubuntu 10.04 with 19.0.1084.46. May be specific to
12.04?

Thread 0 *CRASHED* ( SIGSEGV @ 0x700000008 )

0x7f67f85690f6 [libdbusmenu-glib.so.4.0.12] + 0x000070f6]
0x7f67f8789e8e [libdbusmenu-gtk.so.4.0.12] + 0x0000ce8e]
0x7f67f878b00e [libdbusmenu-gtk.so.4.0.12] + 0x0000e00e]
0x7f680d0be1ff [libgobject-2.0.so.0.3200.1] + 0x000131ff]
0x7f680d0baca1 [libgobject-2.0.so.0.3200.1] - gclosure.c:777]
g_closure_invoke
0x7f680d0cbd70 [libgobject-2.0.so.0.3200.1] - gsignal.c:3547]
signal_emit_unlocked_R
0x7f680d0d4098 [libgobject-2.0.so.0.3200.1] - gsignal.c:3296]
g_signal_emit_valist
0x7f680d0d4753 [libgobject-2.0.so.0.3200.1] - gsignal.c:3389]
g_signal_emit_by_name
0x7f680e9220b0 [chrome] - chrome/browser/ui/gtk/menu_gtk.cc:376]
MenuGtk::AppendMenuItemToMenu
0x7f680e92309b [chrome] - chrome/browser/ui/gtk/menu_gtk.cc:525]
MenuGtk::BuildSubmenuFromModel
0x7f680e923635 [chrome] - chrome/browser/ui/gtk/menu_gtk.cc:767]
MenuGtk::OnSubMenuShow
0x7f680d0baca1 [libgobject-2.0.so.0.3200.1] - gclosure.c:777]
g_closure_invoke
0x7f680d0cbd70 [libgobject-2.0.so.0.3200.1] - gsignal.c:3547]
signal_emit_unlocked_R
0x7f680d0d4098 [libgobject-2.0.so.0.3200.1] - gsignal.c:3296]
g_signal_emit_valist
0x7f680d0d4241 [libgobject-2.0.so.0.3200.1] - gsignal.c:3352]
g_signal_emit
0x7f680c7d2c15 [libgtk-x11-2.0.so.0.2400.10] - gtkwidget.c:3218]
IA__gtk_widget_show
0x7f67f8788f37 [libdbusmenu-gtk.so.4.0.12] + 0x0000bf37]
0x7f680cbfbc99 [libglib-2.0.so.0.3200.1] - gmain.c:2515]
g_main_context_dispatch
0x7f680cbfc05f [libglib-2.0.so.0.3200.1] - gmain.c:3123]
g_main_context_iterate
0x7f680cbfc123 [libglib-2.0.so.0.3200.1] - gmain.c:3184]
g_main_context_iteration
0x7f680ef9f0cf [chrome] - base/message_pump_glib.cc:206]
base::MessagePumpGlib::RunWithDispatcher
0x7f680ef6b237 [chrome] - base/message_loop.cc:390]
MessageLoopForUI::RunWithDispatcher
0x7f680ed63705 [chrome] - chrome/browser/chrome_browser_main.cc:1848]
ChromeBrowserMainParts::MainMessageLoopRun
0x7f6810712100 [chrome] - content/browser/browser_main_loop.cc:452]
content::BrowserMainLoop::RunMainMessageLoopParts
0x7f681071390c [chrome] - content/browser/browser_main_runner.cc:94]
BrowserMainRunnerImpl::Run
0x7f6810711e78 [chrome] - content/browser/browser_main.cc:21] BrowserMain
0x7f680ef1a139 [chrome] - content/app/content_main_runner.cc:282]
ContentMainRunnerImpl::Run
0x7f680ef19930 [chrome] - content/app/content_main.cc:35]
content::ContentMain
0x7f680e82cc4c [chrome] - chrome/app/chrome_main.cc:32] ChromeMain
0x7f680e82cc05 [chrome] - chrome/app/chrome_exe_main_gtk.cc:18] main
0x7f68080b376c [libc-2.15.so] - libc-start.c:226] __libc_start_main
0x7f680e82cb28 [chrome] + 0x005aeb28]

[chro...@googlecode.com]

Comment #4 on issue 128994 by silvi...@gmail.com: LastPass extension

manages to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

I have no idea. I have a xubuntu 12.04 install in a vm and I can't
reproduce it there either, but it still happens on my main Ubuntu 12.04
install. Ugh.

[chro...@googlecode.com]

Comment #6 on issue 128994 by fabien.b...@gmail.com: LastPass extension

manages to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Indeed, I had the issue since my upgrade to 12.04.

[chro...@googlecode.com]

Comment #7 on issue 128994 by ABasta...@gmail.com: LastPass extension

manages to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

I see the same behavior on Ubuntu 12.04 with Chrome 19.0.1084.52, except I
also see a much more general problem. Recently (within the last few days),
any time I right click on any form field on a page and choose LastPass >
Fill Forms and select my profile, it starts generating an infinite list
of "Edit Profile" and "Fill Form" options until Chrome eventually crashes.
The same thing happens if I select AutoFill, though in that case it
generates a long list of all of my accounts and ultimately crashes Chrome.
If the AutoFill option appears in the bar at the top of the page, clicking
it does nothing, but again eventually crashes Chrome. I've been using
LastPass with Chrome on Ubuntu 12.04 for a couple months (since the 12.04
beta2 release) with no problems until the last few days, so this must be
due to a recent change in Ubuntu, Chrome, or LastPass.

[chro...@googlecode.com]

Comment #8 on issue 128994 by ABasta...@gmail.com: LastPass extension

manages to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

According to LastPass, this is indeed a bug in Chrome
(http://forums.lastpass.com/viewtopic.php?f=14&t=81149&p=270383#p270383).
I'm not sure what the issue is, but presumably it could affect more than
just LastPass.

[chro...@googlecode.com]

Comment #9 on issue 128994 by hav...@gmail.com: LastPass extension manages

to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

I got a crash like this also. I tried to access "Bookmarks"->"Other
Bookmarks" through chrome menu. The google-chrome just died like that.

There was no "crash report" generated as far as I know, I could only grab
the dmesg content:

[11792.904574] show_signal_msg: 54 callbacks suppressed
[11792.904579] chrome[2843]: segfault at 700000008 ip 00007f4e6195e0f6 sp
00007fff0867e1e0 error 4 in libdbusmenu-glib.so.4.0.12[7f4e61957000+1a000]
[11814.200443] chrome[8071]: segfault at 7f11e1f2d330 ip 00007f11e1f2d330
sp 00007fff0e663b88 error 15

My OS is Ubuntu 12.04 64 bit, latest update, with google-chrome Version
19.0.1084.52 .

[chro...@googlecode.com]

Comment #10 on issue 128994 by y...@chromium.org: LastPass extension manages

to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

#9: can you look at chrome://crashes and see if it's showing any crash IDs?

[chro...@googlecode.com]

Comment #11 on issue 128994 by ABasta...@gmail.com: LastPass extension

manages to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

At chrome://crashes, I see Crash ID be912b9a1c4d6572 right after a crash
generated by LastPass.

[chro...@googlecode.com]

Comment #12 on issue 128994 by jferl...@gmail.com: LastPass extension

manages to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Possibly related (I noticed it at the same time), clicking on the lastpass
icon doesn't give you any menu. It looks like it has clicked visually but
no menu appears

[chro...@googlecode.com]

Updates:
Owner: m...@chromium.org

Comment #13 on issue 128994 by y...@chromium.org: LastPass extension manages

to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Stack trace excerpt:

0x7f6af048f160 [chrome] - chrome/browser/ui/gtk/menu_gtk.cc:376]
MenuGtk::AppendMenuItemToMenu
0x7f6af049014b [chrome] - chrome/browser/ui/gtk/menu_gtk.cc:525]
MenuGtk::BuildSubmenuFromModel
0x7f6af04906e5 [chrome] - chrome/browser/ui/gtk/menu_gtk.cc:767]
MenuGtk::OnSubMenuShow

[chro...@googlecode.com]

Updates:
Labels: Area-UI

Comment #14 on issue 128994 by y...@chromium.org: LastPass extension manages

to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Not sure if the crashes in MenuGtk::SetMenuItemInfo and
MenuGtk::OnSubMenuShow (among the top 20 stable channel crashes on Linux)
are related also; only this one appears to still be common on dev channel.

[chro...@googlecode.com]

Comment #16 on issue 128994 by jschritt...@google.com: LastPass extension

manages to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

I have the same issue on Version 23.0.1270.0 dev, trying to run
https://github.com/Mononofu/CryptoChrome

Any updates?

crash IDs:
569100d4fff5ea6f
a6323d4dd1200c96
7588bc9a660de6b5
05cdb374d2c96853

[chro...@googlecode.com]

Comment #17 on issue 128994 by m...@chromium.org: LastPass extension manages

to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

So, I've just managed to track down the problem here. There's a package in
Ubuntu called libdbusmenu-gtk which is basically injected into all GTK
applications, and adds callbacks on all the menus and menu items to send
serialized versions over DBus to the global menu thing at the top of the
screen. That's how app menus are automatically made to appear there, even
though that area is actually a separate application.

Unfortunately, it doesn't discriminate between menus that are actually part
of the app's menu bar, and other menus - it can't, actually, as far as I
can tell. It just has to mirror them all on the other side, and then use
only the ones that end up being reachable from the window's menu bar at the
time the user uses them.

Some applications seem to only populate their menus upon being shown the
first time, and so this library takes that into account (it names empathy
and geany in a comment) and shows each menu briefly in order to get an
accurate idea of what the menu items are. This works OK unless the
application also tears down the menu when hidden, as we do in our bookmark
menu. Because of that, libdbusmenu-gtk gets confused and shows it again,
since it looks like the menu has changed. And then we build it again, and
it shows it again, and we tear it down again, and so on.

Because it's happening inside the application rather than in response to
user events, the possible event orderings change a little bit, introducing
some race conditions that end up crashing us every now and then. Couple
that with spinning in a tight loop creating and destroying menus, and
pretty soon we'll hit one of those cases. Bugs 131974 and 124110 are both
very likely caused by this as well.

I'll see if I can figure out some way to avoid the problem.

[chro...@googlecode.com]

Comment #18 on issue 128994 by m...@chromium.org: LastPass extension manages

to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Issue 139361 has been merged into this issue.

[chro...@googlecode.com]

Comment #19 on issue 128994 by m...@chromium.org: LastPass extension manages

to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Issue 122501 has been merged into this issue.

[chro...@googlecode.com]

Comment #20 on issue 128994 by m...@chromium.org: LastPass extension manages

to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Issue 139767 has been merged into this issue.

[chro...@googlecode.com]

Updates:
Cc: e...@chromium.org

Comment #21 on issue 128994 by m...@chromium.org: LastPass extension manages

to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Issue 125521 has been merged into this issue.

[chro...@googlecode.com]

Comment #22 on issue 128994 by m...@chromium.org: LastPass extension manages

to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Issue 130583 has been merged into this issue.

[chro...@googlecode.com]

Comment #23 on issue 128994 by m...@chromium.org: LastPass extension manages

to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Issue 134108 has been merged into this issue.

[chro...@googlecode.com]

Comment #24 on issue 128994 by m...@chromium.org: LastPass extension manages

to crash Chrome
http://code.google.com/p/chromium/issues/detail?id=128994

Issue 139999 has been merged into this issue.