Re: Issue 67348 in chromium: MSI DisplayVersion to match Chrome version

[chro...@googlecode.com]

Comment #2 on issue 67348 by tbiggins: MSI DisplayVersion to match Chrome
version
http://code.google.com/p/chromium/issues/detail?id=67348

I'll talk to the folks over at Spiceworks - maybe they have some thoughts.
Stay tuned...

[chro...@googlecode.com]

Comment #4 on issue 67348 by b...@spiceworks.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Looks like these are our options in terms of content Spiceworks can pull in
for versioning (attached). Spiceworks pulls this type of information
directly from the uninstall registry hive.

Because we can't control what the MSI writes, and the proper version is not
in the uninstall hive perhaps we can write in the version translation
algorithm into Spiceworks (x.x.x -> x.x.x.x)?

gwilson, how does the algorithm work?

Attachments:
chrome reg.PNG 24.3 KB

[chro...@googlecode.com]

Updates:
Cc: robertsh...@chromium.org

Comment #5 on issue 67348 by gwi...@chromium.org: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Here's the algorithm:

Convert Chrome version a.b.c.d to MSI version A.B.C:

Chrome a.b.c.d -> a.(c>>8).(((c & 0xFF) << 8) + d)

Convert MSI version A.B.C to Chrome version a.b.c.d:

A.B.C -> a.b.c.d

a -> A
b -> Unknown, but assume "0"
c -> (B << 8) + (C >> 8)
d -> C & 0xFF

[chro...@googlecode.com]

Comment #6 on issue 67348 by b...@spiceworks.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Thanks gwilson, we'll look at how converting the version number properly
within Spiceworks would work. I think we should have everything we need to
do so! :)

[chro...@googlecode.com]

Comment #7 on issue 67348 by b...@spiceworks.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Found the references to the DisplayVersion/ProductVersion. Looks like the
fourth field is explicitly removed, as gwilson said. :(

http://msdn.microsoft.com/en-us/library/aa372105%28v=vs.85%29.aspx,
http://msdn.microsoft.com/en-us/library/aa370859%28v=vs.85%29.aspx

[chro...@googlecode.com]

Comment #8 on issue 67348 by b...@spiceworks.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

This should be fixed (translated back to the 4 digit version) in the next
release version of Spiceworks 5.0 (might be 5.1)... >5.x.60839

[chro...@googlecode.com]

Comment #10 on issue 67348 by tbiggins: MSI DisplayVersion to match Chrome
version
http://code.google.com/p/chromium/issues/detail?id=67348

This is working great, BTW. Hats off to Ben @ Spiceworks / thanks to
gwilson.

[chro...@googlecode.com]

Updates:
Labels: -Pri-3 Pri-2

Comment #13 on issue 67348 by robert...@chromium.org: MSI DisplayVersion

to match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Good idea, bumping this feature request to Pri-2.

[chro...@googlecode.com]

Comment #14 on issue 67348 by tbigg...@gmail.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

You think this might take effect when stable goes to version 10? That
would be great!

[chro...@googlecode.com]

Comment #16 on issue 67348 by gwil...@chromium.org: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Issue 100551 has been merged into this issue.

[chro...@googlecode.com]

Comment #17 on issue 67348 by ed...@chromium.org: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Still occurring on R15 stable on Windows when installed via MSI.

Attachments:
image.png 77.5 KB

[chro...@googlecode.com]

Updates:
Status: Assigned
Owner: robertsh...@chromium.org
Cc: -robertsh...@chromium.org
Labels: -Pri-2 Pri-1

Comment #22 on issue 67348 by robertsh...@chromium.org: MSI DisplayVersion

to match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Looking into this.

[chro...@googlecode.com]

Comment #23 on issue 67348 by robertsh...@chromium.org: MSI DisplayVersion

to match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Implementation notes to self: this is slightly harder to pull off than I
had hoped; the ARP entry containing the version string is managed by the
MSI machinery - the installer will have to find it in order to mutate it.

Currently the Chrome installer is unaware of the product guid, etc, will
need to add some additional MSI awareness to the installer to plumb this
through.

[chro...@googlecode.com]

Comment #24 on issue 67348 by tbigg...@akrf.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Also note we've pushed various latest MSIs as machines get distributed over
time so
there is also bound to be a range of prior guids to seek out in the
registry when you first implement this. If you check against just the
previous guid you will miss almost everyone who has been using the msi once
and getting automated updates ever since.
Thanks so much for working on this!

[chro...@googlecode.com]

Comment #28 on issue 67348 by Rob.Las...@gmail.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Status on this issue would be nice.

more info regarding my issues here -
http://code.google.com/p/chromium/issues/detail?id=158318

[chro...@googlecode.com]

Comment #29 on issue 67348 by Rob.Las...@gmail.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

problem Still exists with Enterprise 24.0.1312.56. Add/Remove programs or
Programs and features still reflect 65.72.56. This is getting rediculous.
Doesn't anyone monitor this? Someone please respond.

[chro...@googlecode.com]

Updates:
Labels: -Mstone-X Mstone-26 Area-Internals Internals-Install

Comment #30 on issue 67348 by g...@chromium.org: MSI DisplayVersion to match
Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

@grt/robert: What is required exactly to fix this?

From the discussion leading to comment#12 I gather that we just have to
write the X.X.X equivalent of the current version in
HKLM\Software\Microsoft\Windows\CurrentVersion\Uninstall\{GUID}
HKLM\Software\Wow6432Node\Microsoft\Windows\CurrentVersion\Uninstall\{GUID}
is that correct?

@Rob: Is the issue still related to spiceworks as described originally in
this bug? Or just general version shown in the Windows UI?

Thanks,
Gab

[chro...@googlecode.com]

Comment #31 on issue 67348 by g...@chromium.org: MSI DisplayVersion to match
Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

IIRC, one challenge is that {GUID} in those registry keys is unique for
each build, so the fix would have to do some registry scanning. Not an
insurmountable task.

I wouldn't be surprised if "fixing" this will break other things. I don't
know what other software expects the version number in the registry to
match the MSI's version (which is what's stored in the Windows Installer
database).

[chro...@googlecode.com]

Comment #32 on issue 67348 by tbigg...@akrf.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

The biggest issue is that MSI is "only" used once, followed by Google
update (aka non-MSI) updates.

Per Gwilson comment 1, the MSI has limits on how it can store
DisplayVersion (which *should* be the actual Chrome browser version, not
the MSI version). So until now you guys have been using an X.X.X format
with MSI.

But the update process is an .exe - so what if the .exe update changes the
display version to x.x.x.x format based on Chrome browser version.

Perhaps the MSI, rather than in its properties, but in a cleanup process at
the end of the install, could also change its DisplayVersion to x.x.x.x

Does this sound feasible or am I making this up as I go along... ;-)
----
Comment 1: "The problem is that the DisplayVersion (MSI version) has limits
on its format. It has to be in format X.X.X, whereas Chrome versions are
X.X.X.X There is an algorithm to convert Chrome versions to MSI versions,
but it's pretty complex."

[chro...@googlecode.com]

Comment #33 on issue 67348 by tbigg...@akrf.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

http://msdn.microsoft.com/en-us/library/windows/desktop/aa372105(v=vs.85).aspx

To re-phrase: DisplayVersion and Version (and other subkeys) derive from
ProductVersion property but... after install perhaps you can call a cleanup
that alters the DisplayVersion to the X.X.X.X format. Same "cleanup"
process could happen after each gupdate

Again, I'm making this up as I go so apologies for any assumptions ;-)

[chro...@googlecode.com]

Comment #35 on issue 67348 by Rob.Las...@gmail.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

What is the verdict with this, any movement? Here is the MSDN article for
Product Version property.
http://msdn.microsoft.com/en-us/library/windows/desktop/aa370859(v=vs.85).aspx

"Major.Minor.Build"
"Note that Windows Installer uses only the first three fields of the
product version. If you include a fourth field in your product version, the
installer ignores the fourth field."

suggestions:
Stop using the 4th bit as the build. leave 4th bit always as 0 and start
using 3rd bit as the build.

examples:
24.0.1312.71 = bad
24.0.1315.0 = good
24.0.1423.0 = good
25.0.1364.97 = bad
25.0.1365.0 = good

Hopefully what I suggest makes sense.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #39 on issue 67348 by ed...@chromium.org: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Incorrect version number reported on Chrome M25 MSI when installed via GPO

Attachments:
Screenshot 2013-03-20 at 4.12.56 PM.png 8.2 KB

[chro...@googlecode.com]

Comment #40 on issue 67348 by Rob.Las...@gmail.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Problem still exists with Enterprise version 25.0.1364.172. This issue has
been opened since December of 2010. If I left a case open this long I
probably would have been fired. Please give a status on this issue. When
is this going to be resolved?

[chro...@googlecode.com]

Comment #41 on issue 67348 by cyr...@chromium.org: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Hi Robert - any update on this? This is coming up more and more now.

[chro...@googlecode.com]

Comment #46 on issue 67348 by c...@clausie.dk: MSI DisplayVersion to match
Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

This is almost funny...thread started in 2010!I guess administrators around
the world means nothing to Google :-|

[chro...@googlecode.com]

Comment #48 on issue 67348 by mnis...@chromium.org: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Issue 241345 has been merged into this issue.

[chro...@googlecode.com]

Comment #49 on issue 67348 by tr...@chromium.org: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

I have pushed a public service to produce an MSI version given a Chrome or
ChromeOS version#. This should help this a little. The page is here:
http://cros-omahaproxy.appspot.com/msiversions?version=29.0.1520.2

Pass a chromeos or chrome version as the version query parameter and the
resulting tuple shows: chrome_ver, chromeos_ver, msi_chrome_ver

[chro...@googlecode.com]

Comment #51 on issue 67348 by sam.gren...@gmail.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Now that I've finally decided to deploy Google Chrome to our company via
Group Policy I found out about this. Mainly because I too use Spiceworks
and noticed the MSI version was being displayed. So now what do I do to
detect the proper version of Chrome? Is there maybe a way to create
something in Spiceworks to detect a specific executable? Then it could get
the version from the chrome.exe which does show version 28.x (current
version)

[chro...@googlecode.com]

Comment #52 on issue 67348 by Rob.Las...@gmail.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

What is the status of this? When is this going to be resolved?

[chro...@googlecode.com]

Comment #53 on issue 67348 by Rob.Las...@gmail.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Checking status! We are already up to version 30.0.1599.101.

[chro...@googlecode.com]

Comment #55 on issue 67348 by christop...@gmail.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

If you read the NSA Hardening Guide for Chrome here
http://www.nsa.gov/ia/_files/app/Deploying_and_Securing_Google_Chrome_in_a_Windows_Enterprise.pdf
you'll find a powershell script for scanning your network for computers
running outdated versions of Google Chrome. I've modified it a bit to give
numbers on up-to-date, out-of-date, uncontactable etc.

[chro...@googlecode.com]

Comment #58 on issue 67348 by bar...@chromium.org: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Issue 354070 has been merged into this issue.

[chro...@googlecode.com]

Updates:
Cc: gwil...@chromium.org

Comment #59 on issue 67348 by mnis...@chromium.org: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Issue 58031 has been merged into this issue.

[chro...@googlecode.com]

Comment #60 on issue 67348 by rsfo...@gmail.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

Yeah when is this going to be resolved this is a HUGE issue with enterprise
deployments. The limitations stated are false within the Windows Installer
API, or the MSI container as I have built a number of WIX based MSI and I
have had no problem place four part versions into the MSI that align with
the version of the product they are installing. There is no reason for this
not to be fixed, especially if you are using WIX to create your MSI and not
sure why an open source project would use the official and free MSI tool
Microsoft created.

[chro...@googlecode.com]

Comment #64 on issue 67348 by adamsche...@gmail.com: MSI DisplayVersion to

match Chrome version
http://code.google.com/p/chromium/issues/detail?id=67348

add me as an interested party. This is a huge stumbling block for the
support organization at my (large) company. We almost exclusively let
Chrome autoupdate itself. When my support techs are troubleshooting, one of
the first things they do is look in ARP to compare their "version" number
to the user's "version" number to validate that everything is up-to-date.

I know, I know, bad practice as far as Chrome is concerned, but when
everything else operates in that model, it's hard to teach them to do
something different.

[chro...@googlecode.com]

Comment #68 on issue 67348 by arsch...@gmail.com: MSI DisplayVersion to
match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

This MSI version number thing is upsetting our internal app store owner's
code. Example: User (or IT) installed an older chrome msi, and the install
has (rightly) auto-updated to latest version of Chrome. We release a newer
msi (latest or almost-latest) to app store, it detects the older msi and
wants them to upgrade, even though user is on latest version of Chrome. In
essence, the user sees it as being told to "upgrade" to an older version of
Chrome, which doesn't make sense to them.

[chro...@googlecode.com]

Comment #69 on issue 67348 by arsch...@gmail.com: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

My app store owner mentioned "we support both cases of same GUID and
different version and different GUID". So simply updating the version would
be enough for us.

[chro...@googlecode.com]

Comment #70 on issue 67348 by arsch...@gmail.com: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

My app store owner mentioned "we support both cases of same GUID and

different version, and different GUID". So simply updating the version

[chro...@googlecode.com]

Updates:
Cc: to...@chromium.org

Comment #71 on issue 67348 by g...@chromium.org: MSI DisplayVersion to match
Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

Issue 429654 has been merged into this issue.

[chro...@googlecode.com]

Comment #74 on issue 67348 by c...@clausie.dk: MSI DisplayVersion to match
Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

Status is.....they don't give a damn! :-|

[chro...@googlecode.com]

Comment #75 on issue 67348 by eland...@appirio.com: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

Why not just add a letter or two at the end to show the difference between
the two editions?

Chrome MSI = Chrome 39.0.0.0 m msi

User Chrome = Chrome 39.0.0.0 m ue

[chro...@googlecode.com]

Comment #76 on issue 67348 by b...@eod.dk: MSI DisplayVersion to match
Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

I guess the reason Google doesn't care, is that only 43 people have starred
this issue. What Google apparently fails to realise is that the remaining
thousands of enterprise admins simply takes one glance at Chrome, finds
this glaring enterprise issues and drops it again.

[chro...@googlecode.com]

Comment #77 on issue 67348 by bin...@chromium.org: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

Issue 443214 has been merged into this issue.

[chro...@googlecode.com]

Comment #78 on issue 67348 by g...@chromium.org: MSI DisplayVersion to match

[chro...@googlecode.com]

Comment #79 on issue 67348 by Rob.Las...@gmail.com: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

status!?

[chro...@googlecode.com]

Comment #81 on issue 67348 by bugd...@chromium.org: MSI DisplayVersion to
match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348#c81

The following revision refers to this bug:

https://chrome-internal.googlesource.com/infra/infra_internal.git/+/e0af06b5e58d482ebb3bd17d5536aecaa57be098

commit e0af06b5e58d482ebb3bd17d5536aecaa57be098
Author: tr...@google.com
<tr...@google.com@72b347f9-1636-4932-8204-c47f5100e119>
Date: Mon Jun 03 16:24:02 2013

[chro...@googlecode.com]

Comment #82 on issue 67348 by ssimp...@baltometro.org: MSI DisplayVersion

to match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

bugdroid's posting contains a link that appears to go somewhere internal to
Google.

So most people (e.g. myself) won't have access to the link's target, and
can't verify that it actually pertains to this issue.

[chro...@googlecode.com]

Comment #88 on issue 67348 by b...@eod.dk: MSI DisplayVersion to match
Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

But why change the ProductVersion property to another, just as incorrect,
version?

I'm guessing it's because you want to be able to do some sort of version
matching with your software deployment systems (SCCM). If that's the case,
then you could just as easily add a single registry key to either the MSI
(perhaps using an MST), or simply create a small script that starts the
installer, then adds a registry key, which shows the correct chrome
version, which you can then query. F.ex:
@echo off
MsiExec /I GoogleChromeStandaloneEnterprise_x32_66.77.16508_43.0.2357.124 /Q
REG ADD HKLM\SOFTWARE\Google\Chrome /t REG_SZ /v RealVersion /d
43.0.2357.124

If the ProductVersion should change in any way from the current, then it
should change in order to have the correct Chrome version. Anything else
doesn't make much sense, as you'd still have to concoct your own way of
interpreting the version for your system (hence the small install example
above).

[chro...@googlecode.com]

Comment #89 on issue 67348 by gappelst...@gmail.com: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

@ #88:

I want to do version matching with our software deployment system.

Your 'solution' does not work. Let's say I install the MSI version of
Chrome and also make it add the version number somewhere in the registry...
Three months later, Chrome has already auto-updated itself 5 times.
However, the version number of the MSI and the version number in the
registry are still the same.

So, I have NO way to know what version of Chrome is actually installed on a
machine.

[chro...@googlecode.com]

Comment #90 on issue 67348 by b...@eod.dk: MSI DisplayVersion to match
Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

@ #89:

Fair enough. Things you mention can be worked around though, depending on
your software deployment system. The closest thing you get to your wanted
scenario today, is to use the Chrome StandAlone version rather than the
Enterprise MSI version. The StandAlone version will show its proper version
in the uninstall section. Alternatively, you can inventory the chrome.exe
file, which will also show the proper version.

My point is that Google should not invent yet another way to display a
wrong version in the uninstall section. They should just get around to
actually show the correct version regardless of the installer used.

[chro...@googlecode.com]

Updates:
Owner: bcwh...@chromium.org

Comment #91 on issue 67348 by bcwh...@chromium.org: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

See also: https://b/22424108 (internal only)

[chro...@googlecode.com]

Comment #93 on issue 67348 by bugd...@chromium.org: MSI DisplayVersion to
match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348#c93

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/0d3e644a25802bdb3afa7fc09eff5aab456c5733

commit 0d3e644a25802bdb3afa7fc09eff5aab456c5733
Author: bcwhite <bcw...@chromium.org>
Date: Mon Sep 14 04:44:24 2015

Add options to write version number to registry.

The MSI installer creates a DisplayVersion registry entry
with an encoded version of Chrome's actual version. Since
this is done _after_ the setup call completes, we can't
simply set the value in the normal setup process. Instead,
we launch a background process that waits a while (for
msiexec to complete) and then writes the updated version.

This is accomplished by having setup, upon successful completion,
run itself in the background and then exit normally.

--set-display-version-path="SOFTWARE\...\InstallProperties"
--set-display-version-value="A.B.C.D"
--delay=30

BUG=67348

Review URL: https://codereview.chromium.org/1271893003

Cr-Commit-Position: refs/heads/master@{#348556}

[modify]
http://crrev.com/0d3e644a25802bdb3afa7fc09eff5aab456c5733/chrome/installer/setup/setup_constants.cc
[modify]
http://crrev.com/0d3e644a25802bdb3afa7fc09eff5aab456c5733/chrome/installer/setup/setup_constants.h
[modify]
http://crrev.com/0d3e644a25802bdb3afa7fc09eff5aab456c5733/chrome/installer/setup/setup_main.cc
[modify]
http://crrev.com/0d3e644a25802bdb3afa7fc09eff5aab456c5733/chrome/installer/setup/setup_util.cc
[modify]
http://crrev.com/0d3e644a25802bdb3afa7fc09eff5aab456c5733/chrome/installer/setup/setup_util.h
[modify]
http://crrev.com/0d3e644a25802bdb3afa7fc09eff5aab456c5733/chrome/installer/setup/setup_util_unittest.cc
[modify]
http://crrev.com/0d3e644a25802bdb3afa7fc09eff5aab456c5733/chrome/installer/util/master_preferences_constants.cc
[modify]
http://crrev.com/0d3e644a25802bdb3afa7fc09eff5aab456c5733/chrome/installer/util/master_preferences_constants.h

[chro...@googlecode.com]

Comment #95 on issue 67348 by bugd...@chromium.org: MSI DisplayVersion to
match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348#c95

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/30198c1e69bc8c91e4e0853fa399702b8bddb302

commit 30198c1e69bc8c91e4e0853fa399702b8bddb302
Author: bcwhite <bcw...@chromium.org>
Date: Mon Sep 14 21:56:09 2015

Add options to write version number to registry.

The MSI installer creates a DisplayVersion registry entry
with an encoded version of Chrome's actual version. Since
this is done _after_ the setup call completes, we can't
simply set the value in the normal setup process. Instead,
we launch a background process that waits a while (for
msiexec to complete) and then writes the updated version.

This is accomplished by having setup, upon successful completion,
run itself in the background and then exit normally.

--set-display-version-product="ABCD-EF-GH-IJKL"
--set-display-version-value="A.B.C.D"
--delay=30

BUG=67348

Committed: https://crrev.com/0d3e644a25802bdb3afa7fc09eff5aab456c5733
Cr-Commit-Position: refs/heads/master@{#348556}

Review URL: https://codereview.chromium.org/1271893003

Cr-Commit-Position: refs/heads/master@{#348732}

[modify]
http://crrev.com/30198c1e69bc8c91e4e0853fa399702b8bddb302/chrome/installer/setup/setup_constants.cc
[modify]
http://crrev.com/30198c1e69bc8c91e4e0853fa399702b8bddb302/chrome/installer/setup/setup_constants.h
[modify]
http://crrev.com/30198c1e69bc8c91e4e0853fa399702b8bddb302/chrome/installer/setup/setup_main.cc
[modify]
http://crrev.com/30198c1e69bc8c91e4e0853fa399702b8bddb302/chrome/installer/setup/setup_util.cc
[modify]
http://crrev.com/30198c1e69bc8c91e4e0853fa399702b8bddb302/chrome/installer/setup/setup_util.h
[modify]
http://crrev.com/30198c1e69bc8c91e4e0853fa399702b8bddb302/chrome/installer/setup/setup_util_unittest.cc
[modify]
http://crrev.com/30198c1e69bc8c91e4e0853fa399702b8bddb302/chrome/installer/util/master_preferences_constants.cc
[modify]
http://crrev.com/30198c1e69bc8c91e4e0853fa399702b8bddb302/chrome/installer/util/master_preferences_constants.h

[chro...@googlecode.com]

Comment #97 on issue 67348 by sas...@chromium.org: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

Hi Rob, Eric, others on this thread

Would really appreciate if you guys could test this out in your
environment. Many of you have felt the pain for over 4 years. We are very
close to solving this. But we do need the confidence that is working well
and has no regressions.

Many thanks

[chro...@googlecode.com]

Comment #101 on issue 67348 by ssimp...@baltometro.org: MSI DisplayVersion

to match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

If you click on the link below and then try to go to any of the dev-channel
links, you just the main (stable channel) Chrome download page,

(The Beta and Canary channel links go to pages that identify themselves as
such.)

Since the URL had "extra=devchannel" in it, I clicked on the Download button
but got an online installer rather than an MSI.

Is there any way to directly get an MSI?

Spencer
(Confidentiality statements appearing elsewhere in this message apply to the
entire message)

[chro...@googlecode.com]

Comment #102 on issue 67348 by bcwh...@chromium.org: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

Here is an older CANARY version with the change to set DisplayVersion.
Available on Drive are two canary versions of Chrome:

Without Change: (old "66" version number)
https://drive.google.com/open?id=0B9nbVwtdJ_FpbGZER1FBUDRRWHc

With Change: (new "47" version number)
https://drive.google.com/open?id=0B9nbVwtdJ_FpR0F1TUE2MXo1Z1U

They're one day apart so differences should be minimal but be aware that
even though these are canary builds, the .msi will install them as stable
which will then not auto-update until the real stable becomes newer than
this canary. I recommend a VM or at least fully uninstall after trying.

The way the change works is to wait 10 seconds after install (for msiexec
to finish all its work) and then overwrite the DisplayVersion registry
entry for both "Install" and "Uninstall". The control panel (which reads
from Uninstall) now shows the correct Chrome version in my tests.

[chro...@googlecode.com]

Updates:
Status: Started

Comment #104 on issue 67348 by bcwh...@chromium.org: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

Auto-updates of Chrome should update the version number so long as
the "master_preferences" file is not altered so as to remove the registry
key used to find those values.

Existing MSI installs won't have set that key and so won't get the elements
updated -- that seemed the safest first step and insures that
no "downgrades" (i.e. v66 to v47) happen unexpectedly. Any thoughts about
making it happen even on existing MSI installs (if feasible)?

[chro...@googlecode.com]

Updates:
Labels: -Merge-Review-46 Merge-Approved-46

Comment #107 on issue 67348 by tin...@google.com: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

Merge approved for M46 branch (branch: 2490).

[chro...@googlecode.com]

Comment #110 on issue 67348 by john.reh...@gmail.com: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

As an admin, i would vote in favour of the change to make the version
consistant with the v4x.y.z.
I use a few different methods to inventory my software and do remote
installs for security patching and general updating and having to keep
track of different installs for users v enterprise install and the version
differences leads to complications. If a blog post is announced with enough
notice to allow admins to modify their rule sets for version spotting this
should cover the issue. Eventually if a base level is set the numbers will
sync up anyway with those that might have missed it and the issue has been
prevailant long enough that those that are concerned with the version
differences should be able to find this issue tracker.

[chro...@googlecode.com]

Comment #113 on issue 67348 by bugd...@chromium.org: MSI DisplayVersion
to match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348#c113

The following revision refers to this bug:

https://chrome-internal.googlesource.com/bling/chromium.git/+/ec60bc045652510c903768d268c58071a4197131

commit ec60bc045652510c903768d268c58071a4197131
Author: Brian White <bcw...@chromium.org>
Date: Tue Oct 06 00:25:35 2015

[chro...@googlecode.com]

Comment #114 on issue 67348 by sas...@chromium.org: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

Thanks Brian on the merge.

Folks following this bug, what #112 means is that when Chrome 46 hits
stable in the next few weeks, all *new* MSI installs will already benefit
from this change the version number will match.

For existing installs that upgrade, there will still be this mismatch in
Chrome 46, but we are working towards M47 to have the fix so that after
that update old installs that have updated to 47 will also show the
matching version. M47 is expected to be in Stable channel around December.

[chro...@googlecode.com]

Comment #115 on issue 67348 by bugd...@chromium.org: MSI DisplayVersion
to match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348#c115

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/fe3fb71878ba25c963b6a3259ba948bdc828e44a

commit fe3fb71878ba25c963b6a3259ba948bdc828e44a
Author: bcwhite <bcw...@chromium.org>
Date: Sat Oct 10 03:02:50 2015

Handle upgrade case from previous MSI install.

An MSI install leaves behind a master_preferences file. Use that
information to update version numbers when auto-updates are installed.

BUG=67348

Review URL: https://codereview.chromium.org/1351453006

Cr-Commit-Position: refs/heads/master@{#353459}

[modify]
http://crrev.com/fe3fb71878ba25c963b6a3259ba948bdc828e44a/chrome/installer/setup/setup_main.cc

[chro...@googlecode.com]

Updates:
Labels: -Merge-Approved-47 merge-merged-2526

Comment #118 on issue 67348 by bugd...@chromium.org: MSI DisplayVersion
to match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348#c118

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/39cee1eff5a8c3bacd4be18f0562fe464bc8d4dd

commit 39cee1eff5a8c3bacd4be18f0562fe464bc8d4dd
Author: Brian White <bcw...@chromium.org>
Date: Thu Oct 15 19:20:51 2015

Handle upgrade case from previous MSI install.

An MSI install leaves behind a master_preferences file. Use that
information to update version numbers when auto-updates are installed.

BUG=67348

TBR=tin...@chromium.org

Review URL: https://codereview.chromium.org/1351453006

Cr-Commit-Position: refs/heads/master@{#353459}

(cherry picked from commit fe3fb71878ba25c963b6a3259ba948bdc828e44a)

Review URL: https://codereview.chromium.org/1410563002 .

Cr-Commit-Position: refs/branch-heads/2526@{#132}
Cr-Branched-From:
cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}

[modify]
http://crrev.com/39cee1eff5a8c3bacd4be18f0562fe464bc8d4dd/chrome/installer/setup/setup_main.cc

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #119 on issue 67348 by bcwh...@chromium.org: MSI DisplayVersion to

match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #120 on issue 67348 by bugd...@chromium.org: MSI DisplayVersion
to match Chrome version
https://code.google.com/p/chromium/issues/detail?id=67348#c120

The following revision refers to this bug:

https://chrome-internal.googlesource.com/bling/chromium.git/+/39cee1eff5a8c3bacd4be18f0562fe464bc8d4dd

commit 39cee1eff5a8c3bacd4be18f0562fe464bc8d4dd
Author: Brian White <bcw...@chromium.org>
Date: Thu Oct 15 19:20:51 2015