Re: Issue 532745 in chromium: Stagefright Mitigation: Reduce brute force ASLR attacks against mediaserver process

16 views
Skip to first unread message

chro...@googlecode.com

unread,
Sep 30, 2015, 6:57:23 PM9/30/15
to chromi...@chromium.org

Comment #10 on issue 532745 by qin...@chromium.org: Stagefright Mitigation:
Reduce brute force ASLR attacks against mediaserver process
https://code.google.com/p/chromium/issues/detail?id=532745

ok, will do

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

chro...@googlecode.com

unread,
Sep 30, 2015, 7:56:22 PM9/30/15
to chromi...@chromium.org

Comment #11 on issue 532745 by qin...@chromium.org: Stagefright Mitigation:
Reduce brute force ASLR attacks against mediaserver process
https://code.google.com/p/chromium/issues/detail?id=532745

This is new infobar that makes the block option default

Attachments:
device-2015-09-30-162938.png 44.9 KB

chro...@googlecode.com

unread,
Sep 30, 2015, 11:44:47 PM9/30/15
to chromi...@chromium.org
Updates:
Cc: f...@chromium.org

Comment #12 on issue 532745 by aa...@google.com: Stagefright Mitigation:
Reduce brute force ASLR attacks against mediaserver process
https://code.google.com/p/chromium/issues/detail?id=532745

(No comment was entered for this change.)

chro...@googlecode.com

unread,
Oct 1, 2015, 11:56:57 AM10/1/15
to chromi...@chromium.org
Updates:
Cc: e...@chromium.org

Comment #13 on issue 532745 by f...@chromium.org: Stagefright Mitigation:
Reduce brute force ASLR attacks against mediaserver process
https://code.google.com/p/chromium/issues/detail?id=532745

Why show an infobar at all? Why not just block it? If it has crashed
several times, is retrying likely to help in the "good" case?

chro...@googlecode.com

unread,
Oct 6, 2015, 8:45:45 PM10/6/15
to chromi...@chromium.org
Updates:
Cc: -r...@chromium.org

Comment #18 on issue 532745 by ro...@chromium.org: Stagefright Mitigation:
Reduce brute force ASLR attacks against mediaserver process
https://code.google.com/p/chromium/issues/detail?id=532745

Approved string from UI Review:
Android is having trouble playing media.
[ wait ] [ try again ]

dfalacantara@ would say we need to add an icon to this info bar to make
them consistent with others. You can use the warning one:
https://drive.google.com/a/google.com/folderview?id=0B6x6iYCtKinEYnNVbjZPSVMwbUE&usp=sharing

But this is not a blocker to merge to M46.

qinmin@ - would be good to know too when you're past the push to get this
out if we need to update the text for desktop.

chro...@googlecode.com

unread,
Oct 6, 2015, 9:58:49 PM10/6/15
to chromi...@chromium.org

Comment #19 on issue 532745 by bugd...@chromium.org: Stagefright
Mitigation: Reduce brute force ASLR attacks against mediaserver process
https://code.google.com/p/chromium/issues/detail?id=532745#c19

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c

commit b2341d25796fe6f94fb9a2d00104f2f88ca67a7c
Author: qinmin <qin...@chromium.org>
Date: Wed Oct 07 01:41:50 2015

Throttle media decoding after excessive Android media server crashes

This change adds a watch dog player to listen to android MediaServer
crashes.
When the number of crashes reaches a certain threshold,
all media decoding using Android MediaPlayer/MediaCodec will be throttled.
This will throttle both media and webaudio implementation.

BUG=532745

Review URL: https://codereview.chromium.org/1372203002

Cr-Commit-Position: refs/heads/master@{#352740}

[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/chrome/app/generated_resources.grd
[add]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/chrome/browser/android/media/media_throttle_infobar_delegate.cc
[add]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/chrome/browser/android/media/media_throttle_infobar_delegate.h
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/chrome/browser/android/tab_web_contents_delegate_android.h
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/chrome/chrome_browser.gypi
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/components/infobars/core/infobar_delegate.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/components/infobars/core/infobar_delegate.h
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/content/browser/media/android/browser_media_player_manager.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/content/browser/media/android/browser_media_player_manager.h
[add]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/content/browser/media/android/media_throttler.cc
[add]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/content/browser/media/android/media_throttler.h
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/content/browser/renderer_host/render_message_filter.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/content/content_browser.gypi
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/content/content_jni.gypi
[add]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/content/public/android/java/res/raw/empty.wav
[add]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/content/public/android/java/src/org/chromium/content/browser/MediaThrottler.java
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/content/public/browser/web_contents_delegate.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/content/public/browser/web_contents_delegate.h
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/java/src/org/chromium/media/MediaPlayerListener.java
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/media_codec_decoder_unittest.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/media_codec_player.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/media_codec_player.h
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/media_codec_video_decoder.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/media_codec_video_decoder.h
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/media_player_android.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/media_player_android.h
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/media_player_bridge.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/media_player_bridge.h
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/media_source_player.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/media_source_player.h
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/media_source_player_unittest.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/video_decoder_job.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/video_decoder_job.h
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/webaudio_media_codec_bridge.cc
[modify]
http://crrev.com/b2341d25796fe6f94fb9a2d00104f2f88ca67a7c/media/base/android/webaudio_media_codec_bridge.h

chro...@googlecode.com

unread,
Oct 6, 2015, 10:02:50 PM10/6/15
to chromi...@chromium.org
Updates:
Labels: -M-46 M-47 ReleaseBlock-Stable

Comment #20 on issue 532745 by ke...@google.com: Stagefright Mitigation:
Reduce brute force ASLR attacks against mediaserver process
https://code.google.com/p/chromium/issues/detail?id=532745

There's no way this can go into 46 at this point. Come find me if you want
to discuss otherwise.

chro...@googlecode.com

unread,
Oct 8, 2015, 3:32:04 PM10/8/15
to chromi...@chromium.org
Updates:
Labels: Merge-Request-47

Comment #21 on issue 532745 by qin...@chromium.org: Stagefright Mitigation:
Reduce brute force ASLR attacks against mediaserver process
https://code.google.com/p/chromium/issues/detail?id=532745

(No comment was entered for this change.)

chro...@googlecode.com

unread,
Oct 8, 2015, 3:39:04 PM10/8/15
to chromi...@chromium.org
Updates:
Labels: -Merge-Request-47 Merge-Approved-47 Hotlist-Merge-Approved

Comment #22 on issue 532745 by tin...@google.com: Stagefright Mitigation:
Reduce brute force ASLR attacks against mediaserver process
https://code.google.com/p/chromium/issues/detail?id=532745#c22

Approved for M47 (branch: 2526)

chro...@googlecode.com

unread,
Oct 8, 2015, 9:25:10 PM10/8/15
to chromi...@chromium.org

Comment #23 on issue 532745 by bugd...@chromium.org: Stagefright
Mitigation: Reduce brute force ASLR attacks against mediaserver process
https://code.google.com/p/chromium/issues/detail?id=532745#c23

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/bd8f5de058d1d59c780df4663fd86a9b7ab3ab00

commit bd8f5de058d1d59c780df4663fd86a9b7ab3ab00
Author: qinmin <qin...@chromium.org>
Date: Fri Oct 09 00:13:26 2015

Add warning icon to media throttle info bar to make it consistent with
others

As suggested in the crbug.

BUG=532745

Review URL: https://codereview.chromium.org/1392913003

Cr-Commit-Position: refs/heads/master@{#353179}

[modify]
http://crrev.com/bd8f5de058d1d59c780df4663fd86a9b7ab3ab00/chrome/browser/android/media/media_throttle_infobar_delegate.cc
[modify]
http://crrev.com/bd8f5de058d1d59c780df4663fd86a9b7ab3ab00/chrome/browser/android/media/media_throttle_infobar_delegate.h

chro...@googlecode.com

unread,
Jan 22, 2016, 9:10:49 PM1/22/16
to chromi...@chromium.org
Updates:
Cc: s...@google.com

Comment #32 on issue 532745 by w...@chromium.org: Stagefright Mitigation:
Reduce brute force ASLR attacks against mediaserver process
https://code.google.com/p/chromium/issues/detail?id=532745

(No comment was entered for this change.)

Reply all
Reply to author
Forward
0 new messages