Re: Issue 543674 in chromium: MacViews: Wrong folder icon in tree views

[chro...@googlecode.com]

Updates:
Owner: karande...@chromium.org

Comment #2 on issue 543674 by tap...@chromium.org: MacViews: Wrong folder
icon in tree views
https://code.google.com/p/chromium/issues/detail?id=543674

These are resources, IDR_FOLDER_CLOSED_RTL, IDR_FOLDER_CLOSED,
IDR_FOLDER_OPEN_RTL, IDR_FOLDER_OPEN in
ui/views/resources/views_resources.grd.

One approach is to just provide different files on Mac (maybe there are
some already in use elsewhere in Cocoa that are the right things).

Another approach is to hook in "somehwere" and provide assets in
tree_view.cc by going through +[NSImage NSImageNamed:]

Yet another option is to implement assets from scratch as vector icons,
since most of Chrome is going that way already.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #3 on issue 543674 by tap...@chromium.org: MacViews: Wrong folder

icon in tree views
https://code.google.com/p/chromium/issues/detail?id=543674

RTL folders in Safai for comparison

Attachments:
Screen Shot 2016-01-18 at 3.02.20 אח׳.png 61.9 KB

[chro...@googlecode.com]

Updates:
Status: Started

Comment #4 on issue 543674 by karande...@chromium.org: MacViews: Wrong

folder icon in tree views
https://code.google.com/p/chromium/issues/detail?id=543674

Edit Bookmark Dialog with Mac style Folder icons. The 16X16 image looks
clearer in my opinion.

Attachments:
16X16.png 22.6 KB
19X18.png 24.4 KB

[chro...@googlecode.com]

Comment #5 on issue 543674 by bugd...@chromium.org: MacViews: Wrong

folder icon in tree views

https://code.google.com/p/chromium/issues/detail?id=543674#c5

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/e60fc3cf40cbc732e5ccaf6ff3785cc1351fbe03

commit e60fc3cf40cbc732e5ccaf6ff3785cc1351fbe03
Author: karandeepb <karan...@chromium.org>
Date: Thu Jan 21 23:22:42 2016

MacViews: Use Cocoa folder icons in tree views.

Chrome's Cocoa UI retrieves some image assets from the System using APIs
such
as +[NSImage imageNamed:key]. To support this under toolkit-views, provide a
ui::ResourceDelegate on Mac that can transparently map some IDR_ resource
IDs
to a system-provided asset. Initially do this for folder icons in
views::TreeView to provide a folder icon that is consistent with the running
OSX version.

The following resource ids are currently intercepted - IDR_FOLDER_OPEN,
IDR_FOLDER_CLOSED, IDR_FOLDER_OPEN_RTL and IDR_FOLDER_CLOSED_RTL. Although
IDR_FOLDER_CLOSED is in ui/resources (and not ui/views/resources), it is
currently unused on Mac (chrome://syncfs-internals/ refers to it in its CSS,
but doesn't actually use that style anywhere in its html or js). Hence this
CL, does not alter any icons on Chrome Mac, except under Views.

BUG=543674

Review URL: https://codereview.chromium.org/1585013002

Cr-Commit-Position: refs/heads/master@{#370819}

[modify]
http://crrev.com/e60fc3cf40cbc732e5ccaf6ff3785cc1351fbe03/chrome/browser/chrome_browser_main_mac.h
[modify]
http://crrev.com/e60fc3cf40cbc732e5ccaf6ff3785cc1351fbe03/chrome/browser/chrome_browser_main_mac.mm
[add]
http://crrev.com/e60fc3cf40cbc732e5ccaf6ff3785cc1351fbe03/chrome/browser/resource_delegate_mac.h
[add]
http://crrev.com/e60fc3cf40cbc732e5ccaf6ff3785cc1351fbe03/chrome/browser/resource_delegate_mac.mm
[modify]
http://crrev.com/e60fc3cf40cbc732e5ccaf6ff3785cc1351fbe03/chrome/chrome_browser.gypi

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #6 on issue 543674 by karande...@chromium.org: MacViews: Wrong

folder icon in tree views
https://code.google.com/p/chromium/issues/detail?id=543674

(No comment was entered for this change.)