Issue 229402 in chromium: Another popunder scheme

[chro...@googlecode.com]

Status: Unconfirmed
Owner: ----
Labels: Pri-2 Via-Wizard Type-Compat OS-Windows

New issue 229402 by phistuck: Another popunder scheme
http://code.google.com/p/chromium/issues/detail?id=229402

UserAgent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.31 (KHTML, like
Gecko) Chrome/26.0.1410.43 Safari/537.31

Example URL:

Steps to reproduce the problem:
1. Open the attached reduced test case.
2. Click anywhere.

What is the expected behavior?
A popup window.

What went wrong?
A popunder window.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No

Did this work before? N/A

Does this work in other browsers? N/A

Chrome version: 26.0.1410.43 Channel: stable
OS Version: 5.1 (Windows XP)

The differentiating factor here is the "true" that sets the Control key as
pressed (the tenth parameter of initMouseEvent). Perhaps the Meta key is
for Macintosh or something. On Windows, it works with the first ten
parameters.
Replacing event.initMouseEvent with the following also works -
event = new MouseEvent("click", {ctrlKey: true});

Once this is fixed, please, merge into any current stable and beta release.

Attachments:
popunder.html 843 bytes

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Updates:
Status: Untriaged
Cc: joc...@chromium.org aba...@chromium.org
Labels: -Type-Compat Type-Bug Cr-Blink

Comment #1 on issue 229402 by phist...@chromium.org: Another popunder scheme
http://code.google.com/p/chromium/issues/detail?id=229402

Jochen, since you took the last one - care to take this one, too? :)

[chro...@googlecode.com]

Updates:
Status: Started
Owner: joc...@chromium.org
Labels: -OS-Windows -Cr-Blink OS-All

Comment #2 on issue 229402 by joc...@chromium.org: Another popunder scheme
http://code.google.com/p/chromium/issues/detail?id=229402

uh, I thought I already had that one fixed, but it turns out our popup
blocker needs to be adopted a bit.

[chro...@googlecode.com]

Updates:
Cc: cev...@chromium.org b...@chromium.org
Labels: Cr-UI-Browser-PopupBlocker Cr-Security Security_Severity-Low

Comment #3 on issue 229402 by joc...@chromium.org: Another popunder scheme
http://code.google.com/p/chromium/issues/detail?id=229402

add security labels because it bypasses the popup blocker.

Chris, the webkit side of this which I landed last week relies on popup
blocking being enabled in WebKit. In chrome, however, we do the popup
blocking browser side. Since in this case the new windows are opened as
background tab, our (browser side) popup blocker just lets them pass :-/

Posted a fix here: https://codereview.chromium.org/13874004/

[chro...@googlecode.com]

Updates:
Labels: M-27 Merge-Requested

Comment #5 on issue 229402 by joc...@chromium.org: Another popunder scheme
http://code.google.com/p/chromium/issues/detail?id=229402

Can we merge this back to M27 or so?

[chro...@googlecode.com]

Comment #6 on issue 229402 by kar...@google.com: Another popunder scheme
http://code.google.com/p/chromium/issues/detail?id=229402

can this wait till 28?
27 has too many merges
we'r trying to keep volume down. is this a m27 regression?

[chro...@googlecode.com]

Comment #7 on issue 229402 by kar...@google.com: Another popunder scheme
http://code.google.com/p/chromium/issues/detail?id=229402

do we need to merge to m27? can it wait till 28?