Issue 131586 in chromium: 2x resources should be exactly twice the size of 1x resources.

chro...@googlecode.com

unread,

Jun 7, 2012, 11:52:17 AM6/7/12

to chromi...@chromium.org

Status: Assigned
Owner: r...@chromium.org
CC: rby...@chromium.org
Labels: Type-Bug Pri-2 Area-UI

New issue 131586 by fla...@chromium.org: 2x resources should be exactly
twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

I have written a script to find every case where we have a separate 2x
resource file that is not twice the size of the 1x file. These are
currently blocking enabling the loading of 2x resources in ChromeOS as when
we scale them to the 2x size they look quite bad not being scaled by
exactly 2.

Comparing images from chrome/app/theme/theme_resources_standard.grd to
chrome/app/theme/theme_resources_2x.grd:
IDR_CONTENT_TOP_CENTER:
chrome/app/theme/default_100_percent/content_top_center.png (1x) is 1x38,
chrome/app/theme/default_200_percent/content_top_center.png (2x) is 1x64
should be 2x76.
IDR_CONTENT_TOP_LEFT_CORNER:
chrome/app/theme/default_100_percent/content_top_left_corner.png (1x) is
6x37, chrome/app/theme/default_200_percent/content_top_left_corner.png (2x)
is 6x64 should be 12x74.
IDR_CONTENT_TOP_LEFT_CORNER_MASK:
chrome/app/theme/default_100_percent/content_top_left_corner_mask.png (1x)
is 6x37,
chrome/app/theme/default_200_percent/content_top_left_corner_mask.png (2x)
is 6x64 should be 12x74.
IDR_CONTENT_TOP_RIGHT_CORNER:
chrome/app/theme/default_100_percent/content_top_right_corner.png (1x) is
6x37, chrome/app/theme/default_200_percent/content_top_right_corner.png
(2x) is 6x64 should be 12x74.
IDR_CONTENT_TOP_RIGHT_CORNER_MASK:
chrome/app/theme/default_100_percent/content_top_right_corner_mask.png (1x)
is 6x38,
chrome/app/theme/default_200_percent/content_top_right_corner_mask.png (2x)
is 6x64 should be 12x76.
IDR_STOP_D: chrome/app/theme/default_100_percent/stop_disabled.png (1x) is
27x29, chrome/app/theme/default_200_percent/stop_disabled.png (2x) is 55x59
should be 54x58.
IDR_TAB_ACTIVE_CENTER:
chrome/app/theme/default_100_percent/tab_active_center.png (1x) is 1x27,
chrome/app/theme/default_200_percent/tab_active_center.png (2x) is 1x40
should be 2x54.
IDR_TAB_ACTIVE_LEFT:
chrome/app/theme/default_100_percent/tab_active_left.png (1x) is 15x27,
chrome/app/theme/default_200_percent/tab_active_left.png (2x) is 15x40
should be 30x54.
IDR_TAB_ACTIVE_RIGHT:
chrome/app/theme/default_100_percent/tab_active_right.png (1x) is 15x27,
chrome/app/theme/default_200_percent/tab_active_right.png (2x) is 15x40
should be 30x54.
IDR_TAB_ALPHA_LEFT: chrome/app/theme/default_100_percent/tab_alpha_left.png
(1x) is 15x27, chrome/app/theme/default_200_percent/tab_alpha_left.png (2x)
is 15x40 should be 30x54.
IDR_TAB_ALPHA_RIGHT:
chrome/app/theme/default_100_percent/tab_alpha_right.png (1x) is 15x27,
chrome/app/theme/default_200_percent/tab_alpha_right.png (2x) is 15x40
should be 30x54.
IDR_TAB_CLOSE: chrome/app/theme/default_100_percent/tab_close.png (1x) is
12x12, chrome/app/theme/default_200_percent/tab_close.png (2x) is 29x29
should be 24x24.
IDR_TAB_CLOSE_H: chrome/app/theme/default_100_percent/tab_close_hover.png
(1x) is 12x12, chrome/app/theme/default_200_percent/tab_close_hover.png
(2x) is 29x29 should be 24x24.
IDR_TAB_CLOSE_MASK: chrome/app/theme/default_100_percent/tab_close_mask.png
(1x) is 12x12, chrome/app/theme/default_200_percent/tab_close_mask.png (2x)
is 29x29 should be 24x24.
IDR_TAB_CLOSE_P: chrome/app/theme/default_100_percent/tab_close_pressed.png
(1x) is 12x12, chrome/app/theme/default_200_percent/tab_close_pressed.png
(2x) is 29x29 should be 24x24.
IDR_TAB_INACTIVE_CENTER:
chrome/app/theme/default_100_percent/tab_inactive_center.png (1x) is 32x27,
chrome/app/theme/default_200_percent/tab_inactive_center.png (2x) is 1x40
should be 64x54.
IDR_TAB_INACTIVE_LEFT:
chrome/app/theme/default_100_percent/tab_inactive_left.png (1x) is 15x27,
chrome/app/theme/default_200_percent/tab_inactive_left.png (2x) is 15x40
should be 30x54.
IDR_TAB_INACTIVE_RIGHT:
chrome/app/theme/default_100_percent/tab_inactive_right.png (1x) is 15x27,
chrome/app/theme/default_200_percent/tab_inactive_right.png (2x) is 15x40
should be 30x54.

Comparing images from chrome/app/theme/theme_resources_touch_1x.grd to
chrome/app/theme/theme_resources_touch_2x.grd:
IDR_BACK: chrome/app/theme/touch_100_percent/browser_back_normal.png (1x)
is 35x35, chrome/app/theme/touch_200_percent/browser_back_normal.png (2x)
is 58x58 should be 70x70.
IDR_BACK_D: chrome/app/theme/touch_100_percent/browser_back_disabled.png
(1x) is 35x35, chrome/app/theme/touch_200_percent/browser_back_disabled.png
(2x) is 58x58 should be 70x70.
IDR_BACK_H: chrome/app/theme/touch_100_percent/browser_back_hover.png (1x)
is 35x35, chrome/app/theme/touch_200_percent/browser_back_hover.png (2x) is
58x58 should be 70x70.
IDR_BACK_P: chrome/app/theme/touch_100_percent/browser_back_pressed.png
(1x) is 35x35, chrome/app/theme/touch_200_percent/browser_back_pressed.png
(2x) is 58x58 should be 70x70.
IDR_BROWSER_ACTION:
chrome/app/theme/touch_100_percent/browser_action_normal.png (1x) is 35x35,
chrome/app/theme/touch_200_percent/browser_action_normal.png (2x) is 58x58
should be 70x70.
IDR_BROWSER_ACTION_H:
chrome/app/theme/touch_100_percent/browser_action_hover.png (1x) is 35x35,
chrome/app/theme/touch_200_percent/browser_action_hover.png (2x) is 58x58
should be 70x70.
IDR_BROWSER_ACTION_P:
chrome/app/theme/touch_100_percent/browser_action_pressed.png (1x) is
35x35, chrome/app/theme/touch_200_percent/browser_action_pressed.png (2x)
is 58x58 should be 70x70.
IDR_BROWSER_ACTIONS_OVERFLOW:
chrome/app/theme/touch_100_percent/browser_actions_overflow_normal.png (1x)
is 24x35,
chrome/app/theme/touch_200_percent/browser_actions_overflow_normal.png (2x)
is 40x58 should be 48x70.
IDR_BROWSER_ACTIONS_OVERFLOW_H:
chrome/app/theme/touch_100_percent/browser_actions_overflow_hover.png (1x)
is 24x35,
chrome/app/theme/touch_200_percent/browser_actions_overflow_hover.png (2x)
is 40x58 should be 48x70.
IDR_BROWSER_ACTIONS_OVERFLOW_P:
chrome/app/theme/touch_100_percent/browser_actions_overflow_pressed.png
(1x) is 24x35,
chrome/app/theme/touch_200_percent/browser_actions_overflow_pressed.png
(2x) is 40x58 should be 48x70.
IDR_FORWARD: chrome/app/theme/touch_100_percent/browser_forward_normal.png
(1x) is 35x35,
chrome/app/theme/touch_200_percent/browser_forward_normal.png (2x) is 58x58
should be 70x70.
IDR_FORWARD_D:
chrome/app/theme/touch_100_percent/browser_forward_disabled.png (1x) is
35x35, chrome/app/theme/touch_200_percent/browser_forward_disabled.png (2x)
is 58x58 should be 70x70.
IDR_FORWARD_H: chrome/app/theme/touch_100_percent/browser_forward_hover.png
(1x) is 35x35, chrome/app/theme/touch_200_percent/browser_forward_hover.png
(2x) is 58x58 should be 70x70.
IDR_FORWARD_P:
chrome/app/theme/touch_100_percent/browser_forward_pressed.png (1x) is
35x35, chrome/app/theme/touch_200_percent/browser_forward_pressed.png (2x)
is 58x58 should be 70x70.
IDR_HOME: chrome/app/theme/touch_100_percent/browser_home_normal.png (1x)
is 35x35, chrome/app/theme/touch_200_percent/browser_home_normal.png (2x)
is 58x58 should be 70x70.
IDR_HOME_H: chrome/app/theme/touch_100_percent/browser_home_hover.png (1x)
is 35x35, chrome/app/theme/touch_200_percent/browser_home_hover.png (2x) is
58x58 should be 70x70.
IDR_HOME_P: chrome/app/theme/touch_100_percent/browser_home_pressed.png
(1x) is 35x35, chrome/app/theme/touch_200_percent/browser_home_pressed.png
(2x) is 58x58 should be 70x70.
IDR_LOCATIONBG_C:
chrome/app/theme/touch_100_percent/browser_omnibox_middle.png (1x) is 5x35,
chrome/app/theme/touch_200_percent/browser_omnibox_middle.png (2x) is 2x58
should be 10x70.
IDR_LOCATIONBG_L:
chrome/app/theme/touch_100_percent/browser_omnibox_left.png (1x) is 5x35,
chrome/app/theme/touch_200_percent/browser_omnibox_left.png (2x) is 8x58
should be 10x70.
IDR_LOCATIONBG_R:
chrome/app/theme/touch_100_percent/browser_omnibox_right.png (1x) is 5x35,
chrome/app/theme/touch_200_percent/browser_omnibox_right.png (2x) is 8x58
should be 10x70.
IDR_NEWTAB_BUTTON: chrome/app/theme/touch_100_percent/newtab_normal.png
(1x) is 42x22, chrome/app/theme/touch_200_percent/newtab_normal.png (2x) is
68x36 should be 84x44.
IDR_NEWTAB_BUTTON_H: chrome/app/theme/touch_100_percent/newtab_hover.png
(1x) is 42x22, chrome/app/theme/touch_200_percent/newtab_hover.png (2x) is
68x36 should be 84x44.
IDR_NEWTAB_BUTTON_P: chrome/app/theme/touch_100_percent/newtab_pressed.png
(1x) is 42x22, chrome/app/theme/touch_200_percent/newtab_pressed.png (2x)
is 68x36 should be 84x44.
IDR_NEWTAB_BUTTON_MASK:
chrome/app/theme/touch_100_percent/newtab_button_mask.png (1x) is 42x22,
chrome/app/theme/touch_200_percent/newtab_button_mask.png (2x) is 68x36
should be 84x44.
IDR_RELOAD: chrome/app/theme/touch_100_percent/browser_reload_normal.png
(1x) is 35x35, chrome/app/theme/touch_200_percent/browser_reload_normal.png
(2x) is 58x58 should be 70x70.
IDR_RELOAD_H: chrome/app/theme/touch_100_percent/browser_reload_hover.png
(1x) is 35x35, chrome/app/theme/touch_200_percent/browser_reload_hover.png
(2x) is 58x58 should be 70x70.
IDR_RELOAD_P: chrome/app/theme/touch_100_percent/browser_reload_pressed.png
(1x) is 35x35,
chrome/app/theme/touch_200_percent/browser_reload_pressed.png (2x) is 58x58
should be 70x70.
IDR_STOP: chrome/app/theme/touch_100_percent/browser_stop_normal.png (1x)
is 35x35, chrome/app/theme/touch_200_percent/browser_stop_normal.png (2x)
is 58x58 should be 70x70.
IDR_STOP_D: chrome/app/theme/touch_100_percent/browser_stop_disabled.png
(1x) is 35x35, chrome/app/theme/touch_200_percent/browser_stop_disabled.png
(2x) is 58x58 should be 70x70.
IDR_STOP_H: chrome/app/theme/touch_100_percent/browser_stop_hover.png (1x)
is 35x35, chrome/app/theme/touch_200_percent/browser_stop_hover.png (2x) is
58x58 should be 70x70.
IDR_STOP_P: chrome/app/theme/touch_100_percent/browser_stop_pressed.png
(1x) is 35x35, chrome/app/theme/touch_200_percent/browser_stop_pressed.png
(2x) is 58x58 should be 70x70.
IDR_STOP_D: chrome/app/theme/default_100_percent/stop_disabled.png (1x) is
27x29, chrome/app/theme/default_200_percent/stop_disabled.png (2x) is 55x59
should be 54x58.
IDR_TAB_ACTIVE_CENTER:
chrome/app/theme/touch_100_percent/tab_active_center.png (1x) is 1x37,
chrome/app/theme/touch_200_percent/tab_active_center.png (2x) is 2x58
should be 2x74.
IDR_TAB_ACTIVE_LEFT: chrome/app/theme/touch_100_percent/tab_active_left.png
(1x) is 26x37, chrome/app/theme/touch_200_percent/tab_active_left.png (2x)
is 42x58 should be 52x74.
IDR_TAB_ACTIVE_RIGHT:
chrome/app/theme/touch_100_percent/tab_active_right.png (1x) is 26x37,
chrome/app/theme/touch_200_percent/tab_active_right.png (2x) is 42x58
should be 52x74.
IDR_TAB_ALPHA_LEFT: chrome/app/theme/touch_100_percent/tab_alpha_left.png
(1x) is 26x37, chrome/app/theme/touch_200_percent/tab_alpha_left.png (2x)
is 42x58 should be 52x74.
IDR_TAB_ALPHA_RIGHT: chrome/app/theme/touch_100_percent/tab_alpha_right.png
(1x) is 26x37, chrome/app/theme/touch_200_percent/tab_alpha_right.png (2x)
is 42x58 should be 52x74.
IDR_TAB_ACTIVE_CENTER:
chrome/app/theme/default_100_percent/tab_active_center.png (1x) is 1x27,
chrome/app/theme/default_200_percent/tab_active_center.png (2x) is 1x40
should be 2x54.
IDR_TAB_ACTIVE_LEFT:
chrome/app/theme/default_100_percent/tab_active_left.png (1x) is 15x27,
chrome/app/theme/default_200_percent/tab_active_left.png (2x) is 15x40
should be 30x54.
IDR_TAB_ACTIVE_RIGHT:
chrome/app/theme/default_100_percent/tab_active_right.png (1x) is 15x27,
chrome/app/theme/default_200_percent/tab_active_right.png (2x) is 15x40
should be 30x54.
IDR_TAB_ALPHA_LEFT: chrome/app/theme/default_100_percent/tab_alpha_left.png
(1x) is 15x27, chrome/app/theme/default_200_percent/tab_alpha_left.png (2x)
is 15x40 should be 30x54.
IDR_TAB_ALPHA_RIGHT:
chrome/app/theme/default_100_percent/tab_alpha_right.png (1x) is 15x27,
chrome/app/theme/default_200_percent/tab_alpha_right.png (2x) is 15x40
should be 30x54.
IDR_TAB_CLOSE: chrome/app/theme/touch_100_percent/tab_close_normal.png (1x)
is 22x22, chrome/app/theme/touch_200_percent/tab_close_normal.png (2x) is
36x36 should be 44x44.
IDR_TAB_CLOSE_H: chrome/app/theme/touch_100_percent/tab_close_hover.png
(1x) is 22x22, chrome/app/theme/touch_200_percent/tab_close_hover.png (2x)
is 36x36 should be 44x44.
IDR_TAB_CLOSE_MASK: chrome/app/theme/touch_100_percent/tab_close_mask.png
(1x) is 22x22, chrome/app/theme/touch_200_percent/tab_close_mask.png (2x)
is 36x36 should be 44x44.
IDR_TAB_CLOSE_P: chrome/app/theme/touch_100_percent/tab_close_pressed.png
(1x) is 22x22, chrome/app/theme/touch_200_percent/tab_close_pressed.png
(2x) is 36x36 should be 44x44.
IDR_TAB_CLOSE: chrome/app/theme/default_100_percent/tab_close.png (1x) is
12x12, chrome/app/theme/default_200_percent/tab_close.png (2x) is 29x29
should be 24x24.
IDR_TAB_CLOSE_H: chrome/app/theme/default_100_percent/tab_close_hover.png
(1x) is 12x12, chrome/app/theme/default_200_percent/tab_close_hover.png
(2x) is 29x29 should be 24x24.
IDR_TAB_CLOSE_MASK: chrome/app/theme/default_100_percent/tab_close_mask.png
(1x) is 12x12, chrome/app/theme/default_200_percent/tab_close_mask.png (2x)
is 29x29 should be 24x24.
IDR_TAB_CLOSE_P: chrome/app/theme/default_100_percent/tab_close_pressed.png
(1x) is 12x12, chrome/app/theme/default_200_percent/tab_close_pressed.png
(2x) is 29x29 should be 24x24.
IDR_TAB_INACTIVE_CENTER:
chrome/app/theme/touch_100_percent/tab_inactive_center.png (1x) is 1x37,
chrome/app/theme/touch_200_percent/tab_inactive_center.png (2x) is 2x58
should be 2x74.
IDR_TAB_INACTIVE_LEFT:
chrome/app/theme/touch_100_percent/tab_inactive_left.png (1x) is 26x37,
chrome/app/theme/touch_200_percent/tab_inactive_left.png (2x) is 42x58
should be 52x74.
IDR_TAB_INACTIVE_RIGHT:
chrome/app/theme/touch_100_percent/tab_inactive_right.png (1x) is 26x37,
chrome/app/theme/touch_200_percent/tab_inactive_right.png (2x) is 42x58
should be 52x74.
IDR_TAB_INACTIVE_CENTER:
chrome/app/theme/default_100_percent/tab_inactive_center.png (1x) is 32x27,
chrome/app/theme/default_200_percent/tab_inactive_center.png (2x) is 1x40
should be 64x54.
IDR_TAB_INACTIVE_LEFT:
chrome/app/theme/default_100_percent/tab_inactive_left.png (1x) is 15x27,
chrome/app/theme/default_200_percent/tab_inactive_left.png (2x) is 15x40
should be 30x54.
IDR_TAB_INACTIVE_RIGHT:
chrome/app/theme/default_100_percent/tab_inactive_right.png (1x) is 15x27,
chrome/app/theme/default_200_percent/tab_inactive_right.png (2x) is 15x40
should be 30x54.
IDR_TOOLS: chrome/app/theme/touch_100_percent/browser_tools_normal.png (1x)
is 35x35, chrome/app/theme/touch_200_percent/browser_tools_normal.png (2x)
is 58x58 should be 70x70.
IDR_TOOLS_H: chrome/app/theme/touch_100_percent/browser_tools_hover.png
(1x) is 35x35, chrome/app/theme/touch_200_percent/browser_tools_hover.png
(2x) is 58x58 should be 70x70.
IDR_TOOLS_P: chrome/app/theme/touch_100_percent/browser_tools_pressed.png
(1x) is 35x35, chrome/app/theme/touch_200_percent/browser_tools_pressed.png
(2x) is 58x58 should be 70x70.

Comparing images from ui/resources/ui_resources_standard.grd to
ui/resources/ui_resources_2x.grd:
IDR_BUBBLE_SHADOW_B: ui/resources/default_100_percent/bubble_shadow_b.png
(1x) is 1x30, ui/resources/default_200_percent/bubble_shadow_b.png (2x) is
1x30 should be 2x60.
IDR_BUBBLE_SHADOW_BL: ui/resources/default_100_percent/bubble_shadow_bl.png
(1x) is 30x30, ui/resources/default_200_percent/bubble_shadow_bl.png (2x)
is 30x30 should be 60x60.
IDR_BUBBLE_SHADOW_BR: ui/resources/default_100_percent/bubble_shadow_br.png
(1x) is 30x30, ui/resources/default_200_percent/bubble_shadow_br.png (2x)
is 30x30 should be 60x60.
IDR_BUBBLE_SHADOW_L: ui/resources/default_100_percent/bubble_shadow_l.png
(1x) is 30x1, ui/resources/default_200_percent/bubble_shadow_l.png (2x) is
30x1 should be 60x2.
IDR_BUBBLE_SHADOW_R: ui/resources/default_100_percent/bubble_shadow_r.png
(1x) is 30x1, ui/resources/default_200_percent/bubble_shadow_r.png (2x) is
30x1 should be 60x2.
IDR_BUBBLE_SHADOW_T: ui/resources/default_100_percent/bubble_shadow_t.png
(1x) is 1x30, ui/resources/default_200_percent/bubble_shadow_t.png (2x) is
1x30 should be 2x60.
IDR_BUBBLE_SHADOW_TL: ui/resources/default_100_percent/bubble_shadow_tl.png
(1x) is 30x30, ui/resources/default_200_percent/bubble_shadow_tl.png (2x)
is 30x30 should be 60x60.
IDR_BUBBLE_SHADOW_TR: ui/resources/default_100_percent/bubble_shadow_tr.png
(1x) is 30x30, ui/resources/default_200_percent/bubble_shadow_tr.png (2x)
is 30x30 should be 60x60.
IDR_AURA_CURSOR_NO_DROP: ui/resources/default_100_percent/aura/nodrop.png
(1x) is 32x31, ui/resources/default_200_percent/aura/nodrop.png (2x) is
61x61 should be 64x62.
IDR_AURA_CURSOR_COPY: ui/resources/default_100_percent/aura/copy.png (1x)
is 32x32, ui/resources/default_200_percent/aura/copy.png (2x) is 61x61
should be 64x64.
IDR_AURA_CURSOR_ALIAS: ui/resources/default_100_percent/aura/alias.png (1x)
is 31x32, ui/resources/default_200_percent/aura/alias.png (2x) is 61x61
should be 62x64.
IDR_AURA_CURSOR_CELL: ui/resources/default_100_percent/aura/cell.png (1x)
is 32x31, ui/resources/default_200_percent/aura/cell.png (2x) is 61x61
should be 64x62.
IDR_AURA_CURSOR_CONTEXT_MENU:
ui/resources/default_100_percent/aura/context_menu.png (1x) is 31x32,
ui/resources/default_200_percent/aura/context_menu.png (2x) is 61x61 should
be 62x64.
IDR_AURA_CURSOR_CROSSHAIR:
ui/resources/default_100_percent/aura/crosshair.png (1x) is 32x31,
ui/resources/default_200_percent/aura/crosshair.png (2x) is 61x61 should be
64x62.
IDR_AURA_CURSOR_HELP: ui/resources/default_100_percent/aura/help.png (1x)
is 32x31, ui/resources/default_200_percent/aura/help.png (2x) is 61x61
should be 64x62.
IDR_AURA_CURSOR_MOVE: ui/resources/default_100_percent/aura/move.png (1x)
is 32x32, ui/resources/default_200_percent/aura/move.png (2x) is 61x61
should be 64x64.
IDR_AURA_CURSOR_ZOOM_IN: ui/resources/default_100_percent/aura/zoom_in.png
(1x) is 32x32, ui/resources/default_200_percent/aura/zoom_in.png (2x) is
61x61 should be 64x64.
IDR_AURA_CURSOR_ZOOM_OUT:
ui/resources/default_100_percent/aura/zoom_out.png (1x) is 32x32,
ui/resources/default_200_percent/aura/zoom_out.png (2x) is 61x61 should be
64x64.
IDR_AURA_UBER_TRAY_VOLUME_LEVELS:
ui/resources/default_100_percent/aura/status_volume_all.png (1x) is 25x125,
ui/resources/default_200_percent/aura/status_volume_all.png (2x) is 50x200
should be 50x250.
IDR_AURA_UBER_TRAY_MORE:
ui/resources/default_100_percent/aura/status_more.png (1x) is 18x28,
ui/resources/default_200_percent/aura/status_more.png (2x) is 50x50 should
be 36x56.
IDR_AURA_UBER_TRAY_LESS:
ui/resources/default_100_percent/aura/status_less.png (1x) is 28x28,
ui/resources/default_200_percent/aura/status_less.png (2x) is 50x50 should
be 56x56.
IDR_AURA_UBER_TRAY_ACCESSIBILITY:
ui/resources/default_100_percent/aura/status_accessibility_mode.png (1x) is
23x24, ui/resources/default_200_percent/aura/status_accessibility_mode.png
(2x) is 50x50 should be 46x48.

Comparing images from ui/resources/ui_resources_touch.grd to
ui/resources/ui_resources_touch_2x.grd:
IDR_BUBBLE_SHADOW_B: ui/resources/default_100_percent/bubble_shadow_b.png
(1x) is 1x30, ui/resources/default_200_percent/bubble_shadow_b.png (2x) is
1x30 should be 2x60.
IDR_BUBBLE_SHADOW_BL: ui/resources/default_100_percent/bubble_shadow_bl.png
(1x) is 30x30, ui/resources/default_200_percent/bubble_shadow_bl.png (2x)
is 30x30 should be 60x60.
IDR_BUBBLE_SHADOW_BR: ui/resources/default_100_percent/bubble_shadow_br.png
(1x) is 30x30, ui/resources/default_200_percent/bubble_shadow_br.png (2x)
is 30x30 should be 60x60.
IDR_BUBBLE_SHADOW_L: ui/resources/default_100_percent/bubble_shadow_l.png
(1x) is 30x1, ui/resources/default_200_percent/bubble_shadow_l.png (2x) is
30x1 should be 60x2.
IDR_BUBBLE_SHADOW_R: ui/resources/default_100_percent/bubble_shadow_r.png
(1x) is 30x1, ui/resources/default_200_percent/bubble_shadow_r.png (2x) is
30x1 should be 60x2.
IDR_BUBBLE_SHADOW_T: ui/resources/default_100_percent/bubble_shadow_t.png
(1x) is 1x30, ui/resources/default_200_percent/bubble_shadow_t.png (2x) is
1x30 should be 2x60.
IDR_BUBBLE_SHADOW_TL: ui/resources/default_100_percent/bubble_shadow_tl.png
(1x) is 30x30, ui/resources/default_200_percent/bubble_shadow_tl.png (2x)
is 30x30 should be 60x60.
IDR_BUBBLE_SHADOW_TR: ui/resources/default_100_percent/bubble_shadow_tr.png
(1x) is 30x30, ui/resources/default_200_percent/bubble_shadow_tr.png (2x)
is 30x30 should be 60x60.
IDR_AURA_WINDOW_CLOSE:
ui/resources/touch_100_percent/window_close_normal.png (1x) is 46x45,
ui/resources/touch_200_percent/window_close_normal.png (2x) is 70x70 should
be 92x90.
IDR_AURA_WINDOW_CLOSE_H:
ui/resources/touch_100_percent/window_close_hover.png (1x) is 46x45,
ui/resources/touch_200_percent/window_close_hover.png (2x) is 70x70 should
be 92x90.
IDR_AURA_WINDOW_CLOSE_P:
ui/resources/touch_100_percent/window_close_pressed.png (1x) is 46x45,
ui/resources/touch_200_percent/window_close_pressed.png (2x) is 70x70
should be 92x90.
IDR_AURA_WINDOW_FULLSCREEN_CLOSE:
ui/resources/touch_100_percent/window_close_normal.png (1x) is 46x45,
ui/resources/touch_200_percent/window_close_normal.png (2x) is 70x70 should
be 92x90.
IDR_AURA_WINDOW_FULLSCREEN_CLOSE_H:
ui/resources/touch_100_percent/window_close_hover.png (1x) is 46x45,
ui/resources/touch_200_percent/window_close_hover.png (2x) is 70x70 should
be 92x90.
IDR_AURA_WINDOW_FULLSCREEN_CLOSE_P:
ui/resources/touch_100_percent/window_close_pressed.png (1x) is 46x45,
ui/resources/touch_200_percent/window_close_pressed.png (2x) is 70x70
should be 92x90.
IDR_AURA_WINDOW_MAXIMIZED_CLOSE:
ui/resources/touch_100_percent/window_close_normal.png (1x) is 46x45,
ui/resources/touch_200_percent/window_close_normal.png (2x) is 70x70 should
be 92x90.
IDR_AURA_WINDOW_MAXIMIZED_CLOSE_H:
ui/resources/touch_100_percent/window_close_hover.png (1x) is 46x45,
ui/resources/touch_200_percent/window_close_hover.png (2x) is 70x70 should
be 92x90.
IDR_AURA_WINDOW_MAXIMIZED_CLOSE_P:
ui/resources/touch_100_percent/window_close_pressed.png (1x) is 46x45,
ui/resources/touch_200_percent/window_close_pressed.png (2x) is 70x70
should be 92x90.
IDR_AURA_CURSOR_NO_DROP: ui/resources/default_100_percent/aura/nodrop.png
(1x) is 32x31, ui/resources/default_200_percent/aura/nodrop.png (2x) is
61x61 should be 64x62.
IDR_AURA_CURSOR_COPY: ui/resources/default_100_percent/aura/copy.png (1x)
is 32x32, ui/resources/default_200_percent/aura/copy.png (2x) is 61x61
should be 64x64.
IDR_AURA_CURSOR_ALIAS: ui/resources/default_100_percent/aura/alias.png (1x)
is 31x32, ui/resources/default_200_percent/aura/alias.png (2x) is 61x61
should be 62x64.
IDR_AURA_CURSOR_CELL: ui/resources/default_100_percent/aura/cell.png (1x)
is 32x31, ui/resources/default_200_percent/aura/cell.png (2x) is 61x61
should be 64x62.
IDR_AURA_CURSOR_CONTEXT_MENU:
ui/resources/default_100_percent/aura/context_menu.png (1x) is 31x32,
ui/resources/default_200_percent/aura/context_menu.png (2x) is 61x61 should
be 62x64.
IDR_AURA_CURSOR_CROSSHAIR:
ui/resources/default_100_percent/aura/crosshair.png (1x) is 32x31,
ui/resources/default_200_percent/aura/crosshair.png (2x) is 61x61 should be
64x62.
IDR_AURA_CURSOR_HELP: ui/resources/default_100_percent/aura/help.png (1x)
is 32x31, ui/resources/default_200_percent/aura/help.png (2x) is 61x61
should be 64x62.
IDR_AURA_CURSOR_MOVE: ui/resources/default_100_percent/aura/move.png (1x)
is 32x32, ui/resources/default_200_percent/aura/move.png (2x) is 61x61
should be 64x64.
IDR_AURA_CURSOR_ZOOM_IN: ui/resources/default_100_percent/aura/zoom_in.png
(1x) is 32x32, ui/resources/default_200_percent/aura/zoom_in.png (2x) is
61x61 should be 64x64.
IDR_AURA_CURSOR_ZOOM_OUT:
ui/resources/default_100_percent/aura/zoom_out.png (1x) is 32x32,
ui/resources/default_200_percent/aura/zoom_out.png (2x) is 61x61 should be
64x64.
IDR_AURA_UBER_TRAY_VOLUME_LEVELS:
ui/resources/default_100_percent/aura/status_volume_all.png (1x) is 25x125,
ui/resources/default_200_percent/aura/status_volume_all.png (2x) is 50x200
should be 50x250.
IDR_AURA_UBER_TRAY_MORE:
ui/resources/default_100_percent/aura/status_more.png (1x) is 18x28,
ui/resources/default_200_percent/aura/status_more.png (2x) is 50x50 should
be 36x56.
IDR_AURA_UBER_TRAY_LESS:
ui/resources/default_100_percent/aura/status_less.png (1x) is 28x28,
ui/resources/default_200_percent/aura/status_less.png (2x) is 50x50 should
be 56x56.
IDR_AURA_UBER_TRAY_ACCESSIBILITY:
ui/resources/default_100_percent/aura/status_accessibility_mode.png (1x) is
23x24, ui/resources/default_200_percent/aura/status_accessibility_mode.png
(2x) is 50x50 should be 46x48.

chro...@googlecode.com

unread,

Jun 7, 2012, 11:56:17 AM6/7/12

to chromi...@chromium.org

Updates:
Cc: pkotw...@chromium.org osh...@chromium.org
Labels: -Pri-2 Pri-1 Hotlist-Link Feature-Ash-Dip Mstone-22

Comment #1 on issue 131586 by rby...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

Eventually we'll have a pre-submit script that prevents people from
checking in resources whose size isn't exactly the 1x size times the scale
factor.

For now (issue 129602) we'll just delete / stop using the ones that look
really bad, and live with the ones that only look a little bad while we
wait for updated assets that are the right size.

chro...@googlecode.com

unread,

Jun 14, 2012, 2:10:52 PM6/14/12

to chromi...@chromium.org

Comment #3 on issue 131586 by fla...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

Re comment #2, the list above wasn't comparing the size of touch assets to
non-touch. It was only comparing 2x to 1x separately for touch assets and
non-touch assets.

chro...@googlecode.com

unread,

Jun 14, 2012, 3:23:52 PM6/14/12

to chromi...@chromium.org

Comment #4 on issue 131586 by rby...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

Right, sorry - what I meant is that we updated some 2x icons without also
checking in new 1x.

What does your script do if we have touch_200 but no touch_100? I think we
may be in that state for a bunch of assets...

chro...@googlecode.com

unread,

Jun 14, 2012, 3:36:52 PM6/14/12

to chromi...@chromium.org

Comment #5 on issue 131586 by fla...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

We always have an asset, it's just a question of if we're pointing to the
non touch asset for touch_100. In any event these are reported as
inconsistencies if we update the 2x and don't have a 1x asset which is
exactly half the size.

chro...@googlecode.com

unread,

Jul 13, 2012, 11:41:33 AM7/13/12

to chromi...@chromium.org

Updates:
Owner: fla...@chromium.org

Comment #14 on issue 131586 by Kusc...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

The assets mentioned in #13 are already taken care of with issue 132686.

Flackr, can you re-run this script to see what is left to do?

chro...@googlecode.com

unread,

Jul 20, 2012, 4:07:39 PM7/20/12

to chromi...@chromium.org

Updates:
Status: Assigned
Owner: Kusc...@chromium.org

Comment #19 on issue 131586 by fla...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

I've looked for several of these files in the drive folder provided but
they do not seem to be there. Can you reassign to whomever can get these
resources or advise if I should be just reverting to the 1x ones. Thanks.

chro...@googlecode.com

unread,

Jul 21, 2012, 12:17:10 AM7/21/12

to chromi...@chromium.org

Comment #20 on issue 131586 by Kusc...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

I will take care of this.

chro...@googlecode.com

unread,

Jul 27, 2012, 12:28:03 PM7/27/12

to chromi...@chromium.org

Updates:
Labels: -Mstone-22 Mstone-23

Comment #21 on issue 131586 by rby...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

(No comment was entered for this change.)

chro...@googlecode.com

unread,

Jul 31, 2012, 10:09:34 PM7/31/12

to chromi...@chromium.org

Updates:
Owner: fla...@chromium.org

Comment #22 on issue 131586 by Kusc...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

The pointer that are wrong in the list above are now fixed and can be found
in

ui-resources/cros/default_100/cros/pointers
ui-resources/cros/default_200/cros/pointers

https://docs.google.com/a/google.com/open?id=0B6x6iYCtKinEQWRHZzZ6NjZhaWs

Ideally they should land in the same folder in the resources.

After that, can you re-assign this to sgabriel@ for the other assets
please. Thanks!

chro...@googlecode.com

unread,

Aug 1, 2012, 10:49:47 AM8/1/12

to chromi...@chromium.org

Updates:
Status: Started

Comment #23 on issue 131586 by fla...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

chro...@googlecode.com

unread,

Aug 1, 2012, 12:53:56 PM8/1/12

to chromi...@chromium.org

Comment #24 on issue 131586 by bugdro...@chromium.org: 2x resources should

be exactly twice the size of 1x resources.

http://code.google.com/p/chromium/issues/detail?id=131586#c24

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=149426

------------------------------------------------------------------------
r149426 | fla...@chromium.org | 2012-08-01T16:19:00.242330Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/top_left_corner.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/help.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/help.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/alias.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/hand2.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/sb_v_double_arrow.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/crosshair.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/xterm.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/nodrop.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/nodrop.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/context_menu.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/context_menu.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/xterm_horiz.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/zoom_in.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/fleur.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/left_ptr.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/cell.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/cell.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/left_ptr.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/sb_h_double_arrow.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/top_left_corner.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/alias.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/crosshair.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/hand2.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/sb_v_double_arrow.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/xterm.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/move.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/top_right_corner.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/move.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/top_right_corner.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/xterm_horiz.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/zoom_in.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/copy.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/copy.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/zoom_out.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/zoom_out.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/fleur.png?r1=149426&r2=149425&pathrev=149426
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/sb_h_double_arrow.png?r1=149426&r2=149425&pathrev=149426

Update cursor resources.

BUG=131586
TEST=Cursors are 25x25 (1x) and 50x50 (2x) and still work in chromeos.

Review URL: https://chromiumcodereview.appspot.com/10830119
------------------------------------------------------------------------

chro...@googlecode.com

unread,

Aug 1, 2012, 1:19:56 PM8/1/12

to chromi...@chromium.org

Updates:
Status: Assigned
Owner: sgabr...@chromium.org
Cc: fla...@chromium.org

Comment #25 on issue 131586 by fla...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

Pointers have landed, the remaining resources are as follows:

chrome/app/theme/default_200_percent/chromium/product_logo.png is 342x64
should be 292x64.
chrome/app/theme/default_200_percent/chromium/product_logo_white.png is
342x64 should be 292x64.
chrome/app/theme/default_200_percent/speech_input_mic_empty.png is 193x10
should be 194x10.
chrome/app/theme/touch_200_percent/ash/toolbar_shade_bottom_left.png is 1x1
should be 2x2.
chrome/app/theme/touch_200_percent/ash/toolbar_shade_bottom_right.png is
1x1 should be 2x2.
chrome/app/theme/touch_200_percent/ash/toolbar_shade_right.png is 1x1
should be 2x2.
chrome/app/theme/touch_200_percent/ash/toolbar_shade_bottom.png is 1x1
should be 2x2.
chrome/app/theme/touch_200_percent/ash/toolbar_shade_line.png is 1x1 should
be 2x2.
chrome/app/theme/touch_200_percent/ash/toolbar_shade_left.png is 1x1 should
be 2x2.
chrome/app/theme/touch_200_percent/otr_icon.png is 75x62 should be 76x64.
chrome/app/theme/touch_200_percent/otr_icon_fullscreen.png is 90x88 should
be 110x88.
ui/resources/default_200_percent/ash/status_less.png is 50x50 should be
56x56.
ui/resources/default_200_percent/ash/status_more.png is 50x50 should be
36x56.
ui/resources/default_200_percent/menu_check.png is 16x14 should be 26x24.
ui/resources/touch_200_percent/textbutton_hover_left.png is 10x48 should be
10x50.
ui/resources/touch_200_percent/textbutton_pressed_left.png is 10x48 should
be 10x50.
ui/resources/touch_200_percent/textbutton_pressed_right.png is 10x48 should
be 10x50.
ui/resources/touch_200_percent/textbutton_hover_right.png is 10x48 should
be 10x50.
ui/resources/touch_200_percent/textbutton_hover_center.png is 2x48 should
be 2x50.
ui/resources/touch_200_percent/textbutton_pressed_center.png is 2x48 should
be 2x50.

chro...@googlecode.com

unread,

Aug 1, 2012, 1:58:56 PM8/1/12

to chromi...@chromium.org

Comment #26 on issue 131586 by bugdro...@chromium.org: 2x resources should

be exactly twice the size of 1x resources.

http://code.google.com/p/chromium/issues/detail?id=131586#c26

The following revision refers to this bug:

BUG=131586
TEST=Cursors are 25x25 (1x) and 50x50 (2x) and still work in chromeos.

Review URL: https://chromiumcodereview.appspot.com/10830119

TBR=fla...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829125
------------------------------------------------------------------------

chro...@googlecode.com

unread,

Aug 1, 2012, 5:55:21 PM8/1/12

to chromi...@chromium.org

Comment #27 on issue 131586 by fla...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

We have to update the hot points of the cursors. The error in ash_unittests
was caused by specifying a hotspot that was a transparent part of the
cursors. These are set in ui/aura/root_window_host_linux.cc in the function
RootWindowHostLinux::ImageCursors::Reload. To reland we need to correctly
specify the new hotspot.

chro...@googlecode.com

unread,

Aug 2, 2012, 1:48:25 AM8/2/12

to chromi...@chromium.org

Updates:
Owner: fla...@chromium.org

Comment #28 on issue 131586 by Kusc...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

I updated the icons.

https://docs.google.com/a/google.com/open?id=0B6x6iYCtKinEbkxJLVlzQWVCVXM
https://docs.google.com/a/google.com/folder/d/0B9epHg7aUU95YmdjOGRnUHdMSHc/edit

Also attached them for easy access as well as a hot point overview.

Again, back to sgabriel@ afterwards.

Attachments:
images.zip 52.3 KB
hot points.zip 53.2 KB

chro...@googlecode.com

unread,

Aug 8, 2012, 12:51:42 PM8/8/12

to chromi...@chromium.org

Comment #30 on issue 131586 by bugdro...@chromium.org: 2x resources should

be exactly twice the size of 1x resources.

http://code.google.com/p/chromium/issues/detail?id=131586#c30

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=150558

------------------------------------------------------------------------
r150558 | fla...@chromium.org | 2012-08-08T15:39:31.928936Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/top_left_corner.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/help.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/help.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/aura/root_window_host_linux.cc?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/alias.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/hand2.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/sb_v_double_arrow.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/crosshair.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/xterm.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/nodrop.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/nodrop.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/context_menu.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/context_menu.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/xterm_horiz.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/zoom_in.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/fleur.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/left_ptr.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/cell.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/cell.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/left_ptr.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/sb_h_double_arrow.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/top_left_corner.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/alias.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/crosshair.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/hand2.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/sb_v_double_arrow.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/xterm.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/move.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/top_right_corner.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/move.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/top_right_corner.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/zoom_in.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/xterm_horiz.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/copy.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/copy.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/zoom_out.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/zoom_out.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/aura/fleur.png?r1=150558&r2=150557&pathrev=150558
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/aura/sb_h_double_arrow.png?r1=150558&r2=150557&pathrev=150558

Reland new cursor resources.
This relands commit 149426 updating cursors and hotspot information.

BUG=131586
TEST=ash_unittests pass and cursors are correct 25x25 and 50x50 (2x) sizes.

Review URL: https://chromiumcodereview.appspot.com/10834211
------------------------------------------------------------------------

chro...@googlecode.com

unread,

Aug 9, 2012, 2:20:46 AM8/9/12

to chromi...@chromium.org

Comment #32 on issue 131586 by osh...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

where is the hot point information stored? Is it on drive?

chro...@googlecode.com

unread,

Aug 13, 2012, 3:45:22 PM8/13/12

to chromi...@chromium.org

Comment #33 on issue 131586 by Kusc...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

Issue 141283 has been merged into this issue.

chro...@googlecode.com

unread,

Aug 13, 2012, 3:49:22 PM8/13/12

to chromi...@chromium.org

Comment #34 on issue 131586 by Kusc...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

We don't care about touch for now I believe, so the remaining items for
Sebastien are:

ui/resources/default_200_percent/ash/status_less.png is 50x50 should be
56x56.
ui/resources/default_200_percent/ash/status_more.png is 50x50 should be
36x56.

ui/resources/default_200_percent/menu_check.png is 16x14 should be 26x24.

chro...@googlecode.com

unread,

Aug 13, 2012, 10:35:25 PM8/13/12

to chromi...@chromium.org

Updates:
Owner: fla...@chromium.org

Comment #35 on issue 131586 by Kusc...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

status_more.png 2x and 2x have been added to the right folders:
_output/chrome/ui-resources/default_100/cros/
_output/chrome/ui-resources/default_200/cros/

menu_check.png have been added to the right folder :
_output/chrome/ui-resources/default_100/cros/
_output/chrome/ui-resources/default_200/cros/

product_logo.png and product_logo_white.png have been added - you can find
them here:
_output/chrome-logo/chromium/200/

speech_input_mic_empty.png is available in :
_output/chrome/chrome-app-theme/default_200/common/

chro...@googlecode.com

unread,

Aug 16, 2012, 11:02:11 AM8/16/12

to chromi...@chromium.org

Comment #36 on issue 131586 by fla...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

Thanks, I have a few questions.

menu_check.png still doesn't seem to be correctly sized or I'm not seeing
the correct version of it.
ui-resources/default_100/cros/menu_check.png is 13x12
ui-resources/default_200/cros/menu_check.png is 16x14

I don't seem to have access to the chrome-logo or chrome-app-theme folders.
Can someone add me?

I'm assuming status_less isn't available yet?

chro...@googlecode.com

unread,

Aug 16, 2012, 11:15:55 AM8/16/12

to chromi...@chromium.org

Comment #37 on issue 131586 by Kusc...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

You should be able to grab things from the chrome-logo folder and
chrome-app-theme now - you are on the shared list:
https://docs.google.com/a/google.com/folder/d/0B7t22qFrueRsOHdDeG45eGh2SG8/edit
https://docs.google.com/a/google.com/open?id=0B6x6iYCtKinEMmNYdWczMDlUanM

I will talk to Sebastien about those two items

chro...@googlecode.com

unread,

Aug 17, 2012, 12:06:42 PM8/17/12

to chromi...@chromium.org

Updates:
Labels: Iteration-63

Comment #38 on issue 131586 by rby...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

chro...@googlecode.com

unread,

Aug 17, 2012, 1:21:42 PM8/17/12

to chromi...@chromium.org

Updates:
Status: Started

Comment #39 on issue 131586 by fla...@chromium.org: 2x resources should be

chro...@googlecode.com

unread,

Aug 17, 2012, 1:53:43 PM8/17/12

to chromi...@chromium.org

Comment #40 on issue 131586 by sgabr...@google.com: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

menu_check.png has been corrected :
https://docs.google.com/a/google.com/open?id=0B6x6iYCtKinEczZxcTR4bEJxYUE

status_less/more.png have been added :
https://docs.google.com/a/google.com/open?id=0B6x6iYCtKinEN0lDU1BDOHBwRFE

chro...@googlecode.com

unread,

Aug 22, 2012, 1:12:04 PM8/22/12

to chromi...@chromium.org

Comment #41 on issue 131586 by bugdro...@chromium.org: 2x resources should

be exactly twice the size of 1x resources.

http://code.google.com/p/chromium/issues/detail?id=131586#c41

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=152778

------------------------------------------------------------------------
r152778 | fla...@chromium.org | 2012-08-22T16:42:19.107618Z

Changed paths:
D
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/speech_input_mic_full.png?r1=152778&r2=152777&pathrev=152778
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=152778&r2=152777&pathrev=152778
D
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/speech_input_mic_full.png?r1=152778&r2=152777&pathrev=152778
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/ash/status_more.png?r1=152778&r2=152777&pathrev=152778
D
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/speech_input_mic_noise.png?r1=152778&r2=152777&pathrev=152778
D
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/speech_input_mic_noise.png?r1=152778&r2=152777&pathrev=152778
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/ash/status_less.png?r1=152778&r2=152777&pathrev=152778
D
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/speech_input_spinner.png?r1=152778&r2=152777&pathrev=152778
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/chromium/product_logo.png?r1=152778&r2=152777&pathrev=152778
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/chromium/product_logo_white.png?r1=152778&r2=152777&pathrev=152778
D
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/speech_input_spinner.png?r1=152778&r2=152777&pathrev=152778
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/update_uptodate.png?r1=152778&r2=152777&pathrev=152778
D
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/speech_input_mic_mask.png?r1=152778&r2=152777&pathrev=152778
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/menu_check.png?r1=152778&r2=152777&pathrev=152778
D
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/speech_input_mic_mask.png?r1=152778&r2=152777&pathrev=152778
D
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/speech_input_mic_empty.png?r1=152778&r2=152777&pathrev=152778
D
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/speech_input_mic_empty.png?r1=152778&r2=152777&pathrev=152778

Add correctly sized 2x assets for remaining mismatches.

BUG=131586

Review URL: https://chromiumcodereview.appspot.com/10832375
------------------------------------------------------------------------

chro...@googlecode.com

unread,

Aug 22, 2012, 2:44:19 PM8/22/12

to chromi...@chromium.org

Updates:
Status: Assigned
Owner: Kusc...@chromium.org

Comment #42 on issue 131586 by fla...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

I'm not sure if we're including webkit resources in this but I ran the
script over the webkit resource directories and found the following:

webkit/glue/resources/default_200_percent/pdf_button_zoomin.png is 86x84
should be 84x84.
webkit/glue/resources/default_200_percent/pdf_button_zoomin_pressed.png is
86x84 should be 84x84.
webkit/glue/resources/default_200_percent/pdf_button_zoomin_hover.png is
86x84 should be 84x84.
webkit/glue/resources/default_200_percent/pdf_page_indicator_background.png
is 140x94 should be 142x94.

This directory also currently does not have the same presubmit script to
verify that CL's commit correctly sized resources.

chro...@googlecode.com

unread,

Aug 22, 2012, 4:16:20 PM8/22/12

to chromi...@chromium.org

Comment #44 on issue 131586 by jhorw...@chromium.org: 2x resources should

be exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

Yes, these in comment 42 are for PDF viewer. I added these via
http://codereview.chromium.org/10834074/ at r149519

Actually, pdf_button_zoomin at 100% might be too thin by 1 pixel (most of
the others like pdf_button_zoomout*, pdf_button_save* etc are 43x42 (so
200% should be 86x84) rather than shrinking the 200_percent one to match. I
will check with the icon designers why one is thinner than the others at
100% / if they can get us thicker 100% pdf_button_zoomin.png,
pdf_button_zoomin_pressed.png, pdf_button_zoomin_hover.png. Along with a
properly-sized pdf_page_indicator_background.png

chro...@googlecode.com

unread,

Aug 22, 2012, 5:19:21 PM8/22/12

to chromi...@chromium.org

Comment #45 on issue 131586 by osh...@chromium.org: 2x resources should be

exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

Note that the we only require the image size to be 2x. Actual picture in
the image doesn't have to be visually 2x and can be smaller or bigger if
necessary.

chro...@googlecode.com

unread,

Aug 22, 2012, 6:24:37 PM8/22/12

to chromi...@chromium.org

Updates:
Status: Started

Comment #46 on issue 131586 by jhorw...@chromium.org: 2x resources should

be exactly twice the size of 1x resources.
http://code.google.com/p/chromium/issues/detail?id=131586

Reply all

Reply to author

Forward