Issue 141008 in chromium: "Chrome Web Store" in the "This file type is not supported" dialog in file manager is linked to wrong URL

[chro...@googlecode.com]

Status: Untriaged
Owner: ----
Labels: Type-Bug Pri-2 Area-UI Feature-FileManager OS-Chrome

New issue 141008 by har...@chromium.org: "Chrome Web Store" in the "This
file type is not supported" dialog in file manager is linked to wrong URL
http://code.google.com/p/chromium/issues/detail?id=141008

Version: 22.0.1228.0 canary
OS: Chrome OS

What steps will reproduce the problem?
1. download a csv file.
2. open a file manager.
3. double click the downloaded csv file to open it.
4. click "Chrome Web Store" link in the "This file type is not supported"
dialog.
5. it is linked to a help page
http://support.google.com/chromeos/bin/answer.py?hl=en&topic=29026&ctx=topic&answer=1700055

What is the expected output? What do you see instead?
The link lands to "Chrome Web Store" top (or relevant app search results
page).


Please use labels and text to provide additional information.

[chro...@googlecode.com]

Updates:
Status: Available
Cc: kaznach...@chromium.org

Comment #1 on issue 141008 by kin...@chromium.org: "Chrome Web Store" in

the "This file type is not supported" dialog in file manager is linked to
wrong URL
http://code.google.com/p/chromium/issues/detail?id=141008

I think I've found what is happening.

<message name="IDS_FILE_BROWSER_NO_ACTION_FOR_FILE" desc="Message shown
when user tries to open file, which we can't handle.">
This file type is not supported. Please visit the <ph
name="BEGIN_LINK">&lt;a target='_blank' href='$1'&gt;<ex>&lt;a
target='_blank' href='$1'&gt;</ex></ph>Chrome Web Store<ph
name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph> to find an app that can
open this type of file.
<ph name="BEGIN_LINK">&lt;a target='_blank' href='$2'&gt;<ex>&lt;a
target='_blank' href='$2'&gt;</ex></ph>Learn More<ph
name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
</message>

BEGIN_LINK and END_LINK is used twice each, so grit squeezes them into one
while generating resource files.
They should be assigned distinct parameter names (e.g., BEGEN_LINK_WEBSTORE
and BEGIN_LINK_HELP).

[chro...@googlecode.com]

Comment #2 on issue 141008 by kin...@chromium.org: "Chrome Web Store" in

the "This file type is not supported" dialog in file manager is linked to
wrong URL
http://code.google.com/p/chromium/issues/detail?id=141008

By the way, I tried the fix along the observation above locally, and did
got a correct link to WebStore, but it seems to hit another issue;
navigating along the link crashes with DCHECK in debug build:
[16315:16315:118777136368:FATAL:render_view_host_manager.cc(243)] Check
failed: !web_ui_.get().
This only happens on a link to WebStore.

[chro...@googlecode.com]

Comment #3 on issue 141008 by kin...@chromium.org: "Chrome Web Store" in

the "This file type is not supported" dialog in file manager is linked to
wrong URL
http://code.google.com/p/chromium/issues/detail?id=141008

The trouble in comment #2 happens on all links from any extension to
webstore.
Maybe we can just fix the resource text for this issue.

Could somebody take care of this one?

[chro...@googlecode.com]

Updates:
Status: Assigned
Owner: kaznach...@chromium.org

Comment #4 on issue 141008 by kaznach...@chromium.org: "Chrome Web Store"

in the "This file type is not supported" dialog in file manager is linked
to wrong URL
http://code.google.com/p/chromium/issues/detail?id=141008

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #5 on issue 141008 by bugdro...@chromium.org: "Chrome Web Store" in

the "This file type is not supported" dialog in file manager is linked to
wrong URL

http://code.google.com/p/chromium/issues/detail?id=141008#c5

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=152336

------------------------------------------------------------------------
r152336 | kazna...@chromium.org | 2012-08-20T16:28:19.951672Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=152336&r2=152335&pathrev=152336

Fix the string for "This file type is not supported" message in the Files
app


BUG=141008


Review URL: https://chromiumcodereview.appspot.com/10855242
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #6 on issue 141008 by kaznach...@chromium.org: "Chrome Web Store"

in the "This file type is not supported" dialog in file manager is linked
to wrong URL