Re: Issue 360251 in chromium: blink::WebMediaPlayer::didLoadingProgress() should not be const.

7 views
Skip to first unread message

chro...@googlecode.com

unread,
May 13, 2014, 3:49:07 PM5/13/14
to chromi...@chromium.org

Comment #3 on issue 360251 by bugdro...@chromium.org:
blink::WebMediaPlayer::didLoadingProgress() should not be const.
http://code.google.com/p/chromium/issues/detail?id=360251#c3

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=173980

------------------------------------------------------------------
r173980 | sand...@chromium.org | 2014-05-13T19:10:07.556818Z

Changed paths:
M
http://src.chromium.org/viewvc/blink/trunk/public/platform/WebMediaPlayer.h?r1=173980&r2=173979&pathrev=173980

Make WebMediaPlayer::didLoadingProgress() non-const.

The Chromium-side change is https://codereview.chromium.org/275303002,
which must be committed first.

BUG=360251

Review URL: https://codereview.chromium.org/272223004
-----------------------------------------------------------------

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

chro...@googlecode.com

unread,
May 14, 2014, 8:43:27 PM5/14/14
to chromi...@chromium.org

Comment #4 on issue 360251 by bugdro...@chromium.org:
blink::WebMediaPlayer::didLoadingProgress() should not be const.
http://code.google.com/p/chromium/issues/detail?id=360251#c4

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/4c4583b3554d660539ff7c7feff866f17400f9b5

commit 4c4583b3554d660539ff7c7feff866f17400f9b5
Author: sand...@chromium.org
<sand...@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu May 15 00:02:32 2014

Remove const WebMediaPlayer::didLoadingProgress() implementations.

This is the third of three changes; the others are:
https://codereview.chromium.org/275303002 (chromium prep)
https://codereview.chromium.org/272223004 (blink side)

BUG=360251

Review URL: https://codereview.chromium.org/284723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270520
0039d316-1c4b-4281-b951-d872f2087c98

chro...@googlecode.com

unread,
May 14, 2014, 8:50:27 PM5/14/14
to chromi...@chromium.org

chro...@googlecode.com

unread,
May 14, 2014, 8:59:27 PM5/14/14
to chromi...@chromium.org
Updates:
Status: Fixed
Owner: sande...@chromium.org

Comment #6 on issue 360251 by sande...@chromium.org:
blink::WebMediaPlayer::didLoadingProgress() should not be const.
http://code.google.com/p/chromium/issues/detail?id=360251

(No comment was entered for this change.)
Reply all
Reply to author
Forward
0 new messages