Re: Issue 574996 in chromium: Pages loaded in new tab are not scrolled to top

chro...@googlecode.com

unread,

Feb 3, 2016, 11:55:59 AM2/3/16

to chromi...@chromium.org

Comment #42 on issue 574996 by stuart...@chromium.org: Pages loaded in
new tab are not scrolled to top
https://code.google.com/p/chromium/issues/detail?id=574996

Issue 583608 has been merged into this issue.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

chro...@googlecode.com

unread,

Feb 3, 2016, 2:24:58 PM2/3/16

to chromi...@chromium.org

Updates:
Status: Assigned

Comment #43 on issue 574996 by vkar...@chromium.org: Pages loaded in new

tab are not scrolled to top
https://code.google.com/p/chromium/issues/detail?id=574996

Tested in 49.0.2623.37 dev, iPad air 2 iOS9.3
This issue is still reproducible for some of the pages like CNN money,
Nytimes Technology pages.

https://drive.google.com/open?id=0B-tbaGTQZtpQYXdadFVDRVFPbjQ

chro...@googlecode.com

unread,

Feb 3, 2016, 7:53:51 PM2/3/16

to chromi...@chromium.org

Comment #47 on issue 574996 by kkhor...@chromium.org: Pages loaded in new

tab are not scrolled to top
https://code.google.com/p/chromium/issues/detail?id=574996

It should be noted that this also reproduces infrequently when you switch
to the tab after it's finished loading, but I suspect that understanding
what's causing the {0,-16} contentOffset is related.

chro...@googlecode.com

unread,

Feb 9, 2016, 11:07:54 PM2/9/16

to chromi...@chromium.org

Comment #48 on issue 574996 by bugd...@chromium.org: Pages loaded in new

tab are not scrolled to top

https://code.google.com/p/chromium/issues/detail?id=574996#c48

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/c47dcc4e47d42932d126d80d5aa740cf8470280a

commit c47dcc4e47d42932d126d80d5aa740cf8470280a
Author: kkhorimoto <kkhor...@chromium.org>
Date: Wed Feb 10 02:36:28 2016

Set CRWWebViewContentView's size before resetting scroll proxy.

Because CRWWebViewContentView's frame was CGRectZero when the scroll
proxy's backing UIScrollView was reset,
CRWWebViewScrollViewProxyObservers were mistakenly resetting the web
view's frame to an invalid frame (negative values for size dimensions).
This was causing various rendering issues, including an incorrect
scroll offset for links opened in new tabs and broken tap handling for
"Read More" links on cnn.com.

BUG=577793, 574996

Review URL: https://codereview.chromium.org/1682873002

Cr-Commit-Position: refs/heads/master@{#374581}

[modify]
http://crrev.com/c47dcc4e47d42932d126d80d5aa740cf8470280a/ios/web/web_state/ui/crw_web_controller_container_view.mm
[modify]
http://crrev.com/c47dcc4e47d42932d126d80d5aa740cf8470280a/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify]
http://crrev.com/c47dcc4e47d42932d126d80d5aa740cf8470280a/ios/web/web_state/ui/crw_web_view_content_view.mm
[modify]
http://crrev.com/c47dcc4e47d42932d126d80d5aa740cf8470280a/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm

chro...@googlecode.com

unread,

Feb 9, 2016, 11:08:54 PM2/9/16

to chromi...@chromium.org

Updates:
Status: Fixed
Labels: -merge-merged-2564 -M-48 -Hotlist-Merge-Approved
-merge-merged-2623 Merge-Request-49

Comment #49 on issue 574996 by kkhor...@chromium.org: Pages loaded in new

tab are not scrolled to top
https://code.google.com/p/chromium/issues/detail?id=574996

(No comment was entered for this change.)

chro...@googlecode.com

unread,

Feb 10, 2016, 4:59:54 AM2/10/16

to chromi...@chromium.org

Comment #50 on issue 574996 by jasperva...@gmail.com: Pages loaded in new

tab are not scrolled to top
https://code.google.com/p/chromium/issues/detail?id=574996

Great...! nice job, sorted.

chro...@googlecode.com

unread,

Feb 11, 2016, 7:13:20 AM2/11/16

to chromi...@chromium.org

Updates:
Labels: -Merge-Approved-49 merge-merged-2623

Comment #53 on issue 574996 by bugd...@chromium.org: Pages loaded in new

tab are not scrolled to top

https://code.google.com/p/chromium/issues/detail?id=574996#c53

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/974ef8f713cc4cff06cbe2b690b2b7f50d05bebf

commit 974ef8f713cc4cff06cbe2b690b2b7f50d05bebf
Author: Kurt Horimoto <kkhor...@chromium.org>
Date: Wed Feb 10 19:47:26 2016

Set CRWWebViewContentView's size before resetting scroll proxy.

Because CRWWebViewContentView's frame was CGRectZero when the scroll
proxy's backing UIScrollView was reset,
CRWWebViewScrollViewProxyObservers were mistakenly resetting the web
view's frame to an invalid frame (negative values for size dimensions).
This was causing various rendering issues, including an incorrect
scroll offset for links opened in new tabs and broken tap handling for
"Read More" links on cnn.com.

BUG=577793, 574996

Review URL: https://codereview.chromium.org/1682873002

Cr-Commit-Position: refs/heads/master@{#374581}