Issue 397950 in chromium: "Show Managed bookmarks" context menu option is shown even if there are no managed bookmarks

[chro...@googlecode.com]

Status: Started
Owner: joaod...@chromium.org
Labels: Type-Bug Pri-2 Cr-Enterprise OS-Windows OS-Linux OS-Chrome
ReleaseBlock-Stable M-37

New issue 397950 by joaod...@chromium.org: "Show Managed bookmarks"
context menu option is shown even if there are no managed bookmarks
http://code.google.com/p/chromium/issues/detail?id=397950

"Managed bookmarks" is a new bookmarks folder that contains bookmarks
configured by the administrator. This folder only shows up if the policy is
configured.

The user has the option to hide the folder via the "Show managed bookmarks"
context menu option. This option should only appear when the policy is
configured, but it is appearing always.

This only affects the views implementation (Win, Linux, ChromeOS). The Mac
implementation doesn't have this bug.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #4 on issue 397950 by bugdro...@chromium.org: "Show Managed

bookmarks" context menu option is shown even if there are no managed
bookmarks

http://code.google.com/p/chromium/issues/detail?id=397950#c4

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/3b331099fd64262e37838249c1af5602167fc56c

commit 3b331099fd64262e37838249c1af5602167fc56c
Author: joaod...@chromium.org
<joaod...@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jul 29 10:38:03 2014

Check if the delegate changed the visibility of child MenuItemViews.

This is used by the BookmarkContextMenu to hide the "Show Managed
Bookmarks" option when that policy is not set.

BUG=397950

Review URL: https://codereview.chromium.org/423833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286163
0039d316-1c4b-4281-b951-d872f2087c98

[chro...@googlecode.com]

Comment #5 on issue 397950 by bugdro...@chromium.org: "Show Managed

bookmarks" context menu option is shown even if there are no managed
bookmarks

http://code.google.com/p/chromium/issues/detail?id=397950#c5

------------------------------------------------------------------
r286163 | joaod...@chromium.org | 2014-07-29T10:38:03.771197Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/menu/menu_item_view.cc?r1=286163&r2=286162&pathrev=286163
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc?r1=286163&r2=286162&pathrev=286163
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc?r1=286163&r2=286162&pathrev=286163
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/menu/menu_delegate.cc?r1=286163&r2=286162&pathrev=286163
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h?r1=286163&r2=286162&pathrev=286163
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/menu/menu_delegate.h?r1=286163&r2=286162&pathrev=286163
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/menu/menu_model_adapter.cc?r1=286163&r2=286162&pathrev=286163
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/menu/menu_model_adapter.h?r1=286163&r2=286162&pathrev=286163

Check if the delegate changed the visibility of child MenuItemViews.

This is used by the BookmarkContextMenu to hide the "Show Managed
Bookmarks" option when that policy is not set.

BUG=397950

Review URL: https://codereview.chromium.org/423833002

-----------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Fixed
Cc: smok...@chromium.org ligim...@chromium.org

Comment #6 on issue 397950 by joaod...@chromium.org: "Show Managed

bookmarks" context menu option is shown even if there are no managed
bookmarks
http://code.google.com/p/chromium/issues/detail?id=397950

Please verify in 38.0.2108.1 or later.

Steps to verify:

1. run a new Chrome instance (clean user dir). Right click the bookmark
bar. You should not see the option to "Show managed bookmarks"

2. signin with book...@managedchrome.com. Verify that
the "ManagedBookmarks" policy is then present in chrome://policy

3. right-click the bookmark bar. There should be a new option to "Show
managedchrome.com bookmarks"

This bug fixes step 1. Without the fix, the "Show managed bookmarks" option
is always present.

More details about testing this feature (including testing accounts) at
https://docs.google.com/a/google.com/document/d/1XJN9uNNIDAMJa7MAJhsYUwhLQwJR291ZHAwORspUw-8/edit#

[chro...@googlecode.com]

Updates:
Labels: Merge-TBD

Comment #7 on issue 397950 by bugdro...@chromium.org: "Show Managed

bookmarks" context menu option is shown even if there are no managed
bookmarks

http://code.google.com/p/chromium/issues/detail?id=397950#c7

Is there a merge required here?