Re: Issue 116561 in chromium: Webkit roll broke Scratchpad and GTalk apps

1 view
Skip to first unread message

chro...@googlecode.com

unread,
Mar 2, 2012, 1:00:07 PM3/2/12
to chromi...@chromium.org
Updates:
Cc: a...@chromium.org

Comment #1 on issue 116561 by stev...@chromium.org: Webkit roll broke
Scratchpad and GTalk apps
http://code.google.com/p/chromium/issues/detail?id=116561

(No comment was entered for this change.)

chro...@googlecode.com

unread,
Mar 2, 2012, 1:16:30 PM3/2/12
to chromi...@chromium.org

Comment #2 on issue 116561 by stev...@chromium.org: Webkit roll broke

I have isolated the issue to this WebKit commit:

commit 0514f7a38580410155846dc7e681e8cb66e027a2
Author: commit...@webkit.org
<commit...@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Feb 23 22:21:32 2012

Rename DOMWindow to Window in the bindings
https://bugs.webkit.org/show_bug.cgi?id=78721

Patch by Erik Arvidsson <a...@chromium.org> on 2012-02-23
Reviewed by Adam Barth.

chro...@googlecode.com

unread,
Mar 2, 2012, 1:49:00 PM3/2/12
to chromi...@chromium.org
Updates:
Cc: a...@chromium.org mpcom...@chromium.org
Labels: Feature-Extensions

Comment #3 on issue 116561 by a...@chromium.org: Webkit roll broke

The schema_generated_bindings.js somehow did not pick up my fix to change
all "DOMWindow" strings to "Window" strings in the extension manifests.

Does this need to be rebuilt somehow?

Reply all
Reply to author
Forward
0 new messages