Issue 128723 in chromium: Javascript: Uncaught TypeError with a form Input named "arguments"

[chro...@googlecode.com]

Status: Unconfirmed
Owner: ----
Labels: Type-Bug Pri-2 Area-Undefined OS-Windows

New issue 128723 by patrick....@gmail.com: Javascript: Uncaught TypeError
with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Chrome Version : 19.0.1084.46 (Official Build 135956) m
OS Version: 5.1 (Windows XP)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5: OK
Firefox 4.x: OK
IE 7/8/9: OK

What steps will reproduce the problem?
1.Run the chrome.html sample attached
2.Change value on Combo box

What is the expected result?
- The foo method must be invoked

What happens instead?
- Uncaught TypeError: undefined has no properties


Please provide any additional information below. Attach a screenshot if
possible.

- After investigation the problem is the name of hidden input.If you change
its name to another value, it work perfectly. The "arguments" name is
reserved ? I hope not... My framework imposes this name



Attachments:
chrome.html 581 bytes

[chro...@googlecode.com]

Comment #1 on issue 128723 by patrick....@gmail.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Others browser tested:
IE6: OK
Chrome < 19: OK

This is a regression, please add this issue on hight priority

[chro...@googlecode.com]

Comment #2 on issue 128723 by patrick....@gmail.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Another input: 16% of our customer are impacted with this issue

[chro...@googlecode.com]

Updates:
Status: Available
Cc: aba...@chromium.org hara...@chromium.org
Labels: -Type-Bug -Pri-2 -Area-Undefined Type-Regression Pri-1 Area-WebKit
WebKit-JavaScript Mstone-20 ReleaseBlock-Stable

Comment #3 on issue 128723 by tk...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

(No comment was entered for this change.)

[chro...@googlecode.com]

Updates:
Owner: hara...@chromium.org

Comment #4 on issue 128723 by hara...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

I'll take a look.

[chro...@googlecode.com]

Comment #5 on issue 128723 by hara...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

This is a regression caused by WebKit r110315.

Uploaded a bug-fix patch in WebKit:
https://bugs.webkit.org/show_bug.cgi?id=86991

[chro...@googlecode.com]

Comment #6 on issue 128723 by patrick....@gmail.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Thank you for your help.

Is there any chance that it is fixed in version 19 ?

[chro...@googlecode.com]

Comment #7 on issue 128723 by hara...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

I can submit a merge request, but it would depend on how critical the bug
is.

> Another input: 16% of our customer are impacted with this issue

What is the customer? How many?

[chro...@googlecode.com]

Comment #8 on issue 128723 by david.be...@gmail.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Please refer to my last email. Thank you in advance for your answer.

[chro...@googlecode.com]

Updates:
Cc: ul...@chromium.org

Comment #9 on issue 128723 by da...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Adding Ulan to also help take a look.

[chro...@googlecode.com]

Comment #10 on issue 128723 by veg...@google.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Quick fix in the bindings would be to use this instead of arguments. This
is keyword, not a variable refernce so it is not affected by WithStatement
(see ).

(function() {
return (function() {
with (this[2]) {
with (this[1]) {
with (this[0]) {
return function () { <listener body> };
}
}
}
}).call(arguments);
})

[chro...@googlecode.com]

Comment #11 on issue 128723 by veg...@google.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Code from comment #10 should not be used directly. It does not protect
itself from Function.prototype.call being replaced.

[chro...@googlecode.com]

Comment #12 on issue 128723 by hara...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Landed at r117928 in WebKit:
http://trac.webkit.org/changeset/117928

I will submit a merge request after confirming the behavior in the Canary
build.

[chro...@googlecode.com]

Updates:
Cc: dhar...@chromium.org lafo...@chromium.org
Labels: Merge-Requested

Comment #13 on issue 128723 by hara...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

I've confirmed that the patch is working well in the Canary build. Would
you merge the patch to M19 and M20?

dharani, laforge: This bug has been causing a serious revenue drop-down in
a world-wide e-commerce web site. (If you want to know the details, I can
forward an email that describes the details.)

[chro...@googlecode.com]

Updates:
Labels: -Merge-Requested Merge-Approved

Comment #14 on issue 128723 by dhar...@google.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

[chro...@googlecode.com]

Updates:
Cc: a...@chromium.org

Comment #15 on issue 128723 by lafo...@google.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Let's see how the change goes on M20. Right now there are no more planned
releases of 19, however I'll consider the merge once the change has at
least rolled out to beta, in the event that we need to do another 19 push.

Given that this is a regression, caused by
http://trac.webkit.org/changeset/110315, do we have a good understanding of
the implications of this fix? It looks like Erik (arv) landed the first
change, but I don't see him cc-ed on this bug (adding him for his opinion).

[chro...@googlecode.com]

Comment #16 on issue 128723 by a...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

We have a good understanding of this.

[chro...@googlecode.com]

Comment #19 on issue 128723 by eyal.lit...@gmail.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

I have the same issue when arguments must be a field in the submit form the
JP are not working

Attachments:
default.htm 1.1 KB

[chro...@googlecode.com]

Comment #20 on issue 128723 by a...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Haraken, are you planning to merge this into M19?

[chro...@googlecode.com]

Comment #21 on issue 128723 by hara...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

> Labels: -Mstone-20 -Merge-Approved Mstone-19 Merge-Requested
> Labels: -Merge-Requested Merge-Approved

laforge: Doesn't this mean that merge to M19 is already approved? I would
like to merge it into M19.

[chro...@googlecode.com]

Comment #22 on issue 128723 by lafo...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

That's correct.

[chro...@googlecode.com]

Updates:
Labels: -Mstone-19 -Merge-Approved Mstone-20

Comment #23 on issue 128723 by lafo...@google.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Looking at the Webkit branch, it looks like this did not get merged in time
for our final M19 build (last night's build). Looking at the bug history
this should already be resolved in M20 and as such I'm leaving it as a
ReleaseBlock-Stable issue for M20 (where it was originally flagged).

[chro...@googlecode.com]

Updates:
Status: Assigned
Labels: Merge-Approved

Comment #24 on issue 128723 by lafo...@google.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Marking this as merge-approved for M20, per-comment Dharani's approval in
comment 14, in case the merge has not already been done. Please update the
bug when it's complete.

[chro...@googlecode.com]

Comment #25 on issue 128723 by dhar...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

haraken@: could you please merge the change in M20 and close this bug?
thanks!

[chro...@googlecode.com]

Comment #26 on issue 128723 by hara...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

dharani: merged into revision 120197

[chro...@googlecode.com]

Comment #27 on issue 128723 by eyal.lit...@gmail.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

the link to revision 120197 is not working :(

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #28 on issue 128723 by hara...@chromium.org: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

Here: http://trac.webkit.org/changeset/120197

[chro...@googlecode.com]

Comment #29 on issue 128723 by eyal.lit...@gmail.com: Javascript: Uncaught

TypeError with a form Input named "arguments"
http://code.google.com/p/chromium/issues/detail?id=128723

thanks :)