Issue 477971 in chromium: Integrated PDF viewer doesnt work when content-disposition header contains UMLAUTE

[chro...@googlecode.com]

Status: Unconfirmed
Owner: ----
Labels: Cr-Platform-Extensions Pri-2 Via-Wizard Type-Bug OS-Windows

New issue 477971 by mgt...@gmail.com: Integrated PDF viewer doesnt work
when content-disposition header contains UMLAUTE
https://code.google.com/p/chromium/issues/detail?id=477971

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/42.0.2311.90 Safari/537.36

Steps to reproduce the problem:
1. Have Server return PDF File with Content-Disposition: inline;
filename="Test für us"
2. PDF is gray

What is the expected behavior?
Should display PDF

What went wrong?
German Umlaute are valid ISO-8859-1 characters. So I would have assumed
this to be ok with the Content-Disposition specs.

WebStore page: Chrome Internal PDF Viewer

Did this work before? N/A

Chrome version: 42.0.2311.90 Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 17.0 r0

attached node test program to reproduce.

As a side note: when the umlaut is uri encoded (%FC instead of ü) The file
is shown but the name is ignored, even though i would have assumed %FC to
be valid latin-1 characters as well (of course this would not decode into
an ü though)

Returning as UTF-8: e.g.
filename*=UTF-8''pdf%20mit%20name%20mit%20u%CC%88.pdf")
works but shouldnt be needed.

Attachments:
bug-chromium-pdf-content-disposition-encoding.zip 6.8 KB

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #1 on issue 477971 by mgt...@gmail.com: Integrated PDF viewer

doesnt work when content-disposition header contains UMLAUTE
https://code.google.com/p/chromium/issues/detail?id=477971

project also at:
https://github.com/matthiasg/bug-chromium-pdf-content-disposition-encoding

[chro...@googlecode.com]

Updates:
Owner: sa...@chromium.org
Cc: ray...@chromium.org

Comment #5 on issue 477971 by ray...@chromium.org: Integrated PDF viewer

doesnt work when content-disposition header contains UMLAUTE
https://code.google.com/p/chromium/issues/detail?id=477971

Sam: would you have time to have a look at this one?

[chro...@googlecode.com]

Comment #6 on issue 477971 by mswatil...@gmail.com: Integrated PDF viewer

doesnt work when content-disposition header contains UMLAUTE
https://code.google.com/p/chromium/issues/detail?id=477971

Have the same problem.
Interim workaround: Click right mouse button on grey tab and select "Save
as". After download it's possible to open the pdf file within Chrome.

[chro...@googlecode.com]

Updates:
Labels: -Merge-Approved merge-merged-2357

Comment #10 on issue 477971 by bugdro...@chromium.org: Integrated PDF

viewer doesnt work when content-disposition header contains UMLAUTE

https://code.google.com/p/chromium/issues/detail?id=477971#c10

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/d910f9ac3ea4d6224a66ce8f29266d21a8117d1f

commit d910f9ac3ea4d6224a66ce8f29266d21a8117d1f
Author: Sam McNally <sa...@chromium.org>
Date: Thu Apr 23 00:34:34 2015

Ignore non-ASCII headers in the mimeHandlerPrivate API.

BUG=477971

Review URL: https://codereview.chromium.org/1092163004

Cr-Commit-Position: refs/heads/master@{#326207}
(cherry picked from commit 17a2e3a0efda2fedfb29f78a71b748a3fa98c39b)

TBR=ray...@chromium.org

Review URL: https://codereview.chromium.org/1086553003

Cr-Commit-Position: refs/branch-heads/2357@{#202}
Cr-Branched-From:
59d4494849b405682265ed5d3f5164573b9a939b-refs/heads/master@{#323860}

[modify]
http://crrev.com/d910f9ac3ea4d6224a66ce8f29266d21a8117d1f/chrome/test/data/extensions/api_test/mime_handler_view/embedded.js
[add]
http://crrev.com/d910f9ac3ea4d6224a66ce8f29266d21a8117d1f/chrome/test/data/extensions/api_test/mime_handler_view/testNonAsciiHeaders.csv
[add]
http://crrev.com/d910f9ac3ea4d6224a66ce8f29266d21a8117d1f/chrome/test/data/extensions/api_test/mime_handler_view/testNonAsciiHeaders.csv.mock-http-headers
[modify]
http://crrev.com/d910f9ac3ea4d6224a66ce8f29266d21a8117d1f/extensions/browser/api/mime_handler_private/mime_handler_private.cc
[modify]
http://crrev.com/d910f9ac3ea4d6224a66ce8f29266d21a8117d1f/extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc
[modify]
http://crrev.com/d910f9ac3ea4d6224a66ce8f29266d21a8117d1f/extensions/common/api/mime_handler.mojom
[modify]
http://crrev.com/d910f9ac3ea4d6224a66ce8f29266d21a8117d1f/extensions/common/api/mime_handler_private.idl

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #11 on issue 477971 by sa...@chromium.org: Integrated PDF viewer

doesnt work when content-disposition header contains UMLAUTE
https://code.google.com/p/chromium/issues/detail?id=477971

(No comment was entered for this change.)