Re: Issue 155644 in chromium: Breakpoints don't peresist across apps v2 app reloads

3 views
Skip to first unread message

chro...@googlecode.com

unread,
Oct 16, 2012, 2:10:05 AM10/16/12
to chromi...@chromium.org
Updates:
Status: Assigned
Owner: tap...@chromium.org
Cc: benw...@chromium.org
Labels: Mstone-24

Comment #1 on issue 155644 by benw...@chromium.org: Breakpoints don't
peresist across apps v2 app reloads
http://code.google.com/p/chromium/issues/detail?id=155644

(No comment was entered for this change.)

chro...@googlecode.com

unread,
Oct 19, 2012, 3:08:27 PM10/19/12
to chromi...@chromium.org
Updates:
Labels: Feature-DevTools

Comment #2 on issue 155644 by sar...@chromium.org: Breakpoints don't

chro...@googlecode.com

unread,
Oct 21, 2012, 6:58:52 PM10/21/12
to chromi...@chromium.org

Comment #3 on issue 155644 by benwe...@google.com: Breakpoints don't
I believe the breakpoints are persisted but don't fire unless the devtools
are open. As the devools don't reopen after a reload, the breakpoints don't
fire. We'll test to make sure this is the case, as it's critical you can
put breakpoints in your window startup logic and reload the app.

chro...@googlecode.com

unread,
Oct 21, 2012, 10:50:38 PM10/21/12
to chromi...@chromium.org

Comment #4 on issue 155644 by rgi...@chromium.org: Breakpoints don't
I think I was seeing this on the app background page.

chro...@googlecode.com

unread,
Oct 23, 2012, 12:16:04 PM10/23/12
to chromi...@chromium.org
Updates:
Owner: vse...@chromium.org
Cc: tap...@chromium.org

Comment #5 on issue 155644 by pfeld...@chromium.org: Breakpoints don't

chro...@googlecode.com

unread,
Oct 23, 2012, 5:50:59 PM10/23/12
to chromi...@chromium.org
Updates:
Status: Started
Owner: tap...@chromium.org
Cc: vse...@chromium.org

Comment #6 on issue 155644 by benw...@chromium.org: Breakpoints don't
Trent has a patch up for this already, should be committed today. It
doesn't require any changes outside extensions.

chro...@googlecode.com

unread,
Oct 23, 2012, 8:20:30 PM10/23/12
to chromi...@chromium.org

Comment #7 on issue 155644 by tap...@chromium.org: Breakpoints don't
I think https://chromiumcodereview.appspot.com/11238055/ will fix this for
non-background pages.

Background pages (I think) already work -- I can't reproduce this for
background pages. However, just clicking 'Reload' in chrome://extensions
sometimes isn't enough. An application needs to be _launched_ as well. I
think this is as intended.

That is, chrome://extensions -> Reload on a launched app will also relaunch
the app and hit any breakpoints in the background page. However, just
inspecting the background page via chrome://extensions and clicking Reload
(i.e. without the application running) will not trigger a launch, and so
not trigger breakpoints.

chro...@googlecode.com

unread,
Oct 23, 2012, 8:56:30 PM10/23/12
to chromi...@chromium.org

Comment #8 on issue 155644 by tap...@chromium.org: Breakpoints don't
Actually, this might be a racy problem.. I think I was (once) able to
reproduce this for a breakpoint outside the onLaunched event on a
background page in Chrome Version 23.0.1271.40 beta on Linux.

However, trying the same beta on OSX seems to work, as well as some OSX
canaries (1304,1305). Going back to my Linux beta, I can't reproduce it any
more. Also can't reproduce in a debug build@r163531, and a release build at
Version 24.0.1304.0 (163214).

chro...@googlecode.com

unread,
Nov 1, 2012, 2:22:06 AM11/1/12
to chromi...@chromium.org
Updates:
Labels: -Mstone-24 Mstone-25

Comment #9 on issue 155644 by tap...@chromium.org: Breakpoints don't
Reply all
Reply to author
Forward
0 new messages