Issue 559530 in chromium: msan bots broken after clang roll

[chro...@googlecode.com]

Status: Untriaged
Owner: ----
CC: euge...@chromium.org
Labels: Type-Bug Pri-1 Build OS-Linux

New issue 559530 by h...@chromium.org: msan bots broken after clang roll
https://code.google.com/p/chromium/issues/detail?id=559530

Examples:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/5457
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/11623

Local repro:

Checkout the Clang roll: 6a0a6e2c285cf215a15755ab9d32b386947a77b1 /
master@{#360938}

$ GYP_DEFINES="chromeos=1 clang=1 component=static_library msan=1
msan_track_origins=2 target_arch=x64 use_prebuilt_instrumented_libraries=1"
gclient sync -j12
$ ninja -C out/Release base_unittests
$ MSAN_OPTIONS=symbolize=0 out/Release/base_unittests
Segmentation fault (core dumped)

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Updates:
Cc: tha...@chromium.org

Comment #2 on issue 559530 by h...@chromium.org: msan bots broken after
clang roll
https://code.google.com/p/chromium/issues/detail?id=559530

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #3 on issue 559530 by bugd...@chromium.org: msan bots broken
after clang roll
https://code.google.com/p/chromium/issues/detail?id=559530#c3

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/c21ad3ccd0ca211b8403966826ce44b7034daf91

commit c21ad3ccd0ca211b8403966826ce44b7034daf91
Author: hans <ha...@chromium.org>
Date: Sat Nov 21 06:07:39 2015

Revert of Roll clang 247874:253678 (patchset #1 id:1 of
https://codereview.chromium.org/1461003007/ )

Reason for revert:
MSan was broken by the roll.

Original issue's description:
> Roll clang 247874:253678

> Also revert https://codereview.chromium.org/1375193005 for bootstrap
> builds,
> else compiler-rt won't build in that config. See comment 45 on the bug.

> BUG=538614
> R=tha...@chromium.org

> Committed:
> https://chromium.googlesource.com/chromium/src/+/6a0a6e2c285cf215a15755ab9d32b386947a77b1

TBR=tha...@chromium.org,the...@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=538614, 559530

Review URL: https://codereview.chromium.org/1460503011

Cr-Commit-Position: refs/heads/master@{#361010}

[modify]
http://crrev.com/c21ad3ccd0ca211b8403966826ce44b7034daf91/tools/clang/scripts/update.py
[modify]
http://crrev.com/c21ad3ccd0ca211b8403966826ce44b7034daf91/tools/clang/scripts/update.sh

[chro...@googlecode.com]

Updates:
Cc: h...@chromium.org

Comment #5 on issue 559530 by euge...@chromium.org: msan bots broken after
clang roll
https://code.google.com/p/chromium/issues/detail?id=559530

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #9 on issue 559530 by tha...@chromium.org: msan bots broken after
clang roll
https://code.google.com/p/chromium/issues/detail?id=559530

Want to add one of them to src/docs/updating_clang.md then?

[chro...@googlecode.com]

Comment #12 on issue 559530 by bugd...@chromium.org: msan bots broken
after clang roll
https://code.google.com/p/chromium/issues/detail?id=559530#c12

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/4fea0f71e935f43777c5f0c0b488910f9e7490ad

commit 4fea0f71e935f43777c5f0c0b488910f9e7490ad
Author: Hans Wennborg <ha...@chromium.org>
Date: Wed Nov 25 17:33:33 2015

Roll Clang 247874:254049

Also revert https://codereview.chromium.org/1375193005 for bootstrap builds,
else compiler-rt won't build in that config. See comment 45 on the bug.

This also pins MSan to the old ABI:

MSan had a ABI change upstream. Picking it up in Chromium requires
rebuilding prebuilt_instrumented_libraries with the new clang.
Unfortunately, this fails.

This changes switches clang back to the old MSan ABI until we can
sort this out.

Upstream issue:
https://github.com/google/sanitizers/issues/579

BUG=538614, 559530, 560589
R=tha...@chromium.org

Review URL: https://codereview.chromium.org/1474923002 .

Cr-Commit-Position: refs/heads/master@{#361689}

[modify]
http://crrev.com/4fea0f71e935f43777c5f0c0b488910f9e7490ad/build/common.gypi
[modify]
http://crrev.com/4fea0f71e935f43777c5f0c0b488910f9e7490ad/build/config/sanitizers/BUILD.gn
[modify]
http://crrev.com/4fea0f71e935f43777c5f0c0b488910f9e7490ad/tools/clang/scripts/update.py
[modify]
http://crrev.com/4fea0f71e935f43777c5f0c0b488910f9e7490ad/tools/clang/scripts/update.sh

[chro...@googlecode.com]

Comment #13 on issue 559530 by bugd...@chromium.org: msan bots broken
after clang roll
https://code.google.com/p/chromium/issues/detail?id=559530#c13

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/58f4a052a1e0c6a4eff5cfdbc3c4761dc4adf781

commit 58f4a052a1e0c6a4eff5cfdbc3c4761dc4adf781
Author: machenbach <mache...@chromium.org>
Date: Thu Nov 26 10:34:10 2015

[build] Fix msan after clang roll.

Port https://codereview.chromium.org/1474923002

BUG=chromium:538614,chromium:559530,chromium:560589
LOG=n
TBR=joc...@chromium.org, tha...@chromium.org, ha...@chromium.org,

Review URL: https://codereview.chromium.org/1478863005

Cr-Commit-Position: refs/heads/master@{#32326}

[modify]
http://crrev.com/58f4a052a1e0c6a4eff5cfdbc3c4761dc4adf781/build/standalone.gypi

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #14 on issue 559530 by tha...@chromium.org: msan bots broken after
clang roll
https://code.google.com/p/chromium/issues/detail?id=559530

Fixed, right?