Issue 127771 in chromium: ash: Move battery status into Settings row in uber tray popup

[chro...@googlecode.com]

Status: Assigned
Owner: jen...@chromium.org
CC: stev...@chromium.org
Labels: OS-Chrome Area-UI Type-Bug Pri-1 Feature-Ash-Tray Mstone-21

New issue 127771 by sad...@chromium.org: ash: Move battery status into
Settings row in uber tray popup
http://code.google.com/p/chromium/issues/detail?id=127771

The battery-status should move into the Settings row in the uber tray popup.

The implementation should move PowerStatusView out of power/tray_power into
power/power_status_view, and it should be used in settings/tray_settings.

Since we don't have power info at all in the uber-tray popup at this moment
(due to changes in other rows in the popup), this is P1.

[chro...@googlecode.com]

Updates:
Blockedon: 124725

Comment #1 on issue 127771 by stev...@chromium.org: ash: Move battery

status into Settings row in uber tray popup
http://code.google.com/p/chromium/issues/detail?id=127771

I just pushed issue 124725 @ 136618 which has the PowerStatusView
implementation.
Note: I don't have updated mocks for the notification view, and I think the
icon needs work. I plan to go over it with Alex on Tuesday, but if you want
to talk to him about it first, that's cool, just let me know.

To see the notification on Linux, run with --aura-notify and open up the
status area. The battery will start to drain and the notification will show
when the batter is low and the "default view" is hidden.

[chro...@googlecode.com]

Comment #2 on issue 127771 by jen...@chromium.org: ash: Move battery status

into Settings row in uber tray popup
http://code.google.com/p/chromium/issues/detail?id=127771

Thanks for update. I am working on adding left/rioght tray support, won't
do this one until i finish it.

[chro...@googlecode.com]

Comment #4 on issue 127771 by sain...@chromium.org: ash: Move battery

status into Settings row in uber tray popup
http://code.google.com/p/chromium/issues/detail?id=127771

yes please we need it back

[chro...@googlecode.com]

Comment #7 on issue 127771 by stev...@chromium.org: ash: Move battery

status into Settings row in uber tray popup
http://code.google.com/p/chromium/issues/detail?id=127771

When we do this we should also change the notification layout to match SMS
/ Network (issue 124727 is up for review).
We probably want larger icons also.

[chro...@googlecode.com]

Comment #8 on issue 127771 by Kusc...@chromium.org: ash: Move battery

status into Settings row in uber tray popup
http://code.google.com/p/chromium/issues/detail?id=127771

Mock for this bug can be found here:

https://docs.google.com/a/google.com/file/d/0B7t22qFrueRsVVAza0dtWmN5ZlE/view

[chro...@googlecode.com]

Updates:
Status: Started

Comment #9 on issue 127771 by jen...@chromium.org: ash: Move battery status

into Settings row in uber tray popup
http://code.google.com/p/chromium/issues/detail?id=127771

(No comment was entered for this change.)

[chro...@googlecode.com]

Issue 127771: ash: Move battery status into Settings row in uber tray popup
http://code.google.com/p/chromium/issues/detail?id=127771

This issue is no longer blocking issue 124074.
See http://code.google.com/p/chromium/issues/detail?id=124074
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

[chro...@googlecode.com]

Updates:
Cc: kr...@chromium.org tturche...@chromium.org rby...@chromium.org
jen...@chromium.org

Comment #10 on issue 127771 by sad...@chromium.org: ash: Move battery

status into Settings row in uber tray popup
http://code.google.com/p/chromium/issues/detail?id=127771

Issue 131079 has been merged into this issue.

[chro...@googlecode.com]

Comment #12 on issue 127771 by bugdro...@chromium.org: ash: Move battery

status into Settings row in uber tray popup

http://code.google.com/p/chromium/issues/detail?id=127771#c12

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=141237

------------------------------------------------------------------------
r141237 | jen...@google.com | Fri Jun 08 10:59:31 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/system/ash_system_tray_delegate.cc?r1=141237&r2=141236&pathrev=141237
A
http://src.chromium.org/viewvc/chrome/trunk/src/ash/system/power/power_status_view.cc?r1=141237&r2=141236&pathrev=141237
M
http://src.chromium.org/viewvc/chrome/trunk/src/ash/system/power/tray_power.h?r1=141237&r2=141236&pathrev=141237
M
http://src.chromium.org/viewvc/chrome/trunk/src/ash/ash_strings.grd?r1=141237&r2=141236&pathrev=141237
A
http://src.chromium.org/viewvc/chrome/trunk/src/ash/system/power/power_status_view.h?r1=141237&r2=141236&pathrev=141237
M
http://src.chromium.org/viewvc/chrome/trunk/src/ash/system/power/tray_power.cc?r1=141237&r2=141236&pathrev=141237
M
http://src.chromium.org/viewvc/chrome/trunk/src/ash/ash.gyp?r1=141237&r2=141236&pathrev=141237
M
http://src.chromium.org/viewvc/chrome/trunk/src/ash/system/tray/system_tray.h?r1=141237&r2=141236&pathrev=141237
M
http://src.chromium.org/viewvc/chrome/trunk/src/ash/system/settings/tray_settings.cc?r1=141237&r2=141236&pathrev=141237
M
http://src.chromium.org/viewvc/chrome/trunk/src/ash/system/settings/tray_settings.h?r1=141237&r2=141236&pathrev=141237
M
http://src.chromium.org/viewvc/chrome/trunk/src/ash/system/tray/system_tray.cc?r1=141237&r2=141236&pathrev=141237

Add battery status to settings row in uber tray bubble.

BUG=127771
TEST=power status showing on settings row if the battery presents.

Review URL: https://chromiumcodereview.appspot.com/10540041
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #13 on issue 127771 by jen...@chromium.org: ash: Move battery

status into Settings row in uber tray popup

[chro...@googlecode.com]

Comment #14 on issue 127771 by bugdro...@chromium.org: ash: Move battery

status into Settings row in uber tray popup

http://code.google.com/p/chromium/issues/detail?id=127771#c14

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=141527

------------------------------------------------------------------------
r141527 | jen...@google.com | Mon Jun 11 15:18:34 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/ash/system/power/power_status_view.cc?r1=141527&r2=141526&pathrev=141527

Work around the crOS battery time reporting issue crosbug.com/31633 in ash
tray battery UI.

BUG=127771
TEST=battery time displayed on ash tray bubble settings row does not
contain garbage time when user switch log in state.

Review URL: https://chromiumcodereview.appspot.com/10535118
------------------------------------------------------------------------