Issue 103909 in chromium: Add Chrome last-run detection to the GCAPI dll.

29 views
Skip to first unread message

chro...@googlecode.com

unread,
Nov 11, 2011, 10:51:23 AM11/11/11
to chromi...@chromium.org
Status: Started
Owner: robertsh...@chromium.org
CC: amru...@google.com, gwil...@chromium.org, roge...@chromium.org
Labels: Type-Bug Pri-2 Area-Internals

New issue 103909 by robertsh...@chromium.org: Add Chrome last-run detection
to the GCAPI dll.
http://code.google.com/p/chromium/issues/detail?id=103909

See summary.

chro...@googlecode.com

unread,
Nov 14, 2011, 2:16:25 PM11/14/11
to chromi...@chromium.org

Comment #1 on issue 103909 by bugdro...@chromium.org: Add Chrome last-run
detection to the GCAPI dll.
http://code.google.com/p/chromium/issues/detail?id=103909#c1

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=109919

------------------------------------------------------------------------
r109919 | robert...@chromium.org | Mon Nov 14 10:57:36 PST 2011

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/gcapi/gcapi.h?r1=109919&r2=109918&pathrev=109919
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/gcapi/gcapi_test.cc?r1=109919&r2=109918&pathrev=109919
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_installer.gypi?r1=109919&r2=109918&pathrev=109919
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/gcapi/gcapi_last_run_test.cc?r1=109919&r2=109918&pathrev=109919
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/gcapi/gcapi.cc?r1=109919&r2=109918&pathrev=109919
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/gcapi/gcapi.def?r1=109919&r2=109918&pathrev=109919

Add functionality to the GCAPI to detect when Chrome was last run.

Also fix a buffer overrun while I'm here.

Also, fix up the export definitions to use the more-sane .def file approach.

BUG=103909,88622
TEST=Invoke the GoogleChromeDaysSinceLastRun() export on GCAPI.dll, observe
that it reports the number of days since Chrome was last run.
Review URL: http://codereview.chromium.org/8508060
------------------------------------------------------------------------

chro...@googlecode.com

unread,
Nov 14, 2011, 2:45:19 PM11/14/11
to chromi...@chromium.org
Updates:
Status: Fixed

Comment #2 on issue 103909 by robertsh...@chromium.org: Add Chrome last-run

(No comment was entered for this change.)

Reply all
Reply to author
Forward
0 new messages